mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Armandas Kvietkus <armundunelis@gmail.com>,
	luke@ljones.dev, denis.benato@linux.dev
Cc: hansg@kernel.org, ilpo.jarvinen@linux.intel.com,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, fxzxaxon@outlook.com
Subject: Re: [PATCH 2/2] platform/x86: asus-armoury: downgrade missing power limits warning to info
Date: Mon, 4 May 2026 09:05:33 -0500	[thread overview]
Message-ID: <933d555d-183a-4f72-a8e8-822e6dd9758d@amd.com> (raw)
In-Reply-To: <20260504072734.17113-1-armundunelis@gmail.com>



On 5/4/26 02:27, Armandas Kvietkus wrote:
> [You don't often get email from armundunelis@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> When a system is not found in the power_limits DMI table,
> init_rog_tunables() emits a pr_warn() and returns. This is
> expected behaviour for hardware that does not support ROG
> power limit tunables, not an error condition.
> 
> Downgrade to pr_info() to avoid spurious boot noise on
> unsupported systems while keeping the message visible in
> default distro configurations.
> 
> v2: use pr_info() instead of pr_debug() to ensure the message
>      remains visible without dynamic debug (Denis Benato)
> 
> Reported-by: fxzxaxon@outlook.com
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221441
> Signed-off-by: Armandas Kvietkus <armundunelis@gmail.com>
> ---

I thought the whole point of this message was so that the limits could 
be looked up and reported.

If anything I would argue there should be more added to this message 
telling people to come file a bug report to the appropriate place to get 
the limits determined and added.

>   drivers/platform/x86/asus-armoury.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
> index 5b0987ccc..b87e0b601 100644
> --- a/drivers/platform/x86/asus-armoury.c
> +++ b/drivers/platform/x86/asus-armoury.c
> @@ -991,7 +991,7 @@ static void init_rog_tunables(void)
>          /* Match the system against the power_limits table */
>          dmi_id = dmi_first_match(power_limits);
>          if (!dmi_id) {
> -               pr_warn("No matching power limits found for this system\n");
> +               pr_info("No matching power limits found for this system\n");
>                  return;
>          }
> 
> --
> 2.54.0
> 
> 


      reply	other threads:[~2026-05-04 14:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04  7:27 Armandas Kvietkus
2026-05-04 14:05 ` Mario Limonciello [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=933d555d-183a-4f72-a8e8-822e6dd9758d@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=armundunelis@gmail.com \
    --cc=denis.benato@linux.dev \
    --cc=fxzxaxon@outlook.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®