mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 2/2] platform/x86: asus-armoury: downgrade missing power limits warning to info
@ 2026-05-04  7:27 Armandas Kvietkus
  2026-05-04 14:05 ` Mario Limonciello
  0 siblings, 1 reply; 2+ messages in thread
From: Armandas Kvietkus @ 2026-05-04  7:27 UTC (permalink / raw)
  To: luke, denis.benato
  Cc: hansg, ilpo.jarvinen, platform-driver-x86, linux-kernel,
	Armandas Kvietkus, fxzxaxon

When a system is not found in the power_limits DMI table,
init_rog_tunables() emits a pr_warn() and returns. This is
expected behaviour for hardware that does not support ROG
power limit tunables, not an error condition.

Downgrade to pr_info() to avoid spurious boot noise on
unsupported systems while keeping the message visible in
default distro configurations.

v2: use pr_info() instead of pr_debug() to ensure the message
    remains visible without dynamic debug (Denis Benato)

Reported-by: fxzxaxon@outlook.com
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221441
Signed-off-by: Armandas Kvietkus <armundunelis@gmail.com>
---
 drivers/platform/x86/asus-armoury.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
index 5b0987ccc..b87e0b601 100644
--- a/drivers/platform/x86/asus-armoury.c
+++ b/drivers/platform/x86/asus-armoury.c
@@ -991,7 +991,7 @@ static void init_rog_tunables(void)
 	/* Match the system against the power_limits table */
 	dmi_id = dmi_first_match(power_limits);
 	if (!dmi_id) {
-		pr_warn("No matching power limits found for this system\n");
+		pr_info("No matching power limits found for this system\n");
 		return;
 	}
 
-- 
2.54.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/2] platform/x86: asus-armoury: downgrade missing power limits warning to info
  2026-05-04  7:27 [PATCH 2/2] platform/x86: asus-armoury: downgrade missing power limits warning to info Armandas Kvietkus
@ 2026-05-04 14:05 ` Mario Limonciello
  0 siblings, 0 replies; 2+ messages in thread
From: Mario Limonciello @ 2026-05-04 14:05 UTC (permalink / raw)
  To: Armandas Kvietkus, luke, denis.benato
  Cc: hansg, ilpo.jarvinen, platform-driver-x86, linux-kernel, fxzxaxon



On 5/4/26 02:27, Armandas Kvietkus wrote:
> [You don't often get email from armundunelis@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> When a system is not found in the power_limits DMI table,
> init_rog_tunables() emits a pr_warn() and returns. This is
> expected behaviour for hardware that does not support ROG
> power limit tunables, not an error condition.
> 
> Downgrade to pr_info() to avoid spurious boot noise on
> unsupported systems while keeping the message visible in
> default distro configurations.
> 
> v2: use pr_info() instead of pr_debug() to ensure the message
>      remains visible without dynamic debug (Denis Benato)
> 
> Reported-by: fxzxaxon@outlook.com
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221441
> Signed-off-by: Armandas Kvietkus <armundunelis@gmail.com>
> ---

I thought the whole point of this message was so that the limits could 
be looked up and reported.

If anything I would argue there should be more added to this message 
telling people to come file a bug report to the appropriate place to get 
the limits determined and added.

>   drivers/platform/x86/asus-armoury.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
> index 5b0987ccc..b87e0b601 100644
> --- a/drivers/platform/x86/asus-armoury.c
> +++ b/drivers/platform/x86/asus-armoury.c
> @@ -991,7 +991,7 @@ static void init_rog_tunables(void)
>          /* Match the system against the power_limits table */
>          dmi_id = dmi_first_match(power_limits);
>          if (!dmi_id) {
> -               pr_warn("No matching power limits found for this system\n");
> +               pr_info("No matching power limits found for this system\n");
>                  return;
>          }
> 
> --
> 2.54.0
> 
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-05-04 14:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-04  7:27 [PATCH 2/2] platform/x86: asus-armoury: downgrade missing power limits warning to info Armandas Kvietkus
2026-05-04 14:05 ` Mario Limonciello

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®