* [PATCH bpf-next v1 0/2] bpf: Introduce execution context detection kfuncs @ 2026-01-23 8:42 Changwoo Min 2026-01-23 8:42 ` [PATCH bpf-next v1 1/2] " Changwoo Min 2026-01-23 8:42 ` [PATCH bpf-next v1 2/2] selftests/bpf: Add tests for execution context kfuncs Changwoo Min 0 siblings, 2 replies; 6+ messages in thread From: Changwoo Min @ 2026-01-23 8:42 UTC (permalink / raw) To: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko Cc: Martin KaFai Lau, Eduard Zingerman, Song Liu, Yonghong Song, John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa, Shuah Khan, kernel-dev, bpf, sched-ext, linux-kernel, linux-kselftest, Changwoo Min This series introduces four new kfuncs -- bpf_in_nmi(), bpf_in_hardirq(), bpf_in_serving_softirq(), and bpf_in_task() -- to allow BPF programs to query the current execution context. While BPF programs can often infer their context from attachment points, subsystems like sched_ext may call the same BPF logic from multiple contexts (e.g., task-to-task wake-ups vs. interrupt-to-task wake-ups). These kfuncs provide a reliable way to branch logic based on the current CPU execution state. The series includes a new selftest suite, ctx_kfunc, which uses bpf_testmod to verify context detection across Task, HardIRQ, and SoftIRQ boundaries via irq_work and tasklets. NMI context testing is omitted from the suite as NMIs cannot be triggered deterministically within the software-only environments typically used for BPF CI. Changwoo Min (2): bpf: Introduce execution context detection kfuncs selftests/bpf: Add tests for execution context kfuncs kernel/bpf/helpers.c | 44 ++++++++++++++ .../selftests/bpf/prog_tests/ctx_kfunc.c | 59 +++++++++++++++++++ tools/testing/selftests/bpf/progs/test_ctx.c | 51 ++++++++++++++++ .../selftests/bpf/test_kmods/bpf_testmod.c | 32 ++++++++++ .../bpf/test_kmods/bpf_testmod_kfunc.h | 4 ++ 5 files changed, 190 insertions(+) create mode 100644 tools/testing/selftests/bpf/prog_tests/ctx_kfunc.c create mode 100644 tools/testing/selftests/bpf/progs/test_ctx.c -- 2.52.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH bpf-next v1 1/2] bpf: Introduce execution context detection kfuncs 2026-01-23 8:42 [PATCH bpf-next v1 0/2] bpf: Introduce execution context detection kfuncs Changwoo Min @ 2026-01-23 8:42 ` Changwoo Min 2026-01-23 16:37 ` Alexei Starovoitov 2026-01-23 8:42 ` [PATCH bpf-next v1 2/2] selftests/bpf: Add tests for execution context kfuncs Changwoo Min 1 sibling, 1 reply; 6+ messages in thread From: Changwoo Min @ 2026-01-23 8:42 UTC (permalink / raw) To: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko Cc: Martin KaFai Lau, Eduard Zingerman, Song Liu, Yonghong Song, John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa, Shuah Khan, kernel-dev, bpf, sched-ext, linux-kernel, linux-kselftest, Changwoo Min Introduce bpf_in_nmi(), bpf_in_hardirq(), bpf_in_serving_softirq(), and bpf_in_task() kfuncs to allow BPF programs to query the current execution context. While BPF programs can sometimes infer context based on the attach point, certain programs (such as those in sched_ext) may be called from multiple contexts. These kfuncs provide a reliable way for logic to branch based on whether the CPU is currently handling an interrupt or executing in task context. For example, this is particularly useful for sched_ext schedulers that need to differentiate between task-to-task wake-ups and interrupt-to-task wake-ups. As the names imply, these helpers wrap the kernel's internal in_nmi(), in_hardirq(), in_serving_softirq(), and in_task() macros. Signed-off-by: Changwoo Min <changwoo@igalia.com> --- kernel/bpf/helpers.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c index 637677815365..cb36bc7a80c6 100644 --- a/kernel/bpf/helpers.c +++ b/kernel/bpf/helpers.c @@ -4365,6 +4365,46 @@ __bpf_kfunc int bpf_dynptr_file_discard(struct bpf_dynptr *dynptr) return 0; } +/** + * bpf_in_nmi - Test if the current execution context is in NMI context. + * + * Return: true if we are in NMI context, false otherwise. + */ +__bpf_kfunc bool bpf_in_nmi(void) +{ + return in_nmi(); +} + +/** + * bpf_in_hardirq - Test if the current execution context is in hard IRQ context. + * + * Return: true if we are in hard IRQ context, false otherwise. + */ +__bpf_kfunc bool bpf_in_hardirq(void) +{ + return in_hardirq(); +} + +/** + * bpf_in_serving_softirq - Test if the current execution context is in softirq context. + * + * Return: true if we are in softirq context, false otherwise. + */ +__bpf_kfunc bool bpf_in_serving_softirq(void) +{ + return in_serving_softirq(); +} + +/** + * bpf_in_task - Test if the current execution context is in task context. + * + * Return: true if we are in task context, false otherwise. + */ +__bpf_kfunc bool bpf_in_task(void) +{ + return in_task(); +} + __bpf_kfunc_end_defs(); static void bpf_task_work_cancel_scheduled(struct irq_work *irq_work) @@ -4546,6 +4586,10 @@ BTF_ID_FLAGS(func, bpf_task_work_schedule_signal, KF_IMPLICIT_ARGS) BTF_ID_FLAGS(func, bpf_task_work_schedule_resume, KF_IMPLICIT_ARGS) BTF_ID_FLAGS(func, bpf_dynptr_from_file) BTF_ID_FLAGS(func, bpf_dynptr_file_discard) +BTF_ID_FLAGS(func, bpf_in_nmi) +BTF_ID_FLAGS(func, bpf_in_hardirq) +BTF_ID_FLAGS(func, bpf_in_serving_softirq) +BTF_ID_FLAGS(func, bpf_in_task) BTF_KFUNCS_END(common_btf_ids) static const struct btf_kfunc_id_set common_kfunc_set = { -- 2.52.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bpf-next v1 1/2] bpf: Introduce execution context detection kfuncs 2026-01-23 8:42 ` [PATCH bpf-next v1 1/2] " Changwoo Min @ 2026-01-23 16:37 ` Alexei Starovoitov 2026-01-24 11:29 ` Changwoo Min 0 siblings, 1 reply; 6+ messages in thread From: Alexei Starovoitov @ 2026-01-23 16:37 UTC (permalink / raw) To: Changwoo Min Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, Martin KaFai Lau, Eduard Zingerman, Song Liu, Yonghong Song, John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa, Shuah Khan, kernel-dev, bpf, sched-ext, LKML, open list:KERNEL SELFTEST FRAMEWORK On Fri, Jan 23, 2026 at 12:43 AM Changwoo Min <changwoo@igalia.com> wrote: > > Introduce bpf_in_nmi(), bpf_in_hardirq(), bpf_in_serving_softirq(), and > bpf_in_task() kfuncs to allow BPF programs to query the current execution > context. > > While BPF programs can sometimes infer context based on the attach point, > certain programs (such as those in sched_ext) may be called from multiple > contexts. These kfuncs provide a reliable way for logic to branch based on > whether the CPU is currently handling an interrupt or executing in task > context. > > For example, this is particularly useful for sched_ext schedulers that need > to differentiate between task-to-task wake-ups and interrupt-to-task > wake-ups. > > As the names imply, these helpers wrap the kernel's internal in_nmi(), > in_hardirq(), in_serving_softirq(), and in_task() macros. > > Signed-off-by: Changwoo Min <changwoo@igalia.com> > --- > kernel/bpf/helpers.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c > index 637677815365..cb36bc7a80c6 100644 > --- a/kernel/bpf/helpers.c > +++ b/kernel/bpf/helpers.c > @@ -4365,6 +4365,46 @@ __bpf_kfunc int bpf_dynptr_file_discard(struct bpf_dynptr *dynptr) > return 0; > } > > +/** > + * bpf_in_nmi - Test if the current execution context is in NMI context. > + * > + * Return: true if we are in NMI context, false otherwise. > + */ > +__bpf_kfunc bool bpf_in_nmi(void) > +{ > + return in_nmi(); > +} > + > +/** > + * bpf_in_hardirq - Test if the current execution context is in hard IRQ context. > + * > + * Return: true if we are in hard IRQ context, false otherwise. > + */ > +__bpf_kfunc bool bpf_in_hardirq(void) > +{ > + return in_hardirq(); > +} > + > +/** > + * bpf_in_serving_softirq - Test if the current execution context is in softirq context. > + * > + * Return: true if we are in softirq context, false otherwise. > + */ > +__bpf_kfunc bool bpf_in_serving_softirq(void) > +{ > + return in_serving_softirq(); > +} > + > +/** > + * bpf_in_task - Test if the current execution context is in task context. > + * > + * Return: true if we are in task context, false otherwise. > + */ > +__bpf_kfunc bool bpf_in_task(void) > +{ > + return in_task(); > +} > + This functionality is already available. See bpf_in_interrupt() and get_preempt_count() in bpf_experimental.h. No need to replicate that as kfuncs. If something can be implemented as a bpf program it should stay as pure bpf code, since it's more flexible and faster this way. llvm together with JITs completely inline get_preempt_count(). pw-bot: cr ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bpf-next v1 1/2] bpf: Introduce execution context detection kfuncs 2026-01-23 16:37 ` Alexei Starovoitov @ 2026-01-24 11:29 ` Changwoo Min 0 siblings, 0 replies; 6+ messages in thread From: Changwoo Min @ 2026-01-24 11:29 UTC (permalink / raw) To: Alexei Starovoitov Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, Martin KaFai Lau, Eduard Zingerman, Song Liu, Yonghong Song, John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa, Shuah Khan, kernel-dev, bpf, sched-ext, LKML, open list:KERNEL SELFTEST FRAMEWORK Hi Alexei, Thank you for the feedback. On 1/24/26 1:37 AM, Alexei Starovoitov wrote: > On Fri, Jan 23, 2026 at 12:43 AM Changwoo Min <changwoo@igalia.com> wrote: >> >> Introduce bpf_in_nmi(), bpf_in_hardirq(), bpf_in_serving_softirq(), and >> bpf_in_task() kfuncs to allow BPF programs to query the current execution >> context. >> >> While BPF programs can sometimes infer context based on the attach point, >> certain programs (such as those in sched_ext) may be called from multiple >> contexts. These kfuncs provide a reliable way for logic to branch based on >> whether the CPU is currently handling an interrupt or executing in task >> context. >> >> For example, this is particularly useful for sched_ext schedulers that need >> to differentiate between task-to-task wake-ups and interrupt-to-task >> wake-ups. >> >> As the names imply, these helpers wrap the kernel's internal in_nmi(), >> in_hardirq(), in_serving_softirq(), and in_task() macros. >> >> Signed-off-by: Changwoo Min <changwoo@igalia.com> >> --- >> kernel/bpf/helpers.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 44 insertions(+) >> >> diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c >> index 637677815365..cb36bc7a80c6 100644 >> --- a/kernel/bpf/helpers.c >> +++ b/kernel/bpf/helpers.c >> @@ -4365,6 +4365,46 @@ __bpf_kfunc int bpf_dynptr_file_discard(struct bpf_dynptr *dynptr) >> return 0; >> } >> >> +/** >> + * bpf_in_nmi - Test if the current execution context is in NMI context. >> + * >> + * Return: true if we are in NMI context, false otherwise. >> + */ >> +__bpf_kfunc bool bpf_in_nmi(void) >> +{ >> + return in_nmi(); >> +} >> + >> +/** >> + * bpf_in_hardirq - Test if the current execution context is in hard IRQ context. >> + * >> + * Return: true if we are in hard IRQ context, false otherwise. >> + */ >> +__bpf_kfunc bool bpf_in_hardirq(void) >> +{ >> + return in_hardirq(); >> +} >> + >> +/** >> + * bpf_in_serving_softirq - Test if the current execution context is in softirq context. >> + * >> + * Return: true if we are in softirq context, false otherwise. >> + */ >> +__bpf_kfunc bool bpf_in_serving_softirq(void) >> +{ >> + return in_serving_softirq(); >> +} >> + >> +/** >> + * bpf_in_task - Test if the current execution context is in task context. >> + * >> + * Return: true if we are in task context, false otherwise. >> + */ >> +__bpf_kfunc bool bpf_in_task(void) >> +{ >> + return in_task(); >> +} >> + > > This functionality is already available. > See bpf_in_interrupt() and get_preempt_count() in bpf_experimental.h. > > No need to replicate that as kfuncs. I see. While bpf_in_interrupt() provides a general check, certain use cases in sched_ext require more granular differentiation -- specifically between hardirq and softirq contexts to handle different wake-up paths correctly. > If something can be implemented as a bpf program it should stay as > pure bpf code, since it's more flexible and faster this way. > llvm together with JITs completely inline get_preempt_count(). > I agree. Implementing these checks as pure BPF code is more efficient due to JIT inlining. I was initially hesitant to duplicate kernel-side macros in BPF, but since the precedent is already established in bpf_experimental.h, I will follow that pattern. I will drop the kfunc implementations in Patch 1 and instead add bpf_in_nmi(), bpf_in_hardirq(), bpf_in_serving_softirq(), and bpf_in_task() to bpf_experimental.h by wrapping get_preempt_count(). I will also update the selftests in Patch 2 to use these new headers and submit a v2 shortly. Regards, Changwoo Min ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH bpf-next v1 2/2] selftests/bpf: Add tests for execution context kfuncs 2026-01-23 8:42 [PATCH bpf-next v1 0/2] bpf: Introduce execution context detection kfuncs Changwoo Min 2026-01-23 8:42 ` [PATCH bpf-next v1 1/2] " Changwoo Min @ 2026-01-23 8:42 ` Changwoo Min 2026-01-23 9:08 ` bot+bpf-ci 1 sibling, 1 reply; 6+ messages in thread From: Changwoo Min @ 2026-01-23 8:42 UTC (permalink / raw) To: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko Cc: Martin KaFai Lau, Eduard Zingerman, Song Liu, Yonghong Song, John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa, Shuah Khan, kernel-dev, bpf, sched-ext, linux-kernel, linux-kselftest, Changwoo Min Add a new selftest suite `ctx_kfunc` to verify the accuracy of the bpf_in_task(), bpf_in_hardirq(), and bpf_in_serving_softirq() kfuncs. Testing these execution contexts deterministically requires crossing context boundaries within a single CPU. To achieve this, the test implements a "Trigger-Observer" pattern using bpf_testmod: 1. Trigger: A BPF syscall program calls a new bpf_testmod kfunc bpf_kfunc_trigger_ctx_check(). 2. Task to HardIRQ: The kfunc uses irq_work_queue() to trigger a self-IPI on the local CPU. 3. HardIRQ to SoftIRQ: The irq_work handler calls a dummy function (observed by BPF fentry) and then schedules a tasklet to transition into SoftIRQ context. The user-space runner ensures determinism by pinning itself to CPU 0 before execution, forcing the entire interrupt chain to remain on a single core. Dummy noinline functions with compiler barriers are added to bpf_testmod.c to serve as stable attachment points for fentry programs. A retry loop is used in user-space to wait for the asynchronous SoftIRQ to complete. Signed-off-by: Changwoo Min <changwoo@igalia.com> --- .../selftests/bpf/prog_tests/ctx_kfunc.c | 59 +++++++++++++++++++ tools/testing/selftests/bpf/progs/test_ctx.c | 51 ++++++++++++++++ .../selftests/bpf/test_kmods/bpf_testmod.c | 32 ++++++++++ .../bpf/test_kmods/bpf_testmod_kfunc.h | 4 ++ 4 files changed, 146 insertions(+) create mode 100644 tools/testing/selftests/bpf/prog_tests/ctx_kfunc.c create mode 100644 tools/testing/selftests/bpf/progs/test_ctx.c diff --git a/tools/testing/selftests/bpf/prog_tests/ctx_kfunc.c b/tools/testing/selftests/bpf/prog_tests/ctx_kfunc.c new file mode 100644 index 000000000000..64c3d61b92b3 --- /dev/null +++ b/tools/testing/selftests/bpf/prog_tests/ctx_kfunc.c @@ -0,0 +1,59 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2026 Valve Corporation. + * Author: Changwoo Min <changwoo@igalia.com> + */ + +#include <test_progs.h> +#include <sys/syscall.h> +#include "test_ctx.skel.h" + +void test_ctx_kfunc(void) +{ + LIBBPF_OPTS(bpf_test_run_opts, opts); + cpu_set_t old_cpuset, target_cpuset; + struct test_ctx *skel; + int err, prog_fd; + + /* 1. Pin the current process to CPU 0. */ + if (sched_getaffinity(0, sizeof(old_cpuset), &old_cpuset) == 0) { + CPU_ZERO(&target_cpuset); + CPU_SET(0, &target_cpuset); + ASSERT_OK(sched_setaffinity(0, sizeof(target_cpuset), + &target_cpuset), "setaffinity"); + } + + skel = test_ctx__open_and_load(); + if (!ASSERT_OK_PTR(skel, "skel_load")) + goto restore_affinity; + + err = test_ctx__attach(skel); + if (!ASSERT_OK(err, "skel_attach")) + goto cleanup; + + /* 2. When we run this, the kernel will execute the BPF prog on CPU 0. */ + prog_fd = bpf_program__fd(skel->progs.trigger_all_contexts); + err = bpf_prog_test_run_opts(prog_fd, &opts); + ASSERT_OK(err, "test_run_trigger"); + + /* 3. Wait for the local CPU's softirq/tasklet to finish. */ + for (int i = 0; i < 1000; i++) { + if (skel->bss->count_task > 0 && + skel->bss->count_hardirq > 0 && + skel->bss->count_softirq > 0) + break; + usleep(1000); /* Wait 1ms per iteration, up to 1 sec total */ + } + + /* On CPU 0, these should now all be non-zero. */ + ASSERT_GT(skel->bss->count_task, 0, "task_ok"); + ASSERT_GT(skel->bss->count_hardirq, 0, "hardirq_ok"); + ASSERT_GT(skel->bss->count_softirq, 0, "softirq_ok"); + +cleanup: + test_ctx__destroy(skel); + +restore_affinity: + ASSERT_OK(sched_setaffinity(0, sizeof(old_cpuset), &old_cpuset), + "restore_affinity"); +} diff --git a/tools/testing/selftests/bpf/progs/test_ctx.c b/tools/testing/selftests/bpf/progs/test_ctx.c new file mode 100644 index 000000000000..b962b3b263e4 --- /dev/null +++ b/tools/testing/selftests/bpf/progs/test_ctx.c @@ -0,0 +1,51 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2026 Valve Corporation. + * Author: Changwoo Min <changwoo@igalia.com> + */ + +#include "vmlinux.h" +#include <bpf/bpf_helpers.h> +#include <bpf/bpf_tracing.h> + +extern bool bpf_in_nmi(void) __ksym; +extern bool bpf_in_hardirq(void) __ksym; +extern bool bpf_in_serving_softirq(void) __ksym; +extern bool bpf_in_task(void) __ksym; +extern void bpf_kfunc_trigger_ctx_check(void) __ksym; + +int count_hardirq; +int count_softirq; +int count_task; + +/* Triggered via bpf_prog_test_run from user-space */ +SEC("syscall") +int trigger_all_contexts(void *ctx) +{ + if (bpf_in_task()) + __sync_fetch_and_add(&count_task, 1); + + /* Trigger the firing of a hardirq and softirq for test. */ + bpf_kfunc_trigger_ctx_check(); + return 0; +} + +/* Observer for HardIRQ */ +SEC("fentry/bpf_testmod_test_hardirq_fn") +int BPF_PROG(on_hardirq) +{ + if (bpf_in_hardirq()) + __sync_fetch_and_add(&count_hardirq, 1); + return 0; +} + +/* Observer for SoftIRQ */ +SEC("fentry/bpf_testmod_test_softirq_fn") +int BPF_PROG(on_softirq) +{ + if (bpf_in_serving_softirq()) + __sync_fetch_and_add(&count_softirq, 1); + return 0; +} + +char _license[] SEC("license") = "GPL"; diff --git a/tools/testing/selftests/bpf/test_kmods/bpf_testmod.c b/tools/testing/selftests/bpf/test_kmods/bpf_testmod.c index d425034b72d3..29eaf5596f8a 100644 --- a/tools/testing/selftests/bpf/test_kmods/bpf_testmod.c +++ b/tools/testing/selftests/bpf/test_kmods/bpf_testmod.c @@ -1164,6 +1164,33 @@ __bpf_kfunc int bpf_kfunc_implicit_arg(int a, struct bpf_prog_aux *aux); __bpf_kfunc int bpf_kfunc_implicit_arg_legacy(int a, int b, struct bpf_prog_aux *aux); __bpf_kfunc int bpf_kfunc_implicit_arg_legacy_impl(int a, int b, struct bpf_prog_aux *aux); +/* hook targets */ +noinline void bpf_testmod_test_hardirq_fn(void) { barrier(); } +noinline void bpf_testmod_test_softirq_fn(void) { barrier(); } + +/* Tasklet for SoftIRQ context */ +static void ctx_check_tasklet_fn(struct tasklet_struct *t) +{ + bpf_testmod_test_softirq_fn(); +} + +DECLARE_TASKLET(ctx_check_tasklet, ctx_check_tasklet_fn); + +/* IRQ Work for HardIRQ context */ +static void ctx_check_irq_fn(struct irq_work *work) +{ + bpf_testmod_test_hardirq_fn(); + tasklet_schedule(&ctx_check_tasklet); +} + +static struct irq_work ctx_check_irq = IRQ_WORK_INIT_HARD(ctx_check_irq_fn); + +/* The kfunc trigger */ +__bpf_kfunc void bpf_kfunc_trigger_ctx_check(void) +{ + irq_work_queue(&ctx_check_irq); +} + BTF_KFUNCS_START(bpf_testmod_check_kfunc_ids) BTF_ID_FLAGS(func, bpf_testmod_test_mod_kfunc) BTF_ID_FLAGS(func, bpf_kfunc_call_test1) @@ -1209,6 +1236,7 @@ BTF_ID_FLAGS(func, bpf_kfunc_multi_st_ops_test_1_assoc, KF_IMPLICIT_ARGS) BTF_ID_FLAGS(func, bpf_kfunc_implicit_arg, KF_IMPLICIT_ARGS) BTF_ID_FLAGS(func, bpf_kfunc_implicit_arg_legacy, KF_IMPLICIT_ARGS) BTF_ID_FLAGS(func, bpf_kfunc_implicit_arg_legacy_impl) +BTF_ID_FLAGS(func, bpf_kfunc_trigger_ctx_check) BTF_KFUNCS_END(bpf_testmod_check_kfunc_ids) static int bpf_testmod_ops_init(struct btf *btf) @@ -1840,6 +1868,10 @@ static void bpf_testmod_exit(void) while (refcount_read(&prog_test_struct.cnt) > 1) msleep(20); + /* Clean up tasklet and irqwork */ + tasklet_kill(&ctx_check_tasklet); + irq_work_sync(&ctx_check_irq); + bpf_kfunc_close_sock(); sysfs_remove_bin_file(kernel_kobj, &bin_attr_bpf_testmod_file); unregister_bpf_testmod_uprobe(); diff --git a/tools/testing/selftests/bpf/test_kmods/bpf_testmod_kfunc.h b/tools/testing/selftests/bpf/test_kmods/bpf_testmod_kfunc.h index 10f89f06245f..d5c5454e257e 100644 --- a/tools/testing/selftests/bpf/test_kmods/bpf_testmod_kfunc.h +++ b/tools/testing/selftests/bpf/test_kmods/bpf_testmod_kfunc.h @@ -169,4 +169,8 @@ extern int bpf_kfunc_multi_st_ops_test_1_assoc(struct st_ops_args *args) __weak struct prog_test_member *bpf_kfunc_get_default_trusted_ptr_test(void) __ksym; void bpf_kfunc_put_default_trusted_ptr_test(struct prog_test_member *trusted_ptr) __ksym; +void bpf_testmod_test_hardirq_fn(void); +void bpf_testmod_test_softirq_fn(void); +void bpf_kfunc_trigger_ctx_check(void) __ksym; + #endif /* _BPF_TESTMOD_KFUNC_H */ -- 2.52.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bpf-next v1 2/2] selftests/bpf: Add tests for execution context kfuncs 2026-01-23 8:42 ` [PATCH bpf-next v1 2/2] selftests/bpf: Add tests for execution context kfuncs Changwoo Min @ 2026-01-23 9:08 ` bot+bpf-ci 0 siblings, 0 replies; 6+ messages in thread From: bot+bpf-ci @ 2026-01-23 9:08 UTC (permalink / raw) To: changwoo, ast, daniel, andrii Cc: martin.lau, eddyz87, song, yonghong.song, john.fastabend, kpsingh, sdf, haoluo, jolsa, shuah, kernel-dev, bpf, sched-ext, linux-kernel, linux-kselftest, changwoo, ast, andrii, daniel, martin.lau, eddyz87, yonghong.song, clm, ihor.solodrai [-- Attachment #1: Type: text/plain, Size: 1601 bytes --] > diff --git a/tools/testing/selftests/bpf/test_kmods/bpf_testmod.c b/tools/testing/selftests/bpf/test_kmods/bpf_testmod.c > index 77a81fa8ec6a..8c7add48e447 100644 > --- a/tools/testing/selftests/bpf/test_kmods/bpf_testmod.c > +++ b/tools/testing/selftests/bpf/test_kmods/bpf_testmod.c [ ... ] > +/* IRQ Work for HardIRQ context */ > +static void ctx_check_irq_fn(struct irq_work *work) > +{ > + bpf_testmod_test_hardirq_fn(); > + tasklet_schedule(&ctx_check_tasklet); > +} [ ... ] > @@ -1844,6 +1872,10 @@ static void bpf_testmod_exit(void) > while (refcount_read(&prog_test_struct.cnt) > 1) > msleep(20); > > + /* Clean up tasklet and irqwork */ > + tasklet_kill(&ctx_check_tasklet); > + irq_work_sync(&ctx_check_irq); Should the cleanup order be reversed here? The irq_work handler ctx_check_irq_fn() calls tasklet_schedule(&ctx_check_tasklet). If the irq_work is still pending when tasklet_kill() is called, the subsequent irq_work_sync() may trigger the irq_work to run, which would then re-schedule the already-killed tasklet. This could lead to a use-after-free if the module unload completes while a newly scheduled tasklet is still pending, since ctx_check_tasklet_fn() would point to freed module code. Would swapping these to call irq_work_sync() first ensure the irq_work cannot schedule any more tasklets before tasklet_kill() runs? --- AI reviewed your patch. Please fix the bug or email reply why it's not a bug. See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md CI run summary: https://github.com/kernel-patches/bpf/actions/runs/21280227502 ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-01-24 11:29 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2026-01-23 8:42 [PATCH bpf-next v1 0/2] bpf: Introduce execution context detection kfuncs Changwoo Min 2026-01-23 8:42 ` [PATCH bpf-next v1 1/2] " Changwoo Min 2026-01-23 16:37 ` Alexei Starovoitov 2026-01-24 11:29 ` Changwoo Min 2026-01-23 8:42 ` [PATCH bpf-next v1 2/2] selftests/bpf: Add tests for execution context kfuncs Changwoo Min 2026-01-23 9:08 ` bot+bpf-ci
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®