From: Jonas Andreasson <jonas.andreasson@axis.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, kernel@axis.com
Subject: Re: [PATCH] regulator: TPS6287X: Use min/max uV to get VRANGE
Date: Fri, 17 Jan 2025 13:40:58 +0100 [thread overview]
Message-ID: <93530df2-f1c0-4eb0-9955-90856570deea@axis.com> (raw)
In-Reply-To: <d8d3d83f-42d5-47a0-8e96-0b3e70a736ee@sirena.org.uk>
On 1/16/25 16:58, Mark Brown wrote:
> On Wed, Jan 15, 2025 at 10:55:22AM +0100, Jonas Andreasson wrote:
>
>> + if (!data || data->range == -1)
>> + goto fallback;
>
> ...
>
>> + return selector;
>> +
>> +fallback:
>> + return regulator_map_voltage_pickable_linear_range(rdev, min_uV, max_uV);
>
> You could just have the return statement directly and avoid the goto
> which would make this easier to follow.
Hello.
Thanks for looking at my code!
That is a good point which I will fix.
Kind Regards,
Jonas
next prev parent reply other threads:[~2025-01-17 12:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 9:55 Jonas Andreasson
2025-01-16 15:58 ` Mark Brown
2025-01-17 12:40 ` Jonas Andreasson [this message]
2025-01-17 10:42 ` kernel test robot
2025-01-18 3:18 ` kernel test robot
2025-01-18 3:40 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93530df2-f1c0-4eb0-9955-90856570deea@axis.com \
--to=jonas.andreasson@axis.com \
--cc=broonie@kernel.org \
--cc=kernel@axis.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®