* [PATCH] task_work: add kerneldoc annotation for 'data' argument
@ 2023-09-11 20:24 Jens Axboe
2023-09-12 13:31 ` Oleg Nesterov
0 siblings, 1 reply; 2+ messages in thread
From: Jens Axboe @ 2023-09-11 20:24 UTC (permalink / raw)
To: LKML; +Cc: Andrew Morton, Oleg Nesterov
A previous commit changed the arguments to task_work_cancel_match(),
but didn't document all of them.
Fixes: c7aab1a7c52b ("task_work: add helper for more targeted task_work canceling")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202309120307.zis3yQGe-lkp@intel.com/
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
diff --git a/kernel/task_work.c b/kernel/task_work.c
index 065e1ef8fc8d..95a7e1b7f1da 100644
--- a/kernel/task_work.c
+++ b/kernel/task_work.c
@@ -78,6 +78,7 @@ int task_work_add(struct task_struct *task, struct callback_head *work,
* task_work_cancel_match - cancel a pending work added by task_work_add()
* @task: the task which should execute the work
* @match: match function to call
+ * @data: data to be passed in to match function
*
* RETURNS:
* The found work or NULL if not found.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] task_work: add kerneldoc annotation for 'data' argument
2023-09-11 20:24 [PATCH] task_work: add kerneldoc annotation for 'data' argument Jens Axboe
@ 2023-09-12 13:31 ` Oleg Nesterov
0 siblings, 0 replies; 2+ messages in thread
From: Oleg Nesterov @ 2023-09-12 13:31 UTC (permalink / raw)
To: Jens Axboe; +Cc: LKML, Andrew Morton
On 09/11, Jens Axboe wrote:
>
> --- a/kernel/task_work.c
> +++ b/kernel/task_work.c
> @@ -78,6 +78,7 @@ int task_work_add(struct task_struct *task, struct callback_head *work,
> * task_work_cancel_match - cancel a pending work added by task_work_add()
> * @task: the task which should execute the work
> * @match: match function to call
> + * @data: data to be passed in to match function
Acked-by: Oleg Nesterov <oleg@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-12 13:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-11 20:24 [PATCH] task_work: add kerneldoc annotation for 'data' argument Jens Axboe
2023-09-12 13:31 ` Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®