* [PATCH] ubifs: fix possible dereference after free
@ 2023-09-05 10:12 Konstantin Meskhidze
2023-09-06 1:42 ` Zhihao Cheng
0 siblings, 1 reply; 2+ messages in thread
From: Konstantin Meskhidze @ 2023-09-05 10:12 UTC (permalink / raw)
To: richard; +Cc: chengzhihao1, linux-mtd, linux-kernel, yusongping, artem.kuzin
'old_idx' could be dereferenced after free via 'rb_link_node' function
call.
Fixes: b5fda08ef213 ("ubifs: Fix memleak when insert_old_idx() failed")
Co-developed-by: Ivanov Mikhail <ivanov.mikhail1@huawei-partners.com>
Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
---
fs/ubifs/tnc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/ubifs/tnc.c b/fs/ubifs/tnc.c
index 6b7d95b65f4b..f4728e65d1bd 100644
--- a/fs/ubifs/tnc.c
+++ b/fs/ubifs/tnc.c
@@ -64,8 +64,9 @@ static void do_insert_old_idx(struct ubifs_info *c,
p = &(*p)->rb_right;
else {
ubifs_err(c, "old idx added twice!");
kfree(old_idx);
+ return;
}
}
rb_link_node(&old_idx->rb, parent, p);
rb_insert_color(&old_idx->rb, &c->old_idx);
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ubifs: fix possible dereference after free
2023-09-05 10:12 [PATCH] ubifs: fix possible dereference after free Konstantin Meskhidze
@ 2023-09-06 1:42 ` Zhihao Cheng
0 siblings, 0 replies; 2+ messages in thread
From: Zhihao Cheng @ 2023-09-06 1:42 UTC (permalink / raw)
To: Konstantin Meskhidze, richard
Cc: linux-mtd, linux-kernel, yusongping, artem.kuzin
在 2023/9/5 18:12, Konstantin Meskhidze 写道:
> 'old_idx' could be dereferenced after free via 'rb_link_node' function
> call.
>
> Fixes: b5fda08ef213 ("ubifs: Fix memleak when insert_old_idx() failed")
> Co-developed-by: Ivanov Mikhail <ivanov.mikhail1@huawei-partners.com>
> Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
> ---
> fs/ubifs/tnc.c | 1 +
> 1 file changed, 1 insertion(+)
>
Only for static alarms，although it couldn't happen in theory.
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
> diff --git a/fs/ubifs/tnc.c b/fs/ubifs/tnc.c
> index 6b7d95b65f4b..f4728e65d1bd 100644
> --- a/fs/ubifs/tnc.c
> +++ b/fs/ubifs/tnc.c
> @@ -64,8 +64,9 @@ static void do_insert_old_idx(struct ubifs_info *c,
> p = &(*p)->rb_right;
> else {
> ubifs_err(c, "old idx added twice!");
> kfree(old_idx);
> + return;
> }
> }
> rb_link_node(&old_idx->rb, parent, p);
> rb_insert_color(&old_idx->rb, &c->old_idx);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-06 1:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-05 10:12 [PATCH] ubifs: fix possible dereference after free Konstantin Meskhidze
2023-09-06 1:42 ` Zhihao Cheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®