From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Vikram Sharma <quic_vikramsa@quicinc.com>,
rfoss@kernel.org, todor.too@gmail.com, mchehab@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
akapatra@quicinc.com, hariramp@quicinc.com, andersson@kernel.org,
konradybcio@kernel.org, hverkuil-cisco@xs4all.nl,
cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com,
will@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@quicinc.com
Subject: Re: [PATCH v2 2/2] media: qcom: camss: update clock names for sc7280
Date: Wed, 22 Jan 2025 13:30:38 +0000 [thread overview]
Message-ID: <93be5858-6c1e-4a09-bfe3-ac89d458a892@linaro.org> (raw)
In-Reply-To: <20250121180746.1989996-3-quic_vikramsa@quicinc.com>
On 21/01/2025 18:07, Vikram Sharma wrote:
> Update clock names to make them consistent with existing platform i.e
> sc8280xp. Rename gcc_cam_hf_axi to gcc_axi_hf and add gcc_axi_sf.
>
> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
> ---
> drivers/media/platform/qcom/camss/camss.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index a85e9df0f301..b1358457c66e 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -1443,12 +1443,13 @@ static const struct camss_subdev_resources vfe_res_7280[] = {
> .regulators = {},
>
> .clock = { "camnoc_axi", "cpas_ahb", "icp_ahb", "vfe0",
> - "vfe0_axi", "gcc_cam_hf_axi" },
> + "vfe0_axi", "gcc_axi_hf", "gcc_axi_sf" },
> .clock_rate = { { 150000000, 240000000, 320000000, 400000000, 480000000 },
> { 80000000 },
> { 0 },
> { 380000000, 510000000, 637000000, 760000000 },
> { 0 },
> + { 0 },
> { 0 } },
>
> .reg = { "vfe0" },
> @@ -1468,12 +1469,13 @@ static const struct camss_subdev_resources vfe_res_7280[] = {
> .regulators = {},
>
> .clock = { "camnoc_axi", "cpas_ahb", "icp_ahb", "vfe1",
> - "vfe1_axi", "gcc_cam_hf_axi" },
> + "vfe1_axi", "gcc_axi_hf", "gcc_axi_sf" },
> .clock_rate = { { 150000000, 240000000, 320000000, 400000000, 480000000 },
> { 80000000 },
> { 0 },
> { 380000000, 510000000, 637000000, 760000000 },
> { 0 },
> + { 0 },
> { 0 } },
>
> .reg = { "vfe1" },
> @@ -1493,12 +1495,13 @@ static const struct camss_subdev_resources vfe_res_7280[] = {
> .regulators = {},
>
> .clock = { "camnoc_axi", "cpas_ahb", "icp_ahb", "vfe2",
> - "vfe2_axi", "gcc_cam_hf_axi" },
> + "vfe2_axi", "gcc_axi_hf", "gcc_axi_sf" },
> .clock_rate = { { 150000000, 240000000, 320000000, 400000000, 480000000 },
> { 80000000 },
> { 0 },
> { 380000000, 510000000, 637000000, 760000000 },
> { 0 },
> + { 0 },
> { 0 } },
>
> .reg = { "vfe2" },
> @@ -1516,11 +1519,12 @@ static const struct camss_subdev_resources vfe_res_7280[] = {
> /* VFE3 (lite) */
> {
> .clock = { "camnoc_axi", "cpas_ahb", "icp_ahb",
> - "vfe_lite0", "gcc_cam_hf_axi" },
> + "vfe_lite0", "gcc_axi_hf", "gcc_axi_sf" },
> .clock_rate = { { 150000000, 240000000, 320000000, 400000000, 480000000 },
> { 80000000 },
> { 0 },
> { 320000000, 400000000, 480000000, 600000000 },
> + { 0 },
> { 0 } },
>
> .regulators = {},
> @@ -1537,11 +1541,12 @@ static const struct camss_subdev_resources vfe_res_7280[] = {
> /* VFE4 (lite) */
> {
> .clock = { "camnoc_axi", "cpas_ahb", "icp_ahb",
> - "vfe_lite1", "gcc_cam_hf_axi" },
> + "vfe_lite1", "gcc_axi_hf", "gcc_axi_sf" },
> .clock_rate = { { 150000000, 240000000, 320000000, 400000000, 480000000 },
> { 80000000 },
> { 0 },
> { 320000000, 400000000, 480000000, 600000000 },
> + { 0 },
> { 0 } },
>
> .regulators = {},
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
prev parent reply other threads:[~2025-01-22 13:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 18:07 [PATCH v2 0/2] Update clocks for sc7280-camss Vikram Sharma
2025-01-21 18:07 ` [PATCH v2 1/2] media: dt-bindings: update " Vikram Sharma
2025-01-22 13:30 ` Bryan O'Donoghue
2025-01-24 8:10 ` Krzysztof Kozlowski
2025-01-21 18:07 ` [PATCH v2 2/2] media: qcom: camss: update clock names for sc7280 Vikram Sharma
2025-01-22 13:30 ` Bryan O'Donoghue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93be5858-6c1e-4a09-bfe3-ac89d458a892@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=akapatra@quicinc.com \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=hariramp@quicinc.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@quicinc.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_vikramsa@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®