mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Vikram Sharma <quic_vikramsa@quicinc.com>,
	rfoss@kernel.org, todor.too@gmail.com, mchehab@kernel.org,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	akapatra@quicinc.com, hariramp@quicinc.com, andersson@kernel.org,
	konradybcio@kernel.org, hverkuil-cisco@xs4all.nl,
	cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com,
	will@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@quicinc.com
Subject: Re: [PATCH v2 1/2] media: dt-bindings: update clocks for sc7280-camss
Date: Wed, 22 Jan 2025 13:30:26 +0000	[thread overview]
Message-ID: <f0079c85-0ff9-4663-9ba3-b208b3487db5@linaro.org> (raw)
In-Reply-To: <20250121180746.1989996-2-quic_vikramsa@quicinc.com>

On 21/01/2025 18:07, Vikram Sharma wrote:
> Update clock names to make them consistent with existing platform i.e
> qcom,sc8280xp-camss.yaml. Rename gcc_cam_hf_axi to gcc_axi_hf and add
> gcc_axi_sf.
> 
> gcc_camera_ahb is always on and we don't need to enable it explicitly.
> gcc_axi_sf is added to avoid unexpected hardware behaviour.
> 
> This change will not break ABI because the ABI hasn't been cemented yet as
> the dtsi changes are not merged yet and there are no users for this driver
> as of now.
> 
> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
> ---
>   .../devicetree/bindings/media/qcom,sc7280-camss.yaml   | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> index e11141b812a0..ee35e3bc97ff 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> @@ -55,8 +55,8 @@ properties:
>         - const: csiphy3_timer
>         - const: csiphy4
>         - const: csiphy4_timer
> -      - const: gcc_camera_ahb
> -      - const: gcc_cam_hf_axi
> +      - const: gcc_axi_hf
> +      - const: gcc_axi_sf
>         - const: icp_ahb
>         - const: vfe0
>         - const: vfe0_axi
> @@ -310,8 +310,8 @@ examples:
>                        <&camcc CAM_CC_CSI3PHYTIMER_CLK>,
>                        <&camcc CAM_CC_CSIPHY4_CLK>,
>                        <&camcc CAM_CC_CSI4PHYTIMER_CLK>,
> -                     <&gcc GCC_CAMERA_AHB_CLK>,
>                        <&gcc GCC_CAMERA_HF_AXI_CLK>,
> +                     <&gcc GCC_CAMERA_SF_AXI_CLK>,
>                        <&camcc CAM_CC_ICP_AHB_CLK>,
>                        <&camcc CAM_CC_IFE_0_CLK>,
>                        <&camcc CAM_CC_IFE_0_AXI_CLK>,
> @@ -343,8 +343,8 @@ examples:
>                             "csiphy3_timer",
>                             "csiphy4",
>                             "csiphy4_timer",
> -                          "gcc_camera_ahb",
> -                          "gcc_cam_hf_axi",
> +                          "gcc_axi_hf",
> +                          "gcc_axi_sf",
>                             "icp_ahb",
>                             "vfe0",
>                             "vfe0_axi",
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

  reply	other threads:[~2025-01-22 13:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21 18:07 [PATCH v2 0/2] Update " Vikram Sharma
2025-01-21 18:07 ` [PATCH v2 1/2] media: dt-bindings: update " Vikram Sharma
2025-01-22 13:30   ` Bryan O'Donoghue [this message]
2025-01-24  8:10   ` Krzysztof Kozlowski
2025-01-21 18:07 ` [PATCH v2 2/2] media: qcom: camss: update clock names for sc7280 Vikram Sharma
2025-01-22 13:30   ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0079c85-0ff9-4663-9ba3-b208b3487db5@linaro.org \
    --to=bryan.odonoghue@linaro.org \
    --cc=akapatra@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hariramp@quicinc.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=kernel@quicinc.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=quic_vikramsa@quicinc.com \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=todor.too@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®