* [PATCH] udmabuf: add CONFIG_MMU dependency
@ 2024-05-28 13:31 Arnd Bergmann
2024-05-28 13:58 ` David Hildenbrand
2024-05-28 16:52 ` Kasireddy, Vivek
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2024-05-28 13:31 UTC (permalink / raw)
To: Sumit Semwal, Christian König, Dave Airlie, Vivek Kasireddy,
David Hildenbrand, Gerd Hoffmann, Andrew Morton
Cc: Arnd Bergmann, linux-media, dri-devel, linaro-mm-sig, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
There is no !CONFIG_MMU version of vmf_insert_pfn():
arm-linux-gnueabi-ld: drivers/dma-buf/udmabuf.o: in function `udmabuf_vm_fault':
udmabuf.c:(.text+0xaa): undefined reference to `vmf_insert_pfn'
Fixes: f7254e043ff1 ("udmabuf: use vmf_insert_pfn and VM_PFNMAP for handling mmap")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/dma-buf/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma-buf/Kconfig b/drivers/dma-buf/Kconfig
index e4dc53a36428..b46eb8a552d7 100644
--- a/drivers/dma-buf/Kconfig
+++ b/drivers/dma-buf/Kconfig
@@ -35,6 +35,7 @@ config UDMABUF
default n
depends on DMA_SHARED_BUFFER
depends on MEMFD_CREATE || COMPILE_TEST
+ depends on MMU
help
A driver to let userspace turn memfd regions into dma-bufs.
Qemu can use this to create host dmabufs for guest framebuffers.
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] udmabuf: add CONFIG_MMU dependency
2024-05-28 13:31 [PATCH] udmabuf: add CONFIG_MMU dependency Arnd Bergmann
@ 2024-05-28 13:58 ` David Hildenbrand
2024-05-28 16:52 ` Kasireddy, Vivek
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2024-05-28 13:58 UTC (permalink / raw)
To: Arnd Bergmann, Sumit Semwal, Christian König, Dave Airlie,
Vivek Kasireddy, Gerd Hoffmann, Andrew Morton
Cc: Arnd Bergmann, linux-media, dri-devel, linaro-mm-sig, linux-kernel
Am 28.05.24 um 15:31 schrieb Arnd Bergmann:
> From: Arnd Bergmann <arnd@arndb.de>
>
> There is no !CONFIG_MMU version of vmf_insert_pfn():
>
> arm-linux-gnueabi-ld: drivers/dma-buf/udmabuf.o: in function `udmabuf_vm_fault':
> udmabuf.c:(.text+0xaa): undefined reference to `vmf_insert_pfn'
>
> Fixes: f7254e043ff1 ("udmabuf: use vmf_insert_pfn and VM_PFNMAP for handling mmap")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/dma-buf/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma-buf/Kconfig b/drivers/dma-buf/Kconfig
> index e4dc53a36428..b46eb8a552d7 100644
> --- a/drivers/dma-buf/Kconfig
> +++ b/drivers/dma-buf/Kconfig
> @@ -35,6 +35,7 @@ config UDMABUF
> default n
> depends on DMA_SHARED_BUFFER
> depends on MEMFD_CREATE || COMPILE_TEST
> + depends on MMU
> help
> A driver to let userspace turn memfd regions into dma-bufs.
> Qemu can use this to create host dmabufs for guest framebuffers.
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] udmabuf: add CONFIG_MMU dependency
2024-05-28 13:31 [PATCH] udmabuf: add CONFIG_MMU dependency Arnd Bergmann
2024-05-28 13:58 ` David Hildenbrand
@ 2024-05-28 16:52 ` Kasireddy, Vivek
1 sibling, 0 replies; 3+ messages in thread
From: Kasireddy, Vivek @ 2024-05-28 16:52 UTC (permalink / raw)
To: Arnd Bergmann, Sumit Semwal, Christian König, Dave Airlie,
David Hildenbrand, Gerd Hoffmann, Andrew Morton
Cc: Arnd Bergmann, linux-media, dri-devel, linaro-mm-sig, linux-kernel
> From: Arnd Bergmann <arnd@arndb.de>
>
> There is no !CONFIG_MMU version of vmf_insert_pfn():
>
> arm-linux-gnueabi-ld: drivers/dma-buf/udmabuf.o: in function
> `udmabuf_vm_fault':
> udmabuf.c:(.text+0xaa): undefined reference to `vmf_insert_pfn'
>
> Fixes: f7254e043ff1 ("udmabuf: use vmf_insert_pfn and VM_PFNMAP for
> handling mmap")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/dma-buf/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma-buf/Kconfig b/drivers/dma-buf/Kconfig
> index e4dc53a36428..b46eb8a552d7 100644
> --- a/drivers/dma-buf/Kconfig
> +++ b/drivers/dma-buf/Kconfig
> @@ -35,6 +35,7 @@ config UDMABUF
> default n
> depends on DMA_SHARED_BUFFER
> depends on MEMFD_CREATE || COMPILE_TEST
> + depends on MMU
Thank you for the fix!
Acked-by: Vivek Kasireddy <vivek.kasireddy@intel.com>
> help
> A driver to let userspace turn memfd regions into dma-bufs.
> Qemu can use this to create host dmabufs for guest framebuffers.
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-28 16:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-28 13:31 [PATCH] udmabuf: add CONFIG_MMU dependency Arnd Bergmann
2024-05-28 13:58 ` David Hildenbrand
2024-05-28 16:52 ` Kasireddy, Vivek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®