From: Tomi Valkeinen <tomba@kernel.org>
To: ChunyouTang <tangchunyou@163.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
tangchunyou@yulong.com, airlied@linux.ie, daniel@ffwll.ch,
sebastian.reichel@collabora.com,
laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH] omapdrm/dss/dsi.c:modify 'u32'->'int'
Date: Wed, 17 Mar 2021 13:54:39 +0200 [thread overview]
Message-ID: <93f05e6c-21ad-5b4b-3406-14229ea4feef@kernel.org> (raw)
In-Reply-To: <20210317094852.424-1-tangchunyou@163.com>
Hi,
On 17/03/2021 11:48, ChunyouTang wrote:
> From: tangchunyou <tangchunyou@yulong.com>
>
> 1.the type of mipi_dsi_create_packet id int
> 2.u32 can not < 0
>
> Signed-off-by: tangchunyou <tangchunyou@yulong.com>
> ---
> drivers/gpu/drm/omapdrm/dss/dsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
> index 8e11612..11c502d 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
> @@ -2149,7 +2149,7 @@ static int dsi_vc_send_short(struct dsi_data *dsi, int vc,
> const struct mipi_dsi_msg *msg)
> {
> struct mipi_dsi_packet pkt;
> - u32 r;
> + int r;
>
> r = mipi_dsi_create_packet(&pkt, msg);
> if (r < 0)
>
I have already applies a similar patch "drm/omap: dsi: fix unsigned
expression compared with zero".
Tomi
prev parent reply other threads:[~2021-03-17 11:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 9:48 ChunyouTang
2021-03-17 11:54 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93f05e6c-21ad-5b4b-3406-14229ea4feef@kernel.org \
--to=tomba@kernel.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=tangchunyou@163.com \
--cc=tangchunyou@yulong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®