From: Danilo Krummrich <dakr@kernel.org>
To: Alice Ryhl <aliceryhl@google.com>
Cc: "Vitaly Wool" <vitaly.wool@konsulko.se>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Bjorn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Onur Özkan" <work@onurozkan.dev>
Subject: Re: [PATCH v2] rust: rbtree: add immutable cursor
Date: Mon, 8 Sep 2025 11:06:02 +0200 [thread overview]
Message-ID: <94252007-f389-41d0-b5a0-ed948225543a@kernel.org> (raw)
In-Reply-To: <aL6YHkF96ICqqbBZ@google.com>
On 9/8/25 10:47 AM, Alice Ryhl wrote:
> On Sat, Sep 06, 2025 at 04:02:56PM +0200, Vitaly Wool wrote:
>> + // SAFETY: `best` is a non-null node so it is valid by the type invariants.
>> + let links = unsafe { addr_of_mut!((*best.as_ptr()).links) };
>
> Since this is rawptr to rawptr, I don't think it matters but it seems
> more natural to use addr_of! here.
Why not use &raw? Consistency with the rest of the file?
next prev parent reply other threads:[~2025-09-08 9:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-06 14:02 Vitaly Wool
2025-09-08 8:47 ` Alice Ryhl
2025-09-08 9:06 ` Danilo Krummrich [this message]
2025-09-08 9:21 ` Miguel Ojeda
2025-09-08 10:22 ` Alice Ryhl
2025-09-08 11:13 ` Miguel Ojeda
2025-09-08 11:15 ` Miguel Ojeda
2025-09-10 1:09 ` John Hubbard
2025-09-10 2:50 ` Miguel Ojeda
2025-09-10 19:40 ` John Hubbard
2025-09-10 19:42 ` Danilo Krummrich
2025-09-11 2:33 ` Alexandre Courbot
2025-09-12 23:31 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94252007-f389-41d0-b5a0-ed948225543a@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=vitaly.wool@konsulko.se \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®