mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/4] dt-bindings: bluetooth: qcom,qcc2072-bt: add bindings for QCC2072
@ 2026-05-29 17:53 Yepuri Siddu
  2026-05-30 12:34 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 6+ messages in thread
From: Yepuri Siddu @ 2026-05-29 17:53 UTC (permalink / raw)
  To: Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
	Konrad Dybcio, Balakrishna Godavarthi, Rocky Liao
  Cc: quic_mohamull, quic_hbandi, rahul.samana, harshitha.reddy,
	dishank.garg, linux-arm-msm, linux-bluetooth, devicetree,
	linux-kernel, Yepuri Siddu

Document the YAML binding schema for the Qualcomm QCC2072 UART-based
Bluetooth controller.

Unlike other Qualcomm Bluetooth chips, QCC2072 requires no external
voltage regulators. The schema inherits common Qualcomm Bluetooth
properties via qcom,bluetooth-common.yaml and serial peripheral
interface properties for the UART link.

Signed-off-by: Yepuri Siddu <yepuri.siddu@oss.qualcomm.com>
---
 .../net/bluetooth/qcom,qcc2072-bt.yaml        | 38 +++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml

diff --git a/Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml
new file mode 100644
index 000000000000..8e2f15a75d62
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/bluetooth/qcom,qcc2072-bt.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm QCC2072 Bluetooth
+
+maintainers:
+  - Balakrishna Godavarthi <quic_bgodavar@quicinc.com>
+  - Rocky Liao <quic_rjliao@quicinc.com>
+
+description:
+  Qualcomm QCC2072 is a UART-based Bluetooth controller.
+
+properties:
+  compatible:
+    enum:
+      - qcom,qcc2072-bt
+
+required:
+  - compatible
+
+allOf:
+  - $ref: bluetooth-controller.yaml#
+  - $ref: qcom,bluetooth-common.yaml#
+  - $ref: /schemas/serial/serial-peripheral-props.yaml#
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    serial {
+        bluetooth {
+            compatible = "qcom,qcc2072-bt";
+            max-speed = <3200000>;
+        };
+    };
-- 
2.34.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/4] dt-bindings: bluetooth: qcom,qcc2072-bt: add bindings for QCC2072
  2026-05-29 17:53 [PATCH 1/4] dt-bindings: bluetooth: qcom,qcc2072-bt: add bindings for QCC2072 Yepuri Siddu
@ 2026-05-30 12:34 ` Krzysztof Kozlowski
  2026-06-01  7:20   ` Yepuri Siddu
  0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-30 12:34 UTC (permalink / raw)
  To: Yepuri Siddu
  Cc: Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
	Konrad Dybcio, Balakrishna Godavarthi, Rocky Liao, quic_mohamull,
	quic_hbandi, rahul.samana, harshitha.reddy, dishank.garg,
	linux-arm-msm, linux-bluetooth, devicetree, linux-kernel

On Fri, May 29, 2026 at 11:23:42PM +0530, Yepuri Siddu wrote:
> Document the YAML binding schema for the Qualcomm QCC2072 UART-based
> Bluetooth controller.

Where is the rest?

Also:
A nit, subject: drop second/last, redundant "bindings for". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

> 
> Unlike other Qualcomm Bluetooth chips, QCC2072 requires no external
> voltage regulators. The schema inherits common Qualcomm Bluetooth
> properties via qcom,bluetooth-common.yaml and serial peripheral
> interface properties for the UART link.
> 
> Signed-off-by: Yepuri Siddu <yepuri.siddu@oss.qualcomm.com>
> ---
>  .../net/bluetooth/qcom,qcc2072-bt.yaml        | 38 +++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml
> new file mode 100644
> index 000000000000..8e2f15a75d62
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/bluetooth/qcom,qcc2072-bt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm QCC2072 Bluetooth
> +
> +maintainers:
> +  - Balakrishna Godavarthi <quic_bgodavar@quicinc.com>
> +  - Rocky Liao <quic_rjliao@quicinc.com>
> +
> +description:
> +  Qualcomm QCC2072 is a UART-based Bluetooth controller.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - qcom,qcc2072-bt
> +
> +required:
> +  - compatible
> +

Looks heavily incomplete. Devices do not work without power for example.

> +allOf:
> +  - $ref: bluetooth-controller.yaml#
> +  - $ref: qcom,bluetooth-common.yaml#
> +  - $ref: /schemas/serial/serial-peripheral-props.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    serial {
> +        bluetooth {
> +            compatible = "qcom,qcc2072-bt";
> +            max-speed = <3200000>;

Also incomplete.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/4] dt-bindings: bluetooth: qcom,qcc2072-bt: add bindings for QCC2072
  2026-05-30 12:34 ` Krzysztof Kozlowski
@ 2026-06-01  7:20   ` Yepuri Siddu
  2026-06-01  7:52     ` Dmitry Baryshkov
  0 siblings, 1 reply; 6+ messages in thread
From: Yepuri Siddu @ 2026-06-01  7:20 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
	Konrad Dybcio, Balakrishna Godavarthi, Rocky Liao, quic_mohamull,
	quic_hbandi, rahul.samana, harshitha.reddy, dishank.garg,
	linux-arm-msm, linux-bluetooth, devicetree, linux-kernel



On 5/30/2026 6:04 PM, Krzysztof Kozlowski wrote:
> On Fri, May 29, 2026 at 11:23:42PM +0530, Yepuri Siddu wrote:
>> Document the YAML binding schema for the Qualcomm QCC2072 UART-based
>> Bluetooth controller.
> 
> Where is the rest?
> 
> Also:
> A nit, subject: drop second/last, redundant "bindings for". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> 
Thanks,  I will update this accordingly and send a v2 with the fixes.
>>
>> Unlike other Qualcomm Bluetooth chips, QCC2072 requires no external
>> voltage regulators. The schema inherits common Qualcomm Bluetooth
>> properties via qcom,bluetooth-common.yaml and serial peripheral
>> interface properties for the UART link.
>>
>> Signed-off-by: Yepuri Siddu <yepuri.siddu@oss.qualcomm.com>
>> ---
>>   .../net/bluetooth/qcom,qcc2072-bt.yaml        | 38 +++++++++++++++++++
>>   1 file changed, 38 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml
>> new file mode 100644
>> index 000000000000..8e2f15a75d62
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml
>> @@ -0,0 +1,38 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/net/bluetooth/qcom,qcc2072-bt.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm QCC2072 Bluetooth
>> +
>> +maintainers:
>> +  - Balakrishna Godavarthi <quic_bgodavar@quicinc.com>
>> +  - Rocky Liao <quic_rjliao@quicinc.com>
>> +
>> +description:
>> +  Qualcomm QCC2072 is a UART-based Bluetooth controller.
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - qcom,qcc2072-bt
>> +
>> +required:
>> +  - compatible
>> +
> 
> Looks heavily incomplete. Devices do not work without power for example.

The module receives power through the M.2 edge connector and manages its
own power sequencing internally. Unlike bare Qualcomm Bluetooth SoCs, it
requires no external voltage regulators, enable GPIOs, or clock supply
from the host, so no power-related properties are needed in the binding.
> 
>> +allOf:
>> +  - $ref: bluetooth-controller.yaml#
>> +  - $ref: qcom,bluetooth-common.yaml#
>> +  - $ref: /schemas/serial/serial-peripheral-props.yaml#
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +    serial {
>> +        bluetooth {
>> +            compatible = "qcom,qcc2072-bt";
>> +            max-speed = <3200000>;
> 
> Also incomplete.
> 
> Best regards,
> Krzysztof
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/4] dt-bindings: bluetooth: qcom,qcc2072-bt: add bindings for QCC2072
  2026-06-01  7:20   ` Yepuri Siddu
@ 2026-06-01  7:52     ` Dmitry Baryshkov
  2026-06-01  8:19       ` Krzysztof Kozlowski
  0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Baryshkov @ 2026-06-01  7:52 UTC (permalink / raw)
  To: Yepuri Siddu
  Cc: Krzysztof Kozlowski, Bartosz Golaszewski, Marcel Holtmann,
	Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bjorn Andersson, Konrad Dybcio,
	Balakrishna Godavarthi, Rocky Liao, quic_mohamull, quic_hbandi,
	rahul.samana, harshitha.reddy, dishank.garg, linux-arm-msm,
	linux-bluetooth, devicetree, linux-kernel

On Mon, Jun 01, 2026 at 12:50:00PM +0530, Yepuri Siddu wrote:
> 
> 
> On 5/30/2026 6:04 PM, Krzysztof Kozlowski wrote:
> > On Fri, May 29, 2026 at 11:23:42PM +0530, Yepuri Siddu wrote:
> > > Document the YAML binding schema for the Qualcomm QCC2072 UART-based
> > > Bluetooth controller.
> > 
> > Where is the rest?
> > 
> > Also:
> > A nit, subject: drop second/last, redundant "bindings for". The
> > "dt-bindings" prefix is already stating that these are bindings.
> > See also:
> > https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> > 
> Thanks,  I will update this accordingly and send a v2 with the fixes.
> > > 
> > > Unlike other Qualcomm Bluetooth chips, QCC2072 requires no external
> > > voltage regulators. The schema inherits common Qualcomm Bluetooth
> > > properties via qcom,bluetooth-common.yaml and serial peripheral
> > > interface properties for the UART link.
> > > 
> > > Signed-off-by: Yepuri Siddu <yepuri.siddu@oss.qualcomm.com>
> > > ---
> > >   .../net/bluetooth/qcom,qcc2072-bt.yaml        | 38 +++++++++++++++++++
> > >   1 file changed, 38 insertions(+)
> > >   create mode 100644 Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml
> > > 
> > > diff --git a/Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml
> > > new file mode 100644
> > > index 000000000000..8e2f15a75d62
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml
> > > @@ -0,0 +1,38 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/net/bluetooth/qcom,qcc2072-bt.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Qualcomm QCC2072 Bluetooth
> > > +
> > > +maintainers:
> > > +  - Balakrishna Godavarthi <quic_bgodavar@quicinc.com>
> > > +  - Rocky Liao <quic_rjliao@quicinc.com>
> > > +
> > > +description:
> > > +  Qualcomm QCC2072 is a UART-based Bluetooth controller.
> > > +
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - qcom,qcc2072-bt
> > > +
> > > +required:
> > > +  - compatible
> > > +
> > 
> > Looks heavily incomplete. Devices do not work without power for example.
> 
> The module receives power through the M.2 edge connector and manages its
> own power sequencing internally. Unlike bare Qualcomm Bluetooth SoCs, it
> requires no external voltage regulators, enable GPIOs, or clock supply
> from the host, so no power-related properties are needed in the binding.

If this is a purely M.2 device, then it should not be a part of DT.

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/4] dt-bindings: bluetooth: qcom,qcc2072-bt: add bindings for QCC2072
  2026-06-01  7:52     ` Dmitry Baryshkov
@ 2026-06-01  8:19       ` Krzysztof Kozlowski
  2026-07-02 10:09         ` Yepuri Siddu
  0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-01  8:19 UTC (permalink / raw)
  To: Dmitry Baryshkov, Yepuri Siddu
  Cc: Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
	Konrad Dybcio, Balakrishna Godavarthi, Rocky Liao, quic_mohamull,
	quic_hbandi, rahul.samana, harshitha.reddy, dishank.garg,
	linux-arm-msm, linux-bluetooth, devicetree, linux-kernel

On 01/06/2026 09:52, Dmitry Baryshkov wrote:
> On Mon, Jun 01, 2026 at 12:50:00PM +0530, Yepuri Siddu wrote:
>>
>>
>> On 5/30/2026 6:04 PM, Krzysztof Kozlowski wrote:
>>> On Fri, May 29, 2026 at 11:23:42PM +0530, Yepuri Siddu wrote:
>>>> Document the YAML binding schema for the Qualcomm QCC2072 UART-based
>>>> Bluetooth controller.
>>>
>>> Where is the rest?
>>>

I repeat the question.


>>>> +properties:
>>>> +  compatible:
>>>> +    enum:
>>>> +      - qcom,qcc2072-bt
>>>> +
>>>> +required:
>>>> +  - compatible
>>>> +
>>>
>>> Looks heavily incomplete. Devices do not work without power for example.
>>
>> The module receives power through the M.2 edge connector and manages its
>> own power sequencing internally. Unlike bare Qualcomm Bluetooth SoCs, it
>> requires no external voltage regulators, enable GPIOs, or clock supply
>> from the host, so no power-related properties are needed in the binding.
> 
> If this is a purely M.2 device, then it should not be a part of DT.
> 

Exactly. And even PCI devices need power sequencing, unless this is a
simple (BT only) device.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/4] dt-bindings: bluetooth: qcom,qcc2072-bt: add bindings for QCC2072
  2026-06-01  8:19       ` Krzysztof Kozlowski
@ 2026-07-02 10:09         ` Yepuri Siddu
  0 siblings, 0 replies; 6+ messages in thread
From: Yepuri Siddu @ 2026-07-02 10:09 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Dmitry Baryshkov
  Cc: Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
	Konrad Dybcio, Balakrishna Godavarthi, Rocky Liao, quic_mohamull,
	quic_hbandi, rahul.samana, harshitha.reddy, dishank.garg,
	linux-arm-msm, linux-bluetooth, devicetree, linux-kernel



On 6/1/2026 1:49 PM, Krzysztof Kozlowski wrote:
> On 01/06/2026 09:52, Dmitry Baryshkov wrote:
>> On Mon, Jun 01, 2026 at 12:50:00PM +0530, Yepuri Siddu wrote:
>>>
>>>
>>> On 5/30/2026 6:04 PM, Krzysztof Kozlowski wrote:
>>>> On Fri, May 29, 2026 at 11:23:42PM +0530, Yepuri Siddu wrote:
>>>>> Document the YAML binding schema for the Qualcomm QCC2072 UART-based
>>>>> Bluetooth controller.
>>>>
>>>> Where is the rest?
>>>>
> 
> I repeat the question.
> 
> 
>>>>> +properties:
>>>>> +  compatible:
>>>>> +    enum:
>>>>> +      - qcom,qcc2072-bt
>>>>> +
>>>>> +required:
>>>>> +  - compatible
>>>>> +
>>>>
>>>> Looks heavily incomplete. Devices do not work without power for example.
>>>
>>> The module receives power through the M.2 edge connector and manages its
>>> own power sequencing internally. Unlike bare Qualcomm Bluetooth SoCs, it
>>> requires no external voltage regulators, enable GPIOs, or clock supply
>>> from the host, so no power-related properties are needed in the binding.
>>
>> If this is a purely M.2 device, then it should not be a part of DT.
>>
> 
> Exactly. And even PCI devices need power sequencing, unless this is a
> simple (BT only) device.
> 

QCC2072 is an M.2 E-key chip. As M.2 Power Sequencing changes are being 
upstreamed, we will reupdate our existing patches to align with M.2 
power sequencing approach.
This includes aligning the bindings, DT and also BT driver changes.

Thanks,
Siddu

> Best regards,
> Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-07-02 10:10 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-29 17:53 [PATCH 1/4] dt-bindings: bluetooth: qcom,qcc2072-bt: add bindings for QCC2072 Yepuri Siddu
2026-05-30 12:34 ` Krzysztof Kozlowski
2026-06-01  7:20   ` Yepuri Siddu
2026-06-01  7:52     ` Dmitry Baryshkov
2026-06-01  8:19       ` Krzysztof Kozlowski
2026-07-02 10:09         ` Yepuri Siddu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox