Re: [PATCH] usb: dwc3: qcom: Don't leave BCR asserted

[Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>]

On 6/18/2025 2:58 AM, Konrad Dybcio wrote:
> On 6/6/25 2:11 AM, Thinh Nguyen wrote:
>> On Wed, Jun 04, 2025, Krishna Kurapati wrote:
>>> Leaving the USB BCR asserted prevents the associated GDSC to turn on. This
>>> blocks any subsequent attempts of probing the device, e.g. after a probe
>>> deferral, with the following showing in the log:
>>>
>>> [    1.332226] usb30_prim_gdsc status stuck at 'off'
>>>
>>> Leave the BCR deasserted when exiting the driver to avoid this issue.
>>>
>>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>>
>> Is this a fix? Does this need to be backported to stable?
> 
> yes and "might as well" - this file was re-made last cycle and this
> patch won't apply without the recent
> 
> e33ebb133a24 ("usb: dwc3: qcom: Use bulk clock API and devres")
> 

I sent the patch on top of usb-next. Perhaps when I made this patch, the 
above mentioned patch was already present.

Thanks for the review. Will send a v2 with cc'ing stable and adding a 
fixes tag.

Regards,
Krishna,

> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> Konrad