From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc3: qcom: Don't leave BCR asserted
Date: Tue, 17 Jun 2025 23:28:08 +0200 [thread overview]
Message-ID: <b8f5c24b-d9f2-4a3f-9dda-183dff203003@oss.qualcomm.com> (raw)
In-Reply-To: <20250606001139.jaods5yefjccqni2@synopsys.com>
On 6/6/25 2:11 AM, Thinh Nguyen wrote:
> On Wed, Jun 04, 2025, Krishna Kurapati wrote:
>> Leaving the USB BCR asserted prevents the associated GDSC to turn on. This
>> blocks any subsequent attempts of probing the device, e.g. after a probe
>> deferral, with the following showing in the log:
>>
>> [ 1.332226] usb30_prim_gdsc status stuck at 'off'
>>
>> Leave the BCR deasserted when exiting the driver to avoid this issue.
>>
>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>
> Is this a fix? Does this need to be backported to stable?
yes and "might as well" - this file was re-made last cycle and this
patch won't apply without the recent
e33ebb133a24 ("usb: dwc3: qcom: Use bulk clock API and devres")
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2025-06-17 21:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 6:00 Krishna Kurapati
2025-06-06 0:11 ` Thinh Nguyen
2025-06-17 21:28 ` Konrad Dybcio [this message]
2025-06-18 5:22 ` Krishna Kurapati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8f5c24b-d9f2-4a3f-9dda-183dff203003@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=krishna.kurapati@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®