[PATCH] media: exynos4-is: Free control handler if ISP subdev init fails

[PATCH] media: exynos4-is: Free control handler if ISP subdev init fails

[Wentao Liang]

fimc_isp_subdev_create() initializes isp->ctrls.handler and creates a
number of standard controls. If any of them cannot be created,
handler->error is set and the function returns after cleaning up the
media entity only. The control handler still owns the memory allocated
for its buckets and for the controls created before the failure, and
neither fimc_isp_subdev_destroy() nor the caller's cleanup runs on this
error path, so that memory is leaked.

Free the control handler before returning the error.

Fixes: 9a761e436843 ("[media] exynos4-is: Add Exynos4x12 FIMC-IS driver")
Cc: stable@vger.kernel.org
Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
 drivers/media/platform/samsung/exynos4-is/fimc-isp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-isp.c b/drivers/media/platform/samsung/exynos4-is/fimc-isp.c
index a0a9093081dd..7790541a2a7a 100644
--- a/drivers/media/platform/samsung/exynos4-is/fimc-isp.c
+++ b/drivers/media/platform/samsung/exynos4-is/fimc-isp.c
@@ -761,6 +761,7 @@ int fimc_isp_subdev_create(struct fimc_isp *isp)
 
 	if (handler->error) {
 		media_entity_cleanup(&sd->entity);
+		v4l2_ctrl_handler_free(handler);
 		return handler->error;
 	}
 
-- 
2.34.1

Re: [PATCH] media: exynos4-is: Free control handler if ISP subdev init fails

[Krzysztof Kozlowski]

On Tue, 03 Nov 2026 09:46:16 +0000, Wentao Liang wrote:
> fimc_isp_subdev_create() initializes isp->ctrls.handler and creates a
> number of standard controls. If any of them cannot be created,
> handler->error is set and the function returns after cleaning up the
> media entity only. The control handler still owns the memory allocated
> for its buckets and for the controls created before the failure, and
> neither fimc_isp_subdev_destroy() nor the caller's cleanup runs on this
> error path, so that memory is leaked.
> 
> Free the control handler before returning the error.
> 
> Fixes: 9a761e436843 ("[media] exynos4-is: Add Exynos4x12 FIMC-IS driver")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
>  drivers/media/platform/samsung/exynos4-is/fimc-isp.c | 1 +
>  1 file changed, 1 insertion(+)
> 



Multiple things here:
1. Your team ignored completely previous feedback. Multiple times.

2. You use multiple identities with this email address, thus I doubt that we
   speak with an actual person.

3. Your bot does not even bother running checkpatch, right?

4. Nothing of this was reproduced nor tested.

5. Finally, the same feedback:
You sent multiple independent patches, to multiple independent
subsystems. The amount of these patches clearly suggest this was
AI generated and most likely not tested.

More importantly, you sent all this work without properly organizing
relevant patches into patchsets. This makes reviewing difficult
and might cause multiple reviewers to address the same issue.
Replying to the entire set is impossible and requires handling each
patch independently, instead of applying or discarding the set.
Maintainers also won't see the bigger picture of your work. Quite
worrying.

This is on the verge of hostile patch: bomb us with so many
contributions, we won't be able to handle them in efficient manner,
like responding ONCE to ask you to slow down.  Considering all this
is untested and LLM generated, I have even more doubts whether this
should be considered for review.

Please read kernel documentation BEFORE posting more work. It will
explain you how to identify subsystems, how to organize your work per
subsystem (so a patchset grouping multiple patches with a short cover
letter), how to document the issue discovery method and what was
or was not tested.

Best regards,
Krzysztof

Re: [PATCH] media: exynos4-is: Free control handler if ISP subdev init fails

[Krzysztof Kozlowski]

On 03/11/2026 10:46, Wentao Liang wrote:
> fimc_isp_subdev_create() initializes isp->ctrls.handler and creates a
> number of standard controls. If any of them cannot be created,
> handler->error is set and the function returns after cleaning up the
> media entity only. The control handler still owns the memory allocated
> for its buckets and for the controls created before the failure, and
> neither fimc_isp_subdev_destroy() nor the caller's cleanup runs on this
> error path, so that memory is leaked.
> 
> Free the control handler before returning the error.
> 
> Fixes: 9a761e436843 ("[media] exynos4-is: Add Exynos4x12 FIMC-IS driver")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>

This is another posting of bot ignoring feedback and probably
introducing vilnerabilities hidden in big spam posting.

Best regards,
Krzysztof