From: Jani Nikula <jani.nikula@linux.intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Maxime Ripard <mripard@kernel.org>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Dmitry Baryshkov <lumag@kernel.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] drm/tests: edid: Update CTA-861 HDMI Vendor Specific Data Block
Date: Mon, 28 Jul 2025 11:37:18 +0300 [thread overview]
Message-ID: <94c88860a39219dc29075d4c8f2ec351c7ce25f6@intel.com> (raw)
In-Reply-To: <89bce051-3732-48a8-9679-11a404bbbfb3@suse.de>
On Wed, 16 Jul 2025, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Hi
>
> Am 16.07.25 um 17:06 schrieb Maxime Ripard:
>> Hi Thomas,
>>
>> On Mon, Jul 14, 2025 at 01:02:33PM +0200, Thomas Zimmermann wrote:
>>> Hi
>>>
>>> Am 25.06.25 um 17:14 schrieb Maxime Ripard:
>>>> For some reason, the HDMI VSDBs in our kunit EDIDs had a length longer
>>>> than expected.
>>>>
>>>> While this was harmless, we should get rid of it to make it somewhat
>>>> predictable.
>>> Dump question: should these errors be kept in another test specifically for
>>> detecting this problem?
>> I'm not entirely sure what you mean here, sorry. Did you mean that we
>> should get some tests to prevent that kind of EDIDs from being accepted
>> by the kernel?
>>
>> If so, I guess it would mean getting a test suite for the EDID parser
>> itself, which is definitely something that should happen at some point
>> but seems a little out of scope to me.
>
> OK. I meant that these are ill-formed EDIDs and the kernel's EDID
> processing should handle them gracefully. A test could verify this. Not
> a blocker for this series, of course.
Going through old mails... I'll note that EDIDs in general contain so
much garbage that we simply can't reject them if there are issues. They
do need to be handled gracefully, of course.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2025-07-28 8:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 15:14 [PATCH 0/3] drm/tests: edid: Improve our kunit EDIDs Maxime Ripard
2025-06-25 15:14 ` [PATCH 1/3] drm/tests: edid: Fix monitor range limits Maxime Ripard
2025-07-10 12:09 ` Javier Martinez Canillas
2025-06-25 15:14 ` [PATCH 2/3] drm/tests: edid: Update CTA-861 HDMI Vendor Specific Data Block Maxime Ripard
2025-07-10 12:13 ` Javier Martinez Canillas
2025-07-14 11:02 ` Thomas Zimmermann
2025-07-16 15:06 ` Maxime Ripard
2025-07-16 15:34 ` Thomas Zimmermann
2025-07-28 8:37 ` Jani Nikula [this message]
2025-06-25 15:14 ` [PATCH 3/3] drm/tests: edid: Add edid-decode --check output Maxime Ripard
2025-07-10 12:16 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94c88860a39219dc29075d4c8f2ec351c7ce25f6@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®