From: Hari Bathini <hbathini@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: ast@fb.com, lkml <linux-kernel@vger.kernel.org>,
acme@kernel.org, alexander.shishkin@linux.intel.com,
mingo@redhat.com, sargun@sargun.me,
Aravinda Prasad <aravinda@linux.vnet.ibm.com>,
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
daniel@iogearbox.net
Subject: Re: [PATCH 2/2] perf tool: add container identifier entry related changes
Date: Thu, 25 Aug 2016 22:52:05 +0530 [thread overview]
Message-ID: <94cf3620-58c2-be35-6771-436e95d2efbc@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160825130427.GG10138@twins.programming.kicks-ass.net>
On Thursday 25 August 2016 06:34 PM, Peter Zijlstra wrote:
> On Thu, Aug 25, 2016 at 05:28:03PM +0530, Hari Bathini wrote:
>> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
>> index d9b80ef..d35fbd3 100644
>> --- a/tools/perf/util/evsel.c
>> +++ b/tools/perf/util/evsel.c
>> @@ -929,6 +929,8 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts,
>> if (opts->sample_transaction)
>> perf_evsel__set_sample_bit(evsel, TRANSACTION);
>>
>> + perf_evsel__set_sample_bit(evsel, CID);
>> +
>> if (opts->running_time) {
>> evsel->attr.read_format |=
>> PERF_FORMAT_TOTAL_TIME_ENABLED |
> Does this mean its enabled by default? Why? By growing the default
> sample to include everything under the sun we make profiling slower for
> everyone.
True. Will put it under a flag..
- Hari
next prev parent reply other threads:[~2016-08-25 17:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 11:57 [PATCH 1/2] perf: add container identifier entry in perf sample data Hari Bathini
2016-08-25 11:58 ` [PATCH 2/2] perf tool: add container identifier entry related changes Hari Bathini
2016-08-25 13:04 ` Peter Zijlstra
2016-08-25 17:22 ` Hari Bathini [this message]
2016-08-25 13:01 ` [PATCH 1/2] perf: add container identifier entry in perf sample data Peter Zijlstra
2016-08-25 17:20 ` Hari Bathini
2016-08-25 17:31 ` Peter Zijlstra
2016-08-26 4:05 ` Ananth N Mavinakayanahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94cf3620-58c2-be35-6771-436e95d2efbc@linux.vnet.ibm.com \
--to=hbathini@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth@linux.vnet.ibm.com \
--cc=aravinda@linux.vnet.ibm.com \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=sargun@sargun.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome