From: Marek Vasut <marek.vasut@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-mtd@lists.infradead.org
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
David Woodhouse <David.Woodhouse@intel.com>,
Richard Weinberger <richard@nod.at>,
Jason Roberts <jason.e.roberts@intel.com>,
linux-kernel@vger.kernel.org,
Chuanxiao Dong <chuanxiao.dong@intel.com>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Dinh Nguyen <dinguyen@altera.com>,
Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH 01/11] mtd: nand: denali: remove unneeded <linux/slab.h> includes
Date: Sat, 12 Nov 2016 22:28:53 +0100 [thread overview]
Message-ID: <94e0b7c7-ab2e-c7a7-fcf3-a7c4bd123008@gmail.com> (raw)
In-Reply-To: <1478666130-13413-2-git-send-email-yamada.masahiro@socionext.com>
On 11/09/2016 05:35 AM, Masahiro Yamada wrote:
> The driver calls devm_kzalloc()/devm_kfree() to allocate/free memory.
> They are declared in <linux/device.h>, not in <linux/slab.h>.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
> ---
>
> drivers/mtd/nand/denali.c | 1 -
> drivers/mtd/nand/denali_dt.c | 1 -
> drivers/mtd/nand/denali_pci.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
> index 7e2c650..062d5b5 100644
> --- a/drivers/mtd/nand/denali.c
> +++ b/drivers/mtd/nand/denali.c
> @@ -21,7 +21,6 @@
> #include <linux/dma-mapping.h>
> #include <linux/wait.h>
> #include <linux/mutex.h>
> -#include <linux/slab.h>
> #include <linux/mtd/mtd.h>
> #include <linux/module.h>
>
> diff --git a/drivers/mtd/nand/denali_dt.c b/drivers/mtd/nand/denali_dt.c
> index f821dc1..5607fcd 100644
> --- a/drivers/mtd/nand/denali_dt.c
> +++ b/drivers/mtd/nand/denali_dt.c
> @@ -21,7 +21,6 @@
> #include <linux/platform_device.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> -#include <linux/slab.h>
>
> #include "denali.h"
>
> diff --git a/drivers/mtd/nand/denali_pci.c b/drivers/mtd/nand/denali_pci.c
> index de31514..ac84323 100644
> --- a/drivers/mtd/nand/denali_pci.c
> +++ b/drivers/mtd/nand/denali_pci.c
> @@ -14,7 +14,6 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/pci.h>
> -#include <linux/slab.h>
>
> #include "denali.h"
>
>
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-11-12 21:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 4:35 [PATCH 00/11] mtd: nand: denali: first round of cleanups of Denali NAND driver Masahiro Yamada
2016-11-09 4:35 ` [PATCH 01/11] mtd: nand: denali: remove unneeded <linux/slab.h> includes Masahiro Yamada
2016-11-12 21:28 ` Marek Vasut [this message]
2016-11-09 4:35 ` [PATCH 02/11] mtd: nand: denali: remove unused struct member denali_nand_info::idx Masahiro Yamada
2016-11-12 21:29 ` Marek Vasut
2016-11-09 4:35 ` [PATCH 03/11] mtd: nand: denali: remove bogus comment about interrupt handler setup Masahiro Yamada
2016-11-12 21:29 ` Marek Vasut
2016-11-09 4:35 ` [PATCH 04/11] mtd: nand: denali: remove detect_partition_feature() Masahiro Yamada
2016-11-12 21:31 ` Marek Vasut
2016-11-09 4:35 ` [PATCH 05/11] mtd: nand: denali: remove "Spectra:" prefix from printk strings Masahiro Yamada
2016-11-12 21:35 ` Marek Vasut
2016-11-15 2:32 ` Masahiro Yamada
2016-11-18 8:42 ` Masahiro Yamada
2016-11-18 8:49 ` Marek Vasut
2016-11-19 8:25 ` Boris Brezillon
2016-11-09 4:35 ` [PATCH 06/11] mtd: nand: denali: remove unused struct member totalblks, blksperchip Masahiro Yamada
2016-11-12 21:35 ` Marek Vasut
2016-11-09 4:35 ` [PATCH 07/11] mtd: nand: denali: use managed devm_irq_request() Masahiro Yamada
2016-11-12 21:38 ` Marek Vasut
2016-11-09 4:35 ` [PATCH 08/11] mtd: nand: denali: return error code from devm_request_irq() on error Masahiro Yamada
2016-11-12 21:39 ` Marek Vasut
2016-11-09 4:35 ` [PATCH 09/11] mtd: nand: denali: return error code from nand_scan_ident/tail " Masahiro Yamada
2016-11-12 21:40 ` Marek Vasut
2016-11-09 4:35 ` [PATCH 10/11] mtd: nand: denali: remove unneeded parentheses Masahiro Yamada
2016-11-12 21:41 ` Marek Vasut
2016-11-09 4:35 ` [PATCH 11/11] mtd: nand: denali: remove debug lines of __FILE__, __LINE__, __func__ Masahiro Yamada
2016-11-12 21:41 ` Marek Vasut
2016-11-12 21:41 ` [PATCH 00/11] mtd: nand: denali: first round of cleanups of Denali NAND driver Marek Vasut
2016-11-19 8:30 ` Boris Brezillon
2016-11-19 16:15 ` Masahiro Yamada
2016-11-19 18:26 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94e0b7c7-ab2e-c7a7-fcf3-a7c4bd123008@gmail.com \
--to=marek.vasut@gmail.com \
--cc=David.Woodhouse@intel.com \
--cc=alan@linux.intel.com \
--cc=boris.brezillon@free-electrons.com \
--cc=chuanxiao.dong@intel.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dinguyen@altera.com \
--cc=dwmw2@infradead.org \
--cc=jason.e.roberts@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®