Re: [PATCH 02/11] mtd: nand: denali: remove unused struct member denali_nand_info::idx

[Marek Vasut <marek.vasut@gmail.com>]

On 11/09/2016 05:35 AM, Masahiro Yamada wrote:
> The struct member "idx" was used as an index for debug_array long
> ago, but the DEBUG_DENALI feature was removed by commit 7cfffac06ca0
> ("nand/denali: use dev_xx debug function to replace nand_dbg_print
> and some printk").  Since then, this has been only initialized, but
> never referenced.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Reviewed-by: Marek Vasut <marek.vasut@gmail.com>

> ---
> 
>  drivers/mtd/nand/denali.c | 2 --
>  drivers/mtd/nand/denali.h | 1 -
>  2 files changed, 3 deletions(-)
> 
> diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
> index 062d5b5..51ddb84 100644
> --- a/drivers/mtd/nand/denali.c
> +++ b/drivers/mtd/nand/denali.c
> @@ -1436,8 +1436,6 @@ static int denali_ooblayout_free(struct mtd_info *mtd, int section,
>  /* initialize driver data structures */
>  static void denali_drv_init(struct denali_nand_info *denali)
>  {
> -	denali->idx = 0;
> -
>  	/* setup interrupt handler */
>  	/*
>  	 * the completion object will be used to notify
> diff --git a/drivers/mtd/nand/denali.h b/drivers/mtd/nand/denali.h
> index e7ab486..0ce7344 100644
> --- a/drivers/mtd/nand/denali.h
> +++ b/drivers/mtd/nand/denali.h
> @@ -467,7 +467,6 @@ struct denali_nand_info {
>  	spinlock_t irq_lock;
>  	uint32_t irq_status;
>  	int irq_debug_array[32];
> -	int idx;
>  	int irq;
>  
>  	uint32_t devnum;	/* represent how many nands connected */
> 


-- 
Best regards,
Marek Vasut