From: "Christian König" <christian.koenig@amd.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Sumit Semwal <sumit.semwal@linaro.org>
Cc: driver-core@lists.linux.dev, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] base: Remove unused DMA_FENCE_TRACE Kconfig symbol
Date: Fri, 19 Jun 2026 12:38:54 +0200 [thread overview]
Message-ID: <9503e60a-5e8a-40f3-b5cf-1d8d0f71c9a5@amd.com> (raw)
In-Reply-To: <16fb40ded203d1e2b72f4eeecad3fd0c0d23ad6f.1781863296.git.geert@linux-m68k.org>
On 6/19/26 12:03, Geert Uytterhoeven wrote:
> Commit d72277b6c37db66b ("dma-buf: nuke DMA_FENCE_TRACE macros v2") in
> v5.16 removed all users of DMA_FENCE_TRACE on the premise that the
> Kconfig symbol did not exist. Apparently one failed to notice the
> symbol did exist since almost five years before: it was renamed from
> FENCE_TRACE to DMA_FENCE_TRACE in commit f54d1867005c3323 ("dma-buf:
> Rename struct fence to dma_fence") in v4.10.
>
> Time passed by, so remove the Kconfig symbol, as no one seems to have
> missed the functionality.
Yeah that functionality should be fully covered by trace points.
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Christian König <christian.koenig@amd.com>
Do you have commit right to drm-misc-next to push this?
Thanks,
Christian.
> ---
> drivers/base/Kconfig | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
> index f7d385cbd3ba4b2b..43f20ca95a2a6ba9 100644
> --- a/drivers/base/Kconfig
> +++ b/drivers/base/Kconfig
> @@ -222,15 +222,6 @@ config DMA_SHARED_BUFFER
> APIs extension; the file's descriptor can then be passed on to other
> driver.
>
> -config DMA_FENCE_TRACE
> - bool "Enable verbose DMA_FENCE_TRACE messages"
> - depends on DMA_SHARED_BUFFER
> - help
> - Enable the DMA_FENCE_TRACE printks. This will add extra
> - spam to the console log, but will make it easier to diagnose
> - lockup related problems for dma-buffers shared across multiple
> - devices.
> -
> config GENERIC_ARCH_TOPOLOGY
> bool
> help
next prev parent reply other threads:[~2026-06-19 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-19 10:03 Geert Uytterhoeven
2026-06-19 10:38 ` Christian König [this message]
2026-06-19 11:48 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9503e60a-5e8a-40f3-b5cf-1d8d0f71c9a5@amd.com \
--to=christian.koenig@amd.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=driver-core@lists.linux.dev \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®