* [PATCH] base: Remove unused DMA_FENCE_TRACE Kconfig symbol
@ 2026-06-19 10:03 Geert Uytterhoeven
2026-06-19 10:38 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2026-06-19 10:03 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rafael J . Wysocki, Danilo Krummrich,
Sumit Semwal, Christian König
Cc: driver-core, linux-media, dri-devel, linaro-mm-sig, linux-kernel,
Geert Uytterhoeven
Commit d72277b6c37db66b ("dma-buf: nuke DMA_FENCE_TRACE macros v2") in
v5.16 removed all users of DMA_FENCE_TRACE on the premise that the
Kconfig symbol did not exist. Apparently one failed to notice the
symbol did exist since almost five years before: it was renamed from
FENCE_TRACE to DMA_FENCE_TRACE in commit f54d1867005c3323 ("dma-buf:
Rename struct fence to dma_fence") in v4.10.
Time passed by, so remove the Kconfig symbol, as no one seems to have
missed the functionality.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/base/Kconfig | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
index f7d385cbd3ba4b2b..43f20ca95a2a6ba9 100644
--- a/drivers/base/Kconfig
+++ b/drivers/base/Kconfig
@@ -222,15 +222,6 @@ config DMA_SHARED_BUFFER
APIs extension; the file's descriptor can then be passed on to other
driver.
-config DMA_FENCE_TRACE
- bool "Enable verbose DMA_FENCE_TRACE messages"
- depends on DMA_SHARED_BUFFER
- help
- Enable the DMA_FENCE_TRACE printks. This will add extra
- spam to the console log, but will make it easier to diagnose
- lockup related problems for dma-buffers shared across multiple
- devices.
-
config GENERIC_ARCH_TOPOLOGY
bool
help
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] base: Remove unused DMA_FENCE_TRACE Kconfig symbol
2026-06-19 10:03 [PATCH] base: Remove unused DMA_FENCE_TRACE Kconfig symbol Geert Uytterhoeven
@ 2026-06-19 10:38 ` Christian König
2026-06-19 11:48 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2026-06-19 10:38 UTC (permalink / raw)
To: Geert Uytterhoeven, Greg Kroah-Hartman, Rafael J . Wysocki,
Danilo Krummrich, Sumit Semwal
Cc: driver-core, linux-media, dri-devel, linaro-mm-sig, linux-kernel
On 6/19/26 12:03, Geert Uytterhoeven wrote:
> Commit d72277b6c37db66b ("dma-buf: nuke DMA_FENCE_TRACE macros v2") in
> v5.16 removed all users of DMA_FENCE_TRACE on the premise that the
> Kconfig symbol did not exist. Apparently one failed to notice the
> symbol did exist since almost five years before: it was renamed from
> FENCE_TRACE to DMA_FENCE_TRACE in commit f54d1867005c3323 ("dma-buf:
> Rename struct fence to dma_fence") in v4.10.
>
> Time passed by, so remove the Kconfig symbol, as no one seems to have
> missed the functionality.
Yeah that functionality should be fully covered by trace points.
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Christian König <christian.koenig@amd.com>
Do you have commit right to drm-misc-next to push this?
Thanks,
Christian.
> ---
> drivers/base/Kconfig | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
> index f7d385cbd3ba4b2b..43f20ca95a2a6ba9 100644
> --- a/drivers/base/Kconfig
> +++ b/drivers/base/Kconfig
> @@ -222,15 +222,6 @@ config DMA_SHARED_BUFFER
> APIs extension; the file's descriptor can then be passed on to other
> driver.
>
> -config DMA_FENCE_TRACE
> - bool "Enable verbose DMA_FENCE_TRACE messages"
> - depends on DMA_SHARED_BUFFER
> - help
> - Enable the DMA_FENCE_TRACE printks. This will add extra
> - spam to the console log, but will make it easier to diagnose
> - lockup related problems for dma-buffers shared across multiple
> - devices.
> -
> config GENERIC_ARCH_TOPOLOGY
> bool
> help
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] base: Remove unused DMA_FENCE_TRACE Kconfig symbol
2026-06-19 10:38 ` Christian König
@ 2026-06-19 11:48 ` Geert Uytterhoeven
0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2026-06-19 11:48 UTC (permalink / raw)
To: Christian König
Cc: Greg Kroah-Hartman, Rafael J . Wysocki, Danilo Krummrich,
Sumit Semwal, driver-core, linux-media, dri-devel, linaro-mm-sig,
linux-kernel
Hi Christian,
On Fri, 19 Jun 2026 at 12:39, Christian König <christian.koenig@amd.com> wrote:
> On 6/19/26 12:03, Geert Uytterhoeven wrote:
> > Commit d72277b6c37db66b ("dma-buf: nuke DMA_FENCE_TRACE macros v2") in
> > v5.16 removed all users of DMA_FENCE_TRACE on the premise that the
> > Kconfig symbol did not exist. Apparently one failed to notice the
> > symbol did exist since almost five years before: it was renamed from
> > FENCE_TRACE to DMA_FENCE_TRACE in commit f54d1867005c3323 ("dma-buf:
> > Rename struct fence to dma_fence") in v4.10.
> >
> > Time passed by, so remove the Kconfig symbol, as no one seems to have
> > missed the functionality.
>
> Yeah that functionality should be fully covered by trace points.
>
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
Thanks!
> Do you have commit right to drm-misc-next to push this?
No, I have not.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-19 11:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-19 10:03 [PATCH] base: Remove unused DMA_FENCE_TRACE Kconfig symbol Geert Uytterhoeven
2026-06-19 10:38 ` Christian König
2026-06-19 11:48 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome