mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: mawupeng <mawupeng1@huawei.com>,
	akpm@linux-foundation.org, osalvador@suse.de,
	nao.horiguchi@gmail.com, linmiaohe@huawei.com, mhocko@suse.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm: memory_hotplug: add TTU_HWPOISON for poisoned folio during migrate
Date: Tue, 14 Jan 2025 10:35:46 +0100	[thread overview]
Message-ID: <952b7626-9504-4bdd-b57c-8ad2465815ee@redhat.com> (raw)
In-Reply-To: <8825848a-b4d2-4b0e-beee-1d889b1ee284@huawei.com>

> We have faced a different race here as follow:
> 
> CPU#0			cpu #1
> 			offline_pages
> 			do_migrate_range
> memory_failure
> TestSetPageHWPoison
> 			// folio is mark poison here
> 			unmap_poisoned_folio // should kill task here
> ...
> hwpoison_user_mappings

Interesting; TestSetPageHWPoison is called before we grab the folio 
lock, so even grabbing that around unmap_poisoned_folio() cannot 
completely help.

-- 
Cheers,

David / dhildenb


  reply	other threads:[~2025-01-14  9:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-13  8:27 [PATCH 0/2] mm: memory_failure: unmap poisoned filio during migrate properly Wupeng Ma
2025-01-13  8:27 ` [PATCH 1/2] mm: memory_hotplug: add TTU_HWPOISON for poisoned folio during migrate Wupeng Ma
2025-01-13 13:02   ` David Hildenbrand
2025-01-14  3:37     ` mawupeng
2025-01-14  9:35       ` David Hildenbrand [this message]
2025-01-13  8:27 ` [PATCH 2/2] hwpoison, memory_hotplug: lock folio before unmap hwpoisoned folio Wupeng Ma
2025-01-13 12:35   ` David Hildenbrand
2025-01-14  9:08     ` mawupeng
2025-01-14  9:40       ` David Hildenbrand
2025-01-15  2:03     ` Miaohe Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=952b7626-9504-4bdd-b57c-8ad2465815ee@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mawupeng1@huawei.com \
    --cc=mhocko@suse.com \
    --cc=nao.horiguchi@gmail.com \
    --cc=osalvador@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®