mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Like Xu <like.xu.linux@gmail.com>,
	Sean Christopherson <seanjc@google.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/14] KVM: x86: Remove unnecessary exported symbols
Date: Fri, 2 Dec 2022 19:37:24 +0100	[thread overview]
Message-ID: <95374a64-47fc-ae25-d54e-8200671acacc@redhat.com> (raw)
In-Reply-To: <20221114095606.39785-1-likexu@tencent.com>

On 11/14/22 10:55, Like Xu wrote:
> Inspired by the Sean's minor fix [1], more unnecessary (from a GPL
> developer's perspective) exported symbols could be cleaned up
> (automation to find out true positives is possible). This move helps reduce
> the attack surface of KVM modules and guides more developers to practice
> the principle of low coupling in the KVM context.
> 
> [1] https://lore.kernel.org/kvm/20221110010354.1342128-1-seanjc@google.com/

I'll squash everything in a single patch and limit the change to just 
removing EXPORT_SYMBOL_GPL().

Paolo

> Like Xu (13):
>    KVM: x86: Remove unnecessary export of kvm_inject_pending_timer_irqs()
>    KVM: x86: Remove unnecessary export of kvm_get_apic_base()
>    KVM: x86: Remove unnecessary export of kvm_set_apic_base()
>    KVM: x86: Remove unnecessary export of kvm_inject_page_fault()
>    KVM: x86: Remove unnecessary export of kvm_inject_nmi()
>    KVM: x86: Remove unnecessary export of kvm_require_cpl()
>    KVM: x86: Remove unnecessary export of kvm_emulate_as_nop()
>    KVM: x86: Remove unnecessary export of kvm_scale_tsc()
>    KVM: x86: Remove unnecessary export of kvm_vcpu_is_reset_bsp()
>    KVM: x86: Remove unnecessary export of kvm_hv_assist_page_enabled()
>    KVM: x86: Remove unnecessary export of kvm_can_use_hv_timer()
>    KVM: x86: Remove unnecessary export of kvm_lapic_hv_timer_in_use()
>    KVM: x86: Remove unnecessary export of kvm_apic_update_apicv()
> 
> Sean Christopherson (1):
>    KVM: x86: Remove unnecessary export of kvm_cpu_has_pending_timer()
> 
>   arch/x86/kvm/hyperv.c |  1 -
>   arch/x86/kvm/irq.c    |  2 --
>   arch/x86/kvm/lapic.c  |  3 ---
>   arch/x86/kvm/x86.c    | 18 +++++-------------
>   arch/x86/kvm/x86.h    |  2 ++
>   5 files changed, 7 insertions(+), 19 deletions(-)
> 


      parent reply	other threads:[~2022-12-02 18:39 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-14  9:55 Like Xu
2022-11-14  9:55 ` [PATCH 01/14] KVM: x86: Remove unnecessary export of kvm_cpu_has_pending_timer() Like Xu
2022-11-14  9:55 ` [PATCH 02/14] KVM: x86: Remove unnecessary export of kvm_inject_pending_timer_irqs() Like Xu
2022-11-14  9:55 ` [PATCH 03/14] KVM: x86: Remove unnecessary export of kvm_get_apic_base() Like Xu
2022-11-14  9:55 ` [PATCH 04/14] KVM: x86: Remove unnecessary export of kvm_set_apic_base() Like Xu
2022-11-14  9:55 ` [PATCH 05/14] KVM: x86: Remove unnecessary export of kvm_inject_page_fault() Like Xu
2022-12-01  2:04   ` Sean Christopherson
2022-12-01  2:08     ` Like Xu
2022-11-14  9:55 ` [PATCH 06/14] KVM: x86: Remove unnecessary export of kvm_inject_nmi() Like Xu
2022-12-01  2:04   ` Sean Christopherson
2022-11-14  9:55 ` [PATCH 07/14] KVM: x86: Remove unnecessary export of kvm_require_cpl() Like Xu
2022-11-14  9:56 ` [PATCH 08/14] KVM: x86: Remove unnecessary export of kvm_emulate_as_nop() Like Xu
2022-11-14  9:56 ` [PATCH 09/14] KVM: x86: Remove unnecessary export of kvm_scale_tsc() Like Xu
2022-11-14  9:56 ` [PATCH 10/14] KVM: x86: Remove unnecessary export of kvm_vcpu_is_reset_bsp() Like Xu
2022-12-01  2:07   ` Sean Christopherson
2022-12-02 18:31   ` Paolo Bonzini
2022-11-14  9:56 ` [PATCH 11/14] KVM: x86: Remove unnecessary export of kvm_hv_assist_page_enabled() Like Xu
2022-11-14  9:56 ` [PATCH 12/14] KVM: x86: Remove unnecessary export of kvm_can_use_hv_timer() Like Xu
2022-11-14  9:56 ` [PATCH 13/14] KVM: x86: Remove unnecessary export of kvm_lapic_hv_timer_in_use() Like Xu
2022-11-14  9:56 ` [PATCH 14/14] KVM: x86: Remove unnecessary export of kvm_apic_update_apicv() Like Xu
2022-12-02 18:37 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95374a64-47fc-ae25-d54e-8200671acacc@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=like.xu.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®