* Re: [PATCH] net/ibmvnic: Fix missing { in __ibmvnic_reset
2019-09-09 20:44 ` [PATCH] net/ibmvnic: Fix missing { in __ibmvnic_reset Michal Suchanek
@ 2019-09-09 21:21 ` Tyrel Datwyler
2019-09-09 22:49 ` Juliet Kim
2019-09-10 7:45 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Tyrel Datwyler @ 2019-09-09 21:21 UTC (permalink / raw)
To: Michal Suchanek, netdev, David S. Miller, Juliet Kim
Cc: linux-kernel, Thomas Falcon, Paul Mackerras, John Allen, linuxppc-dev
On 9/9/19 1:44 PM, Michal Suchanek wrote:
> Commit 1c2977c09499 ("net/ibmvnic: free reset work of removed device from queue")
> adds a } without corresponding { causing build break.
>
> Fixes: 1c2977c09499 ("net/ibmvnic: free reset work of removed device from queue")
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Reviewed-by: Tyrel Datwyler <tyreld@linux.ibm.com>
> ---
> drivers/net/ethernet/ibm/ibmvnic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
> index 6644cabc8e75..5cb55ea671e3 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -1984,7 +1984,7 @@ static void __ibmvnic_reset(struct work_struct *work)
> rwi = get_next_rwi(adapter);
> while (rwi) {
> if (adapter->state == VNIC_REMOVING ||
> - adapter->state == VNIC_REMOVED)
> + adapter->state == VNIC_REMOVED) {
> kfree(rwi);
> rc = EBUSY;
> break;
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net/ibmvnic: Fix missing { in __ibmvnic_reset
2019-09-09 20:44 ` [PATCH] net/ibmvnic: Fix missing { in __ibmvnic_reset Michal Suchanek
2019-09-09 21:21 ` Tyrel Datwyler
@ 2019-09-09 22:49 ` Juliet Kim
2019-09-10 7:45 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Juliet Kim @ 2019-09-09 22:49 UTC (permalink / raw)
To: Michal Suchanek, netdev, David S. Miller
Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Thomas Falcon, John Allen, linuxppc-dev, linux-kernel
On 9/9/19 3:44 PM, Michal Suchanek wrote:
> Commit 1c2977c09499 ("net/ibmvnic: free reset work of removed device from queue")
> adds a } without corresponding { causing build break.
>
> Fixes: 1c2977c09499 ("net/ibmvnic: free reset work of removed device from queue")
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Reviewed-by: Juliet Kim <julietk@linux.vnet.ibm.com>
> ---
> drivers/net/ethernet/ibm/ibmvnic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
> index 6644cabc8e75..5cb55ea671e3 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -1984,7 +1984,7 @@ static void __ibmvnic_reset(struct work_struct *work)
> rwi = get_next_rwi(adapter);
> while (rwi) {
> if (adapter->state == VNIC_REMOVING ||
> - adapter->state == VNIC_REMOVED)
> + adapter->state == VNIC_REMOVED) {
> kfree(rwi);
> rc = EBUSY;
> break;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net/ibmvnic: Fix missing { in __ibmvnic_reset
2019-09-09 20:44 ` [PATCH] net/ibmvnic: Fix missing { in __ibmvnic_reset Michal Suchanek
2019-09-09 21:21 ` Tyrel Datwyler
2019-09-09 22:49 ` Juliet Kim
@ 2019-09-10 7:45 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2019-09-10 7:45 UTC (permalink / raw)
To: msuchanek
Cc: netdev, julietk, benh, paulus, mpe, tlfalcon, jallen,
linuxppc-dev, linux-kernel
From: Michal Suchanek <msuchanek@suse.de>
Date: Mon, 9 Sep 2019 22:44:51 +0200
> Commit 1c2977c09499 ("net/ibmvnic: free reset work of removed device from queue")
> adds a } without corresponding { causing build break.
>
> Fixes: 1c2977c09499 ("net/ibmvnic: free reset work of removed device from queue")
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread