From: Jim Broadus <jbroadus@gmail.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
peterhuewe@gmx.de, jgg@ziepe.ca
Subject: Re: [PATCH] tpm: tpm_tis: Add optional delay after relinquish
Date: Sat, 23 May 2026 18:39:52 -0700 [thread overview]
Message-ID: <9553191e-b061-4fa1-a11c-5ad87cbf6862@gmail.com> (raw)
In-Reply-To: <ahBN9vCLmHLBqnch@kernel.org>
Hi Jarkko. The current manufacturer_id is in tpm_tis_data, not tpm_chip.
I think it makes sense to move the new did_vid to tpm_chip so it can be
used in tpm-sysfs, but it would only be set (at least initially) for the
tpm_tis driver. What do you think?
Thank you,
Jim
On 5/22/26 5:37 AM, Jarkko Sakkinen wrote:
> On Thu, May 21, 2026 at 11:03:29PM -0700, Jim Broadus wrote:
>> Thank you Jarkko. I'll do that.
>>
>> Jim
> Yeah, in this form it is quite unsable e.g., for any Linux distribution,
> and somewhat involved for the user :-)
>
> Conditionally on is much better with appropriate detection. Also, this
> way the change improves the code base a bit given that chip->did_vid is
> much more applicable than chip->manufaturer_id.
>
> BR, Jarkko
next prev parent reply other threads:[~2026-05-24 1:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 6:09 Jim Broadus
2026-05-19 13:38 ` Jim Broadus
2026-05-21 23:48 ` Jarkko Sakkinen
2026-05-22 6:03 ` Jim Broadus
2026-05-22 12:37 ` Jarkko Sakkinen
2026-05-24 1:39 ` Jim Broadus [this message]
2026-05-24 23:10 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9553191e-b061-4fa1-a11c-5ad87cbf6862@gmail.com \
--to=jbroadus@gmail.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome