From: Richard Weinberger <richard@nod.at>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Boris Brezillon <bbrezillon@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v2] jffs2: remove C++ style comments from uapi header
Date: Thu, 27 Jun 2019 09:39:03 +0200 (CEST) [thread overview]
Message-ID: <957967732.18164.1561621143523.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <CAK7LNARA62uqi8rkDeJ=zjA6vnruTAH2VGOBd4=sQMhF+FHMLA@mail.gmail.com>
----- Ursprüngliche Mail -----
> Von: "Masahiro Yamada" <yamada.masahiro@socionext.com>
> An: "richard" <richard@nod.at>
> CC: "Vignesh Raghavendra" <vigneshr@ti.com>, "Boris Brezillon" <bbrezillon@kernel.org>, "linux-kernel"
> <linux-kernel@vger.kernel.org>, "Marek Vasut" <marek.vasut@gmail.com>, "linux-mtd" <linux-mtd@lists.infradead.org>,
> "Miquel Raynal" <miquel.raynal@bootlin.com>, "Brian Norris" <computersforpeace@gmail.com>, "David Woodhouse"
> <dwmw2@infradead.org>
> Gesendet: Donnerstag, 27. Juni 2019 09:06:31
> Betreff: Re: [PATCH v2] jffs2: remove C++ style comments from uapi header
> On Tue, Jun 18, 2019 at 3:20 PM Richard Weinberger <richard@nod.at> wrote:
>>
>> ----- Ursprüngliche Mail -----
>> > Von: "Masahiro Yamada" <yamada.masahiro@socionext.com>
>> > An: "linux-mtd" <linux-mtd@lists.infradead.org>
>> > CC: "Boris Brezillon" <bbrezillon@kernel.org>, "Miquel Raynal"
>> > <miquel.raynal@bootlin.com>, "Brian Norris"
>> > <computersforpeace@gmail.com>, "Vignesh Raghavendra" <vigneshr@ti.com>, "Marek
>> > Vasut" <marek.vasut@gmail.com>,
>> > "Masahiro Yamada" <yamada.masahiro@socionext.com>, "richard" <richard@nod.at>,
>> > "David Woodhouse" <dwmw2@infradead.org>,
>> > "linux-kernel" <linux-kernel@vger.kernel.org>
>> > Gesendet: Dienstag, 18. Juni 2019 05:09:26
>> > Betreff: [PATCH v2] jffs2: remove C++ style comments from uapi header
>>
>> > Linux kernel tolerates C++ style comments these days. Actually, the
>> > SPDX License tags for .c files start with //.
>> >
>> > On the other hand, uapi headers are written in more strict C, where
>> > the C++ comment style is forbidden.
>> >
>> > I simply dropped these lines instead of fixing the comment style.
>> >
>> > This code has been always commented out since it was added around
>> > Linux 2.4.9 (i.e. commented out for more than 17 years).
>> >
>> > 'Maybe later...' will never happen.
>>
>> :-)
>>
>> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>
>> Acked-by: Richard Weinberger <richard@nod.at>
>>
>> Thanks,
>> //richard
>
>
> Will this be picked up for v5.3-rc1 ?
Yes.
Thanks,
//richard
next prev parent reply other threads:[~2019-06-27 7:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 3:09 Masahiro Yamada
2019-06-18 6:19 ` Richard Weinberger
2019-06-27 7:06 ` Masahiro Yamada
2019-06-27 7:39 ` Richard Weinberger [this message]
2019-07-13 23:37 ` Masahiro Yamada
2019-07-14 8:08 ` Richard Weinberger
2019-07-29 7:14 ` Richard Weinberger
2019-08-19 4:12 ` Masahiro Yamada
2019-08-19 4:11 ` Masahiro Yamada
2019-08-19 6:41 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=957967732.18164.1561621143523.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=vigneshr@ti.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome