mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: Tejun Heo <tj@kernel.org>
Cc: Roman Gushchin <guro@fb.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.com>,
	Mike Rapoport <rppt@linux.vnet.ibm.com>,
	kernel-team@fb.com, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH v2] selftests/cgroup: memory controller self-tests
Date: Fri, 11 May 2018 10:58:53 -0600	[thread overview]
Message-ID: <957d089f-7a88-9ff4-733a-8e082339720c@kernel.org> (raw)
In-Reply-To: <20180511162920.GV2368884@devbig577.frc2.facebook.com>

On 05/11/2018 10:29 AM, Tejun Heo wrote:
> Hello, Shuah.
> 
> On Fri, May 11, 2018 at 08:55:28AM -0600, Shuah Khan wrote:
>> I think we don't need to create a special branch and all. The following
>> should work:
>>
>> linux-next already has the skip work. What we can do is:
>>
>> Do the cleanup and test it against linux-next. In linux-next SKIP isn't PASS. If test is
>> compiled on linux-next, you will see that SKIP is SKIP. If it is compiled on the mainline,
>> it will be reported PASS, which will be a temporary state.
> 
> Hah, why not just create a branch and make sure what we see in the
> topic branch is what we'll push?  That's how these things are done
> usually.
> 

It probably doesn't need to be complex.

Unless there is a dependency with the cgroup tree and the cgroup test,
the test can go through kselftest tree with you. That is usually how
I handle kselftests.

If you think there is a dependency and it has to go through cgroup tree
then, I can give you the Ack once this TEST_* gets cleaned up.

thanks,
-- Shuah

  reply	other threads:[~2018-05-11 16:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10 16:37 Roman Gushchin
2018-05-10 18:32 ` Tejun Heo
2018-05-10 19:29   ` Shuah Khan
2018-05-11 14:32     ` Tejun Heo
2018-05-11 14:55       ` Shuah Khan
2018-05-11 16:29         ` Tejun Heo
2018-05-11 16:58           ` Shuah Khan [this message]
2018-05-11 18:03             ` Roman Gushchin
2018-05-11 19:33               ` Shuah Khan
2018-05-11 20:02                 ` Tejun Heo
2018-05-11 20:22                   ` Shuah Khan
2018-05-18 19:24                     ` Shuah Khan
2018-05-10 19:45 ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=957d089f-7a88-9ff4-733a-8e082339720c@kernel.org \
    --to=shuah@kernel.org \
    --cc=guro@fb.com \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mhocko@suse.com \
    --cc=rppt@linux.vnet.ibm.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome