From: Shuah Khan <shuah@kernel.org>
To: Tejun Heo <tj@kernel.org>
Cc: Roman Gushchin <guro@fb.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
kernel-team@fb.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH v2] selftests/cgroup: memory controller self-tests
Date: Fri, 11 May 2018 08:55:28 -0600 [thread overview]
Message-ID: <ae4dc3f9-baa6-b492-7c43-0359734440b3@kernel.org> (raw)
In-Reply-To: <20180511143228.GU2368884@devbig577.frc2.facebook.com>
On 05/11/2018 08:32 AM, Tejun Heo wrote:
> Hello, Shuah.
>
> On Thu, May 10, 2018 at 01:29:07PM -0600, Shuah Khan wrote:
>> Don't pull them yet. If Roman can redo the patches on linux-kselftest next,
>> he can pick up the SKIP changes.
>
> So, what we can do is either fix that up during / after the merge
> window or creating a separate branch which pulls from both cgroup and
> kselftest. Please let me know which way you wanna go and if the
> latter which branch I should pull (it gotta be a stable branch).
>
> Thanks.
>
I think we don't need to create a special branch and all. The following
should work:
linux-next already has the skip work. What we can do is:
Do the cleanup and test it against linux-next. In linux-next SKIP isn't PASS. If test is
compiled on linux-next, you will see that SKIP is SKIP. If it is compiled on the mainline,
it will be reported PASS, which will be a temporary state.
cgroup test will end up in linux-next anyway with crgoups tree before the merge window.
We can verify it then and make sure it is working correctly.
So I would recommend a version 3 that includes the cleanup to get rid if the TEST_* local
defines.
thanks,
-- Shuah
next prev parent reply other threads:[~2018-05-11 14:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 16:37 Roman Gushchin
2018-05-10 18:32 ` Tejun Heo
2018-05-10 19:29 ` Shuah Khan
2018-05-11 14:32 ` Tejun Heo
2018-05-11 14:55 ` Shuah Khan [this message]
2018-05-11 16:29 ` Tejun Heo
2018-05-11 16:58 ` Shuah Khan
2018-05-11 18:03 ` Roman Gushchin
2018-05-11 19:33 ` Shuah Khan
2018-05-11 20:02 ` Tejun Heo
2018-05-11 20:22 ` Shuah Khan
2018-05-18 19:24 ` Shuah Khan
2018-05-10 19:45 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae4dc3f9-baa6-b492-7c43-0359734440b3@kernel.org \
--to=shuah@kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome