* [PATCH] drm/amd/display: set variable dcn3_14_soc storage-class-specifier to static
@ 2023-04-06 18:44 Tom Rix
2023-04-10 14:48 ` Hamza Mahfooz
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-04-06 18:44 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel,
nicholas.kazlauskas, Jun.Lei, Pavle.Kotarac, chiahsuan.chung,
duncan.ma, Charlene.Liu, muansari
Cc: amd-gfx, dri-devel, linux-kernel, Tom Rix
smatch reports
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/dcn314_fpu.c:100:37: warning: symbol
'dcn3_14_soc' was not declared. Should it be static?
This variable is only used in one file so should be static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c b/drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c
index c52b76610bd2..44082f65de1f 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c
@@ -97,7 +97,7 @@ struct _vcs_dpi_ip_params_st dcn3_14_ip = {
.dcc_supported = true,
};
-struct _vcs_dpi_soc_bounding_box_st dcn3_14_soc = {
+static struct _vcs_dpi_soc_bounding_box_st dcn3_14_soc = {
/*TODO: correct dispclk/dppclk voltage level determination*/
.clock_limits = {
{
--
2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/amd/display: set variable dcn3_14_soc storage-class-specifier to static
2023-04-06 18:44 [PATCH] drm/amd/display: set variable dcn3_14_soc storage-class-specifier to static Tom Rix
@ 2023-04-10 14:48 ` Hamza Mahfooz
0 siblings, 0 replies; 2+ messages in thread
From: Hamza Mahfooz @ 2023-04-10 14:48 UTC (permalink / raw)
To: Tom Rix, harry.wentland, sunpeng.li, Rodrigo.Siqueira,
alexander.deucher, christian.koenig, Xinhui.Pan, airlied, daniel,
nicholas.kazlauskas, Jun.Lei, Pavle.Kotarac, chiahsuan.chung,
duncan.ma, Charlene.Liu, muansari
Cc: dri-devel, amd-gfx, linux-kernel
On 4/6/23 14:44, Tom Rix wrote:
> smatch reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/dcn314_fpu.c:100:37: warning: symbol
> 'dcn3_14_soc' was not declared. Should it be static?
>
> This variable is only used in one file so should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Applied, thanks!
> ---
> drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c b/drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c
> index c52b76610bd2..44082f65de1f 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c
> @@ -97,7 +97,7 @@ struct _vcs_dpi_ip_params_st dcn3_14_ip = {
> .dcc_supported = true,
> };
>
> -struct _vcs_dpi_soc_bounding_box_st dcn3_14_soc = {
> +static struct _vcs_dpi_soc_bounding_box_st dcn3_14_soc = {
> /*TODO: correct dispclk/dppclk voltage level determination*/
> .clock_limits = {
> {
--
Hamza
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-10 14:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-06 18:44 [PATCH] drm/amd/display: set variable dcn3_14_soc storage-class-specifier to static Tom Rix
2023-04-10 14:48 ` Hamza Mahfooz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®