* [PATCH] clk: starfive: Simplify .determine_rate()
@ 2023-07-07 20:02 Christophe JAILLET
2023-07-14 9:34 ` Emil Renner Berthing
2023-07-19 19:51 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2023-07-07 20:02 UTC (permalink / raw)
To: Emil Renner Berthing, Hal Feng, Michael Turquette, Stephen Boyd
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-clk
jh71x0_clk_mux_determine_rate() is the same as __clk_mux_determine_rate(),
so use the latter to save some LoC.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/clk/starfive/clk-starfive-jh71x0.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/clk/starfive/clk-starfive-jh71x0.c b/drivers/clk/starfive/clk-starfive-jh71x0.c
index b372083d11c3..aebc99264a0b 100644
--- a/drivers/clk/starfive/clk-starfive-jh71x0.c
+++ b/drivers/clk/starfive/clk-starfive-jh71x0.c
@@ -174,12 +174,6 @@ static int jh71x0_clk_set_parent(struct clk_hw *hw, u8 index)
return 0;
}
-static int jh71x0_clk_mux_determine_rate(struct clk_hw *hw,
- struct clk_rate_request *req)
-{
- return clk_mux_determine_rate_flags(hw, req, 0);
-}
-
static int jh71x0_clk_get_phase(struct clk_hw *hw)
{
struct jh71x0_clk *clk = jh71x0_clk_from(hw);
@@ -261,7 +255,7 @@ static const struct clk_ops jh71x0_clk_gdiv_ops = {
};
static const struct clk_ops jh71x0_clk_mux_ops = {
- .determine_rate = jh71x0_clk_mux_determine_rate,
+ .determine_rate = __clk_mux_determine_rate,
.set_parent = jh71x0_clk_set_parent,
.get_parent = jh71x0_clk_get_parent,
.debug_init = jh71x0_clk_debug_init,
@@ -271,7 +265,7 @@ static const struct clk_ops jh71x0_clk_gmux_ops = {
.enable = jh71x0_clk_enable,
.disable = jh71x0_clk_disable,
.is_enabled = jh71x0_clk_is_enabled,
- .determine_rate = jh71x0_clk_mux_determine_rate,
+ .determine_rate = __clk_mux_determine_rate,
.set_parent = jh71x0_clk_set_parent,
.get_parent = jh71x0_clk_get_parent,
.debug_init = jh71x0_clk_debug_init,
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: starfive: Simplify .determine_rate()
2023-07-07 20:02 [PATCH] clk: starfive: Simplify .determine_rate() Christophe JAILLET
@ 2023-07-14 9:34 ` Emil Renner Berthing
2023-07-19 19:51 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Emil Renner Berthing @ 2023-07-14 9:34 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Hal Feng, Michael Turquette, Stephen Boyd, linux-kernel,
kernel-janitors, linux-clk
On Fri, 7 Jul 2023 at 22:02, Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> jh71x0_clk_mux_determine_rate() is the same as __clk_mux_determine_rate(),
> so use the latter to save some LoC.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Thanks!
Reviewed-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
> ---
> drivers/clk/starfive/clk-starfive-jh71x0.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/clk/starfive/clk-starfive-jh71x0.c b/drivers/clk/starfive/clk-starfive-jh71x0.c
> index b372083d11c3..aebc99264a0b 100644
> --- a/drivers/clk/starfive/clk-starfive-jh71x0.c
> +++ b/drivers/clk/starfive/clk-starfive-jh71x0.c
> @@ -174,12 +174,6 @@ static int jh71x0_clk_set_parent(struct clk_hw *hw, u8 index)
> return 0;
> }
>
> -static int jh71x0_clk_mux_determine_rate(struct clk_hw *hw,
> - struct clk_rate_request *req)
> -{
> - return clk_mux_determine_rate_flags(hw, req, 0);
> -}
> -
> static int jh71x0_clk_get_phase(struct clk_hw *hw)
> {
> struct jh71x0_clk *clk = jh71x0_clk_from(hw);
> @@ -261,7 +255,7 @@ static const struct clk_ops jh71x0_clk_gdiv_ops = {
> };
>
> static const struct clk_ops jh71x0_clk_mux_ops = {
> - .determine_rate = jh71x0_clk_mux_determine_rate,
> + .determine_rate = __clk_mux_determine_rate,
> .set_parent = jh71x0_clk_set_parent,
> .get_parent = jh71x0_clk_get_parent,
> .debug_init = jh71x0_clk_debug_init,
> @@ -271,7 +265,7 @@ static const struct clk_ops jh71x0_clk_gmux_ops = {
> .enable = jh71x0_clk_enable,
> .disable = jh71x0_clk_disable,
> .is_enabled = jh71x0_clk_is_enabled,
> - .determine_rate = jh71x0_clk_mux_determine_rate,
> + .determine_rate = __clk_mux_determine_rate,
> .set_parent = jh71x0_clk_set_parent,
> .get_parent = jh71x0_clk_get_parent,
> .debug_init = jh71x0_clk_debug_init,
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: starfive: Simplify .determine_rate()
2023-07-07 20:02 [PATCH] clk: starfive: Simplify .determine_rate() Christophe JAILLET
2023-07-14 9:34 ` Emil Renner Berthing
@ 2023-07-19 19:51 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2023-07-19 19:51 UTC (permalink / raw)
To: Christophe JAILLET, Emil Renner Berthing, Hal Feng, Michael Turquette
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-clk
Quoting Christophe JAILLET (2023-07-07 13:02:18)
> jh71x0_clk_mux_determine_rate() is the same as __clk_mux_determine_rate(),
> so use the latter to save some LoC.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-19 19:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-07 20:02 [PATCH] clk: starfive: Simplify .determine_rate() Christophe JAILLET
2023-07-14 9:34 ` Emil Renner Berthing
2023-07-19 19:51 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®