mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Almeida <daniel.almeida@collabora.com>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Krzysztof Wilczy´nski" <kwilczynski@kernel.org>,
	"Benno Lossin" <lossin@kernel.org>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH v7 3/6] rust: irq: add support for non-threaded IRQs and handlers
Date: Wed, 23 Jul 2025 11:54:09 -0300	[thread overview]
Message-ID: <95A7ACD9-8D0D-41FB-A0C0-691B699CBA17@collabora.com> (raw)
In-Reply-To: <aIDxFoQV_fRLjt3h@tardis-2.local>



> On 23 Jul 2025, at 11:26, Boqun Feng <boqun.feng@gmail.com> wrote:
> 
> On Wed, Jul 23, 2025 at 10:55:20AM -0300, Daniel Almeida wrote:
>> Hi Boqun,
>> 
>> [...]
>> 
>>>> +        IrqRequest { dev, irq }
>>>> +    }
>>>> +
>>>> +    /// Returns the IRQ number of an [`IrqRequest`].
>>>> +    pub fn irq(&self) -> u32 {
>>>> +        self.irq
>>>> +    }
>>>> +}
>>>> +
>>>> +/// A registration of an IRQ handler for a given IRQ line.
>>>> +///
>>>> +/// # Examples
>>>> +///
>>>> +/// The following is an example of using `Registration`. It uses a
>>>> +/// [`AtomicU32`](core::sync::AtomicU32) to provide the interior mutability.
>>> 
>>> We are going to remove all usage of core::sync::Atomic* when the LKMM
>>> atomics [1] land. You can probably use `Completion` here (handler does
>>> complete_all(), and registration uses wait_for_completion()) because
>>> `Completion` is irq-safe. And this brings my next comment..
>> 
>> How are completions equivalent to atomics? I am trying to highlight interior
>> mutability in this example.
>> 
> 
> Well, `Completion` also has interior mutability.
> 
>> Is the LKMM atomic series getting merged during the upcoming merge window? Because my
>> understanding was that the IRQ series was ready to go in 6.17, pending a reply
> 
> Nope, it's likely to be in 6.18.
> 
>> from Thomas and some minor comments that have been mentioned in v7.
>> 
>> If the LKMM series is not ready yet, my proposal is to leave the
>> Atomics->Completion change for a future patch (or really, to just use the new
>> Atomic types introduced by your series, because again, I don't think Completion
>> is the right thing to have there).
>> 
> 
> Why? I can find a few examples that an irq handler does a
> complete_all(), e.g. gpi_process_ch_ctrl_irq() in
> drivers/dma/qcom/gpi.c. I think it's very normal for a driver thread to
> use completions to wait for an irq to happen.
> 
> But sure, this and the handler pinned initializer thing is not a blocker
> issue. However, I would like to see them resolved as soon as possible
> once merged.
> 
> Regards,
> Boqun
> 
>> 
>> - Daniel


Because it is not as explicit. The main thing we should be conveying to users
here is how to get a &mut or otherwise mutate the data when running the
handler. When people see AtomicU32, it's a quick jump to "I can make this work
by using other locks, like SpinLockIrq". Completions hide this, IMHO.

It's totally possible for someone to see this and say "ok, I can call
complete() on this, but how can I mutate the data in some random T struct?",
even though these are essentially the same thing from an interior mutability
point of view.

-- Daniel



  parent reply	other threads:[~2025-07-23 14:54 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-15 15:16 [PATCH v7 0/6] rust: add support for request_irq Daniel Almeida
2025-07-15 15:16 ` [PATCH v7 1/6] rust: irq: add irq module Daniel Almeida
2025-07-15 15:16 ` [PATCH v7 2/6] rust: irq: add flags module Daniel Almeida
2025-07-16 14:20   ` Daniel Almeida
2025-07-16 14:45     ` Alice Ryhl
2025-07-15 15:16 ` [PATCH v7 3/6] rust: irq: add support for non-threaded IRQs and handlers Daniel Almeida
2025-07-16 23:45   ` kernel test robot
2025-07-17 16:20     ` Daniel Almeida
2025-07-21 14:17       ` Alice Ryhl
2025-07-21 14:45   ` Alice Ryhl
2025-07-21 15:10     ` Daniel Almeida
2025-07-21 15:28       ` Danilo Krummrich
2025-07-21 15:39         ` Daniel Almeida
2025-07-23  4:32   ` Boqun Feng
2025-07-23  4:57     ` Boqun Feng
2025-07-23  5:35     ` Alice Ryhl
2025-07-23 13:51       ` Boqun Feng
2025-07-23 13:55     ` Daniel Almeida
2025-07-23 14:26       ` Boqun Feng
2025-07-23 14:35         ` Danilo Krummrich
2025-07-23 14:56           ` Daniel Almeida
2025-07-23 15:03             ` Danilo Krummrich
2025-07-23 15:44               ` Alice Ryhl
2025-07-23 15:52                 ` Danilo Krummrich
2025-07-23 14:54         ` Daniel Almeida [this message]
2025-07-23 15:50           ` Boqun Feng
2025-07-23 16:07             ` Daniel Almeida
2025-07-23 16:11               ` Danilo Krummrich
2025-07-23 16:18                 ` Daniel Almeida
2025-07-23 21:31                   ` Danilo Krummrich
2025-07-15 15:16 ` [PATCH v7 4/6] rust: irq: add support for threaded " Daniel Almeida
2025-07-21 14:48   ` Alice Ryhl
2025-07-15 15:16 ` [PATCH v7 5/6] rust: platform: add irq accessors Daniel Almeida
2025-07-15 15:16 ` [PATCH v7 6/6] rust: pci: " Daniel Almeida
2025-07-15 15:32 ` [PATCH v7 0/6] rust: add support for request_irq Danilo Krummrich
2025-07-22 11:41 ` Dirk Behme
2025-07-22 14:52 ` Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95A7ACD9-8D0D-41FB-A0C0-691B699CBA17@collabora.com \
    --to=daniel.almeida@collabora.com \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rafael@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®