From: Oleg Drokin <green@linuxhacker.ru>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
"David S. Miller" <davem@davemloft.net>,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bridge: Fix format string for %ul
Date: Sat, 27 Aug 2016 11:58:00 -0400 [thread overview]
Message-ID: <95BF7F27-59F7-4BDA-941B-BB00C60423A4@linuxhacker.ru> (raw)
In-Reply-To: <11e50e3c-2e1f-4614-07e3-3bd144af4f94@cogentembedded.com>
On Aug 27, 2016, at 11:13 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 8/27/2016 6:10 AM, Oleg Drokin wrote:
>
>> %ul would print an unsigned value and a letter l,
>> likely it was %lu that was meant to print the long int,
>> but in reality the values printed there are just regular signed
>
> Signed? Then you need probably "%d" or "%i"…
They are signed in the struct definition, but in reality they
designate time, so could not be negative, I imagine?
>
>> ints, so just dropping the l altogether.
>>
>> Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
> [...]
>
> MBR, Sergei
next prev parent reply other threads:[~2016-08-27 15:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 3:10 Oleg Drokin
2016-08-27 15:13 ` Sergei Shtylyov
2016-08-27 15:58 ` Oleg Drokin [this message]
2016-08-27 16:18 ` Sergei Shtylyov
2016-08-27 16:36 ` Oleg Drokin
2017-10-03 20:43 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95BF7F27-59F7-4BDA-941B-BB00C60423A4@linuxhacker.ru \
--to=green@linuxhacker.ru \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®