From: Philipp Stanner <phasta@mailbox.org>
To: "Tvrtko Ursulin" <tursulin@ursulin.net>,
"Philipp Stanner" <phasta@kernel.org>,
"Matthew Brost" <matthew.brost@intel.com>,
"Christian König" <ckoenig.leichtzumerken@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/sched: Don't crash kernel on wrong params
Date: Wed, 12 Nov 2025 13:09:05 +0100 [thread overview]
Message-ID: <95c2ecd1b370d917cf84afbf3120134c0e2d85d3.camel@mailbox.org> (raw)
In-Reply-To: <1e71b41d-38ba-425a-a370-1bb92a772014@ursulin.net>
On Wed, 2025-11-12 at 09:46 +0000, Tvrtko Ursulin wrote:
>
> On 12/11/2025 09:18, Philipp Stanner wrote:
> > drm_sched_job_arm() just panics the kernel with BUG_ON() in case of an
> > entity being NULL. If the entity is NULL, subsequent accesses will crash
> > the particular CPU anyways with a NULL pointer exception backtrace.
> >
> > Remove the BUG_ON().
> >
> > Signed-off-by: Philipp Stanner <phasta@kernel.org>
> > ---
> > Changes in v2:
> > - Drop BUG_ON() instead of replacing it. (Tvrtko)
>
> The option of removing the BUG_ON was conditional on brainstorming a bit
> whether we think the null pointer dereference is the worst that can
> happen or not.
>
> Other option was "WARN_ON_ONCE() return" in arm and push.
>
Maybe even WARN_ON() is OK to make it noticable.
I mostly care about getting rid of BUG_ON().
P.
prev parent reply other threads:[~2025-11-12 12:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 9:18 Philipp Stanner
2025-11-12 9:46 ` Tvrtko Ursulin
2025-11-12 12:09 ` Philipp Stanner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95c2ecd1b370d917cf84afbf3120134c0e2d85d3.camel@mailbox.org \
--to=phasta@mailbox.org \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.brost@intel.com \
--cc=phasta@kernel.org \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®