mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Deepti Jaggi <quic_djaggi@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, <andersson@kernel.org>,
	<konradybcio@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <quic_psodagud@quicinc.com>
Cc: <quic_ptalari@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Shazad Hussain <quic_shazhuss@quicinc.com>
Subject: Re: [PATCH v3] arm64: dts: qcom: add initial support for qcom sa8255p-ride
Date: Thu, 24 Apr 2025 21:53:35 -0700	[thread overview]
Message-ID: <95c66338-87c0-4fce-866b-6c43c1d31cd1@quicinc.com> (raw)
In-Reply-To: <f385c9eb-31ef-47c3-84a5-9f4dc86ce6f0@kernel.org>



On 4/23/25 23:19, Krzysztof Kozlowski wrote:
> On 23/04/2025 01:12, Deepti Jaggi wrote:
>> diff --git a/arch/arm64/boot/dts/qcom/sa8255p-ride.dts b/arch/arm64/boot/dts/qcom/sa8255p-ride.dts
>> new file mode 100644
>> index 000000000000..cb866f897d0a
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/sa8255p-ride.dts
>> @@ -0,0 +1,94 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) 2024-2025 Qualcomm Innovation Center, Inc. All rights reserved.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include <dt-bindings/gpio/gpio.h>
>> +
>> +#include "sa8255p.dtsi"
>> +#include "sa8255p-pmics.dtsi"
>> +#include "sa8255p-scmi.dtsi"
>> +
>> +/ {
>> +	model = "Qualcomm Technologies, Inc. SA8255P Ride";
>> +	compatible = "qcom,sa8255p-ride", "qcom,sa8255p";
> 
> NAK
> 
> Missing bindings. This is some weird process you have there. Reach to
> your internal guideline before you start posting. It explains this.
> 

I followed the approach used for other bindings [1] [2] [3], 
which were part of the original series and were sent as separate patches 
and accepted. I misjudged that the SoC binding could also be sent as a 
separate patch. I will combine the remaining bindings along with 
the device tree into a single series.
 
The UART/QUP driver changes have been posted as a separate series [4] 
along with the UART bindings. Please advise if the UART/QUP bindings should
also be included as part of next series with dt changes.
 
[1]: https://lore.kernel.org/all/20240910165926.2408630-1-quic_nkela@quicinc.com/ 
[2]: https://lore.kernel.org/all/20240910171534.2412263-1-quic_nkela@quicinc.com/ 
[3]: https://lore.kernel.org/all/20240905194741.3803345-1-quic_nkela@quicinc.com/ 
[4]: https://lore.kernel.org/all/20250418151235.27787-2-quic_ptalari@quicinc.com/
 
> Best regards,
> Krzysztof

--Regards,
Deepti

  reply	other threads:[~2025-04-25  5:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-22 23:12 Deepti Jaggi
2025-04-23  4:46 ` Shazad Hussain
2025-04-23 14:02   ` Dmitry Baryshkov
2025-04-24  4:58     ` Shazad Hussain
2025-04-24  6:19 ` Krzysztof Kozlowski
2025-04-25  4:53   ` Deepti Jaggi [this message]
2025-04-25  5:43     ` Krzysztof Kozlowski
2025-04-25  6:51       ` Deepti Jaggi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95c66338-87c0-4fce-866b-6c43c1d31cd1@quicinc.com \
    --to=quic_djaggi@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_psodagud@quicinc.com \
    --cc=quic_ptalari@quicinc.com \
    --cc=quic_shazhuss@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®