From: Paolo Bonzini <pbonzini@redhat.com>
To: Ravi Bangoria <ravi.bangoria@amd.com>,
seanjc@google.com, nikunj.dadhania@amd.com
Cc: thomas.lendacky@amd.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
hpa@zytor.com, michael.roth@amd.com, pankaj.gupta@amd.com,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
santosh.shukla@amd.com
Subject: Re: [PATCH v3 2/3] KVM: SEV-ES: Disallow SEV-ES guests when X86_FEATURE_LBRV is absent
Date: Tue, 28 May 2024 18:33:05 +0200 [thread overview]
Message-ID: <9626063d-40ed-4caa-8ac5-ba2e88b6e398@redhat.com> (raw)
In-Reply-To: <20240523121828.808-3-ravi.bangoria@amd.com>
On 5/23/24 14:18, Ravi Bangoria wrote:
> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> index 489b0183f37d..dcb5eb00a4f5 100644
> --- a/arch/x86/kvm/svm/svm.c
> +++ b/arch/x86/kvm/svm/svm.c
> @@ -5308,11 +5308,17 @@ static __init int svm_hardware_setup(void)
>
> nrips = nrips && boot_cpu_has(X86_FEATURE_NRIPS);
>
> + if (lbrv) {
> + if (!boot_cpu_has(X86_FEATURE_LBRV))
> + lbrv = false;
> + else
> + pr_info("LBR virtualization supported\n");
> + }
> /*
> * Note, SEV setup consumes npt_enabled and enable_mmio_caching (which
> * may be modified by svm_adjust_mmio_mask()), as well as nrips.
> */
Since it consumes nrips, just make lbrv non-static:
/* enable/disable Next RIP Save */
int nrips = true;
module_param(nrips, int, 0444);
Paolo
next prev parent reply other threads:[~2024-05-28 16:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 12:18 [PATCH v3 0/3] KVM: SEV-ES: Fix KVM_{GET|SET}_MSRS and LBRV handling Ravi Bangoria
2024-05-23 12:18 ` [PATCH v3 1/3] KVM: SEV-ES: Prevent MSR access post VMSA encryption Ravi Bangoria
2024-05-28 16:31 ` Paolo Bonzini
2024-05-29 10:44 ` Ravi Bangoria
2024-06-04 23:10 ` Michael Roth
2024-05-23 12:18 ` [PATCH v3 2/3] KVM: SEV-ES: Disallow SEV-ES guests when X86_FEATURE_LBRV is absent Ravi Bangoria
2024-05-28 16:33 ` Paolo Bonzini [this message]
2024-05-29 10:43 ` Ravi Bangoria
2024-05-23 12:18 ` [PATCH v3 3/3] KVM: SEV-ES: Fix LBRV code Ravi Bangoria
2024-05-30 14:03 ` Tom Lendacky
2024-05-31 4:06 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9626063d-40ed-4caa-8ac5-ba2e88b6e398@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=nikunj.dadhania@amd.com \
--cc=pankaj.gupta@amd.com \
--cc=ravi.bangoria@amd.com \
--cc=santosh.shukla@amd.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®