mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Claudiu Beznea <claudiu.beznea@tuxon.dev>
To: Mihai Sain <mihai.sain@microchip.com>,
	nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: microchip: sama7d65: add Cortex-A7 PMU node
Date: Mon, 23 Mar 2026 12:41:01 +0200	[thread overview]
Message-ID: <962e1094-49f7-4696-91f8-2dadb8686bd4@tuxon.dev> (raw)
In-Reply-To: <20260126131035.6964-2-mihai.sain@microchip.com>

Hi, Mihai,

On 1/26/26 15:10, Mihai Sain wrote:
> Add the Performance Monitoring Unit (PMU) node with the appropriate
> compatible string, interrupt line, and affinity so that perf and other
> PMU‑based tooling can function correctly on this SoC.
> 
> [root@SAMA7D65 ~]$ dmesg | grep -i pmu
> [    1.487869] hw-perfevents: enabled with armv7_cortex_a7 PMU driver, 5 (8000000f) counters available
> 
> [root@SAMA7D65 ~]$ perf list hw
> List of pre-defined events (to be used in -e or -M):
> 
> branch-instructions OR branches                    [Hardware event]
> branch-misses                                      [Hardware event]
> bus-cycles                                         [Hardware event]
> cache-misses                                       [Hardware event]
> cache-references                                   [Hardware event]
> cpu-cycles OR cycles                               [Hardware event]
> instructions                                       [Hardware event]
> 
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
> ---
>   arch/arm/boot/dts/microchip/sama7d65.dtsi | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/microchip/sama7d65.dtsi b/arch/arm/boot/dts/microchip/sama7d65.dtsi
> index 868045c650a7..1e1ca4f93969 100644
> --- a/arch/arm/boot/dts/microchip/sama7d65.dtsi
> +++ b/arch/arm/boot/dts/microchip/sama7d65.dtsi
> @@ -45,6 +45,12 @@ L2: l2-cache {
>   		};
>   	};
>   
> +	pmu {
> +		compatible = "arm,cortex-a7-pmu";
> +		interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupt-affinity = <&cpu0>;

According to the documentation [1] interrupt-affinity is not needed here. Could 
you please check?

[1] 
https://elixir.bootlin.com/linux/v7.0-rc4/source/Documentation/devicetree/bindings/arm/pmu.yaml#L107

Thank you,
Claudiu

      reply	other threads:[~2026-03-23 10:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26 13:10 Mihai Sain
2026-03-23 10:41 ` Claudiu Beznea [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=962e1094-49f7-4696-91f8-2dadb8686bd4@tuxon.dev \
    --to=claudiu.beznea@tuxon.dev \
    --cc=alexandre.belloni@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mihai.sain@microchip.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®