RE: [PATCH] scsi: ufs: Fix NOP OUT timeout value

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

* RE: [PATCH] scsi: ufs: Fix NOP OUT timeout value
       [not found] <CGME20200915001154epcms2p877997a80b59356b19d17eee0c100c74e@epcms2p8>
@ 2020-09-15  0:11 ` Daejun Park
  0 siblings, 0 replies; 6+ messages in thread
From: Daejun Park @ 2020-09-15  0:11 UTC (permalink / raw)
  To: avri.altman, jejb, martin.petersen, asutoshd, beanhuo,
	stanley.chu, cang, bvanassche, ALIM AKHTAR
  Cc: linux-scsi, linux-kernel, Sang-yoon Oh, Sung-Jun Park,
	yongmyung lee, Jinyoung CHOI, Adel Choi, SEUNGUK SHIN

> In some Samsung UFS devices, there is some booting fail issue with
> low-power UFS device. The reason of this issue is the UFS device has a
> little bit longer latency for NOP OUT response. It causes booting fail
> because NOP OUT command is issued during initialization to check whether
> the device transport protocol is ready or not. This issue is resolved by
> releasing NOP_OUT_TIMEOUT value.
> 
> NOP_OUT_TIMEOUT: 30ms -> 50ms
> 
> Signed-off-by: Daejun Park <daejun7.park@samsung.com>
> ---
>  drivers/scsi/ufs/ufshcd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 06e2439d523c..5cbd0e9e4ef8 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -36,8 +36,8 @@
>  
>  /* NOP OUT retries waiting for NOP IN response */
>  #define NOP_OUT_RETRIES    10
> -/* Timeout after 30 msecs if NOP OUT hangs without response */
> -#define NOP_OUT_TIMEOUT    30 /* msecs */
> +/* Timeout after 50 msecs if NOP OUT hangs without response */
> +#define NOP_OUT_TIMEOUT    50 /* msecs */
>  
>  /* Query request retries */
>  #define QUERY_REQ_RETRIES 3
> -- 
> 2.17.1

Hello,

Just a gentle reminder that I'd like some feedback.
Any suggestions here?

Thanks,
Daejun

^ permalink raw reply	[flat|nested] 6+ messages in thread

[parent not found: <CGME20200902025852epcms2p2a2d4ac934f4fc09233d4272c96df9ff1@epcms2p2>]

* [PATCH] scsi: ufs: Fix NOP OUT timeout value
       [not found] <CGME20200902025852epcms2p2a2d4ac934f4fc09233d4272c96df9ff1@epcms2p2>
@ 2020-09-02  2:58 ` Daejun Park
  2020-09-15  6:35   ` Avri Altman
                     ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Daejun Park @ 2020-09-02  2:58 UTC (permalink / raw)
  To: avri.altman, jejb, martin.petersen, asutoshd, beanhuo,
	stanley.chu, cang, bvanassche, ALIM AKHTAR
  Cc: linux-scsi, linux-kernel, Daejun Park, Sang-yoon Oh,
	Sung-Jun Park, yongmyung lee, Jinyoung CHOI, Adel Choi,
	SEUNGUK SHIN

In some Samsung UFS devices, there is some booting fail issue with
low-power UFS device. The reason of this issue is the UFS device has a
little bit longer latency for NOP OUT response. It causes booting fail
because NOP OUT command is issued during initialization to check whether
the device transport protocol is ready or not. This issue is resolved by
releasing NOP_OUT_TIMEOUT value.

NOP_OUT_TIMEOUT: 30ms -> 50ms

Signed-off-by: Daejun Park <daejun7.park@samsung.com>
---
 drivers/scsi/ufs/ufshcd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 06e2439d523c..5cbd0e9e4ef8 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -36,8 +36,8 @@
 
 /* NOP OUT retries waiting for NOP IN response */
 #define NOP_OUT_RETRIES    10
-/* Timeout after 30 msecs if NOP OUT hangs without response */
-#define NOP_OUT_TIMEOUT    30 /* msecs */
+/* Timeout after 50 msecs if NOP OUT hangs without response */
+#define NOP_OUT_TIMEOUT    50 /* msecs */
 
 /* Query request retries */
 #define QUERY_REQ_RETRIES 3
-- 
2.17.1



^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH] scsi: ufs: Fix NOP OUT timeout value
  2020-09-02  2:58 ` Daejun Park
@ 2020-09-15  6:35   ` Avri Altman
       [not found]   ` <CGME20200902025852epcms2p2a2d4ac934f4fc09233d4272c96df9ff1@epcms2p8>
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Avri Altman @ 2020-09-15  6:35 UTC (permalink / raw)
  To: daejun7.park, jejb, martin.petersen, asutoshd, beanhuo,
	stanley.chu, cang, bvanassche, ALIM AKHTAR
  Cc: linux-scsi, linux-kernel, Sang-yoon Oh, Sung-Jun Park,
	yongmyung lee, Jinyoung CHOI, Adel Choi, SEUNGUK SHIN

> 
> 
> In some Samsung UFS devices, there is some booting fail issue with
> low-power UFS device. The reason of this issue is the UFS device has a
> little bit longer latency for NOP OUT response. It causes booting fail
> because NOP OUT command is issued during initialization to check whether
> the device transport protocol is ready or not. This issue is resolved by
> releasing NOP_OUT_TIMEOUT value.
> 
> NOP_OUT_TIMEOUT: 30ms -> 50ms
> 
> Signed-off-by: Daejun Park <daejun7.park@samsung.com>
Acked-by: Avri Altman <avri.altman@wdc.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

[parent not found: <CGME20200902025852epcms2p2a2d4ac934f4fc09233d4272c96df9ff1@epcms2p8>]

* RE: [PATCH] scsi: ufs: Fix NOP OUT timeout value
       [not found]   ` <CGME20200902025852epcms2p2a2d4ac934f4fc09233d4272c96df9ff1@epcms2p8>
@ 2020-09-15  7:08     ` Daejun Park
  0 siblings, 0 replies; 6+ messages in thread
From: Daejun Park @ 2020-09-15  7:08 UTC (permalink / raw)
  To: Avri Altman, Daejun Park, jejb, martin.petersen, asutoshd,
	beanhuo, stanley.chu, cang, bvanassche, ALIM AKHTAR
  Cc: linux-scsi, linux-kernel, Sang-yoon Oh, Sung-Jun Park,
	yongmyung lee, Jinyoung CHOI, Adel Choi, SEUNGUK SHIN

Hi Avri,

> > In some Samsung UFS devices, there is some booting fail issue with
> > low-power UFS device. The reason of this issue is the UFS device has a
> > little bit longer latency for NOP OUT response. It causes booting fail
> > because NOP OUT command is issued during initialization to check whether
> > the device transport protocol is ready or not. This issue is resolved by
> > releasing NOP_OUT_TIMEOUT value.
> > 
> > NOP_OUT_TIMEOUT: 30ms -> 50ms
> > 
> > Signed-off-by: Daejun Park <daejun7.park@samsung.com>
> Acked-by: Avri Altman <avri.altman@wdc.com>

Thanks for the review.

Bart,
Could you review this patch, please?

Thanks,
Daejun

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] scsi: ufs: Fix NOP OUT timeout value
  2020-09-02  2:58 ` Daejun Park
  2020-09-15  6:35   ` Avri Altman
       [not found]   ` <CGME20200902025852epcms2p2a2d4ac934f4fc09233d4272c96df9ff1@epcms2p8>
@ 2020-09-16  0:14   ` Martin K. Petersen
  2020-09-22  3:56   ` Martin K. Petersen
  3 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2020-09-16  0:14 UTC (permalink / raw)
  To: Daejun Park
  Cc: avri.altman, jejb, martin.petersen, asutoshd, beanhuo,
	stanley.chu, cang, bvanassche, ALIM AKHTAR, linux-scsi,
	linux-kernel, Sang-yoon Oh, Sung-Jun Park, yongmyung lee,
	Jinyoung CHOI, Adel Choi, SEUNGUK SHIN


Daejun,

> In some Samsung UFS devices, there is some booting fail issue with
> low-power UFS device. The reason of this issue is the UFS device has a
> little bit longer latency for NOP OUT response. It causes booting fail
> because NOP OUT command is issued during initialization to check whether
> the device transport protocol is ready or not. This issue is resolved by
> releasing NOP_OUT_TIMEOUT value.

Applied to 5.10/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] scsi: ufs: Fix NOP OUT timeout value
  2020-09-02  2:58 ` Daejun Park
                     ` (2 preceding siblings ...)
  2020-09-16  0:14   ` Martin K. Petersen
@ 2020-09-22  3:56   ` Martin K. Petersen
  3 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2020-09-22  3:56 UTC (permalink / raw)
  To: jejb, stanley.chu, bvanassche, Daejun Park, ALIM AKHTAR,
	asutoshd, beanhuo, cang, avri.altman
  Cc: Martin K . Petersen, yongmyung lee, Adel Choi, Sung-Jun Park,
	linux-scsi, SEUNGUK SHIN, Jinyoung CHOI, Sang-yoon Oh,
	linux-kernel

On Wed, 02 Sep 2020 11:58:52 +0900, Daejun Park wrote:

> In some Samsung UFS devices, there is some booting fail issue with
> low-power UFS device. The reason of this issue is the UFS device has a
> little bit longer latency for NOP OUT response. It causes booting fail
> because NOP OUT command is issued during initialization to check whether
> the device transport protocol is ready or not. This issue is resolved by
> releasing NOP_OUT_TIMEOUT value.
> 
> [...]

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: ufs: Fix NOP OUT timeout value
      https://git.kernel.org/mkp/scsi/c/782e2efb749f

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-09-22  3:57 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20200915001154epcms2p877997a80b59356b19d17eee0c100c74e@epcms2p8>
2020-09-15  0:11 ` [PATCH] scsi: ufs: Fix NOP OUT timeout value Daejun Park
     [not found] <CGME20200902025852epcms2p2a2d4ac934f4fc09233d4272c96df9ff1@epcms2p2>
2020-09-02  2:58 ` Daejun Park
2020-09-15  6:35   ` Avri Altman
     [not found]   ` <CGME20200902025852epcms2p2a2d4ac934f4fc09233d4272c96df9ff1@epcms2p8>
2020-09-15  7:08     ` Daejun Park
2020-09-16  0:14   ` Martin K. Petersen
2020-09-22  3:56   ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome