From: Stephen Cameron <smcameron@yahoo.com>
To: linux-kernel@vger.kernel.org
Cc: scameron@beardog.cca.cpqcorp.net, mike.miller@hp.com
Subject: Re: hpsa: SCSI driver for HP Smart Array controllers
Date: Fri, 27 Feb 2009 18:58:57 -0800 (PST) [thread overview]
Message-ID: <968150.85968.qm@web33001.mail.mud.yahoo.com> (raw)
I see we botched this in hpsa_pci_init()
(one of the last things we changed):
+ if (prod_index == ARRAY_SIZE(products)) {
+ prod_index--;
+ if (subsystem_vendor_id == !PCI_VENDOR_ID_HP ||
+ !allow_unknown_smartarray) {
+ printk(KERN_WARNING "hpsa: Sorry, I don't "
+ "know how to access the Smart "
+ "Array controller %08lx\n",
That 2nd if should have been,
if (subsystem_vendor_id != PCI_VENDOR_ID_HP ||
-- steve
next reply other threads:[~2009-02-28 3:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-28 2:58 Stephen Cameron [this message]
2009-03-02 15:46 ` Miller, Mike (OS Dev)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=968150.85968.qm@web33001.mail.mud.yahoo.com \
--to=smcameron@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.miller@hp.com \
--cc=scameron@beardog.cca.cpqcorp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome