* Re: hpsa: SCSI driver for HP Smart Array controllers
@ 2009-02-28 2:58 Stephen Cameron
2009-03-02 15:46 ` Miller, Mike (OS Dev)
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Cameron @ 2009-02-28 2:58 UTC (permalink / raw)
To: linux-kernel; +Cc: scameron, mike.miller
I see we botched this in hpsa_pci_init()
(one of the last things we changed):
+ if (prod_index == ARRAY_SIZE(products)) {
+ prod_index--;
+ if (subsystem_vendor_id == !PCI_VENDOR_ID_HP ||
+ !allow_unknown_smartarray) {
+ printk(KERN_WARNING "hpsa: Sorry, I don't "
+ "know how to access the Smart "
+ "Array controller %08lx\n",
That 2nd if should have been,
if (subsystem_vendor_id != PCI_VENDOR_ID_HP ||
-- steve
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: hpsa: SCSI driver for HP Smart Array controllers
2009-02-28 2:58 hpsa: SCSI driver for HP Smart Array controllers Stephen Cameron
@ 2009-03-02 15:46 ` Miller, Mike (OS Dev)
0 siblings, 0 replies; 2+ messages in thread
From: Miller, Mike (OS Dev) @ 2009-03-02 15:46 UTC (permalink / raw)
To: smcameron, linux-kernel; +Cc: scameron
crap
> -----Original Message-----
> From: Stephen Cameron [mailto:smcameron@yahoo.com]
> Sent: Friday, February 27, 2009 8:59 PM
> To: linux-kernel@vger.kernel.org
> Cc: scameron@beardog.cca.cpqcorp.net; Miller, Mike (OS Dev)
> Subject: Re: hpsa: SCSI driver for HP Smart Array controllers
>
>
>
> I see we botched this in hpsa_pci_init() (one of the last
> things we changed):
>
> + if (prod_index == ARRAY_SIZE(products)) {
> + prod_index--;
> + if (subsystem_vendor_id == !PCI_VENDOR_ID_HP ||
> + !allow_unknown_smartarray) {
> + printk(KERN_WARNING "hpsa: Sorry, I don't "
> + "know how to access the Smart "
> + "Array controller %08lx\n",
>
>
> That 2nd if should have been,
>
> if (subsystem_vendor_id != PCI_VENDOR_ID_HP ||
>
> -- steve
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-02 15:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-28 2:58 hpsa: SCSI driver for HP Smart Array controllers Stephen Cameron
2009-03-02 15:46 ` Miller, Mike (OS Dev)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome