From: Florian Fainelli <f.fainelli@gmail.com>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: linux-mips@vger.kernel.org,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] MIPS: Cobalt: Include legacy IDE ports in the PCI I/O window
Date: Sun, 25 Oct 2026 12:19:56 -0700 [thread overview]
Message-ID: <96828518-81e3-4c58-b9c8-65f46beb7111@gmail.com> (raw)
In-Reply-To: <ff0e6a32-af88-432b-a976-2a432f625cb2@gmail.com>
On 10/25/2026 12:16 PM, Florian Fainelli wrote:
>
>
> On 10/24/2026 7:55 PM, Maciej W. Rozycki wrote:
>> On Thu, 22 Oct 2026, Florian Fainelli wrote:
>>
>>> Changes in v2:
>>>
>>> - implement Maciej's suggestion to reserve PCI resources first
>>> and then the rest of the peripherals
>>
>> Thanks.
>>
>>> diff --git a/arch/mips/cobalt/pci.c b/arch/mips/cobalt/pci.c
>>> index 85ec9cc31d66..29fd052766b2 100644
>>> --- a/arch/mips/cobalt/pci.c
>>> +++ b/arch/mips/cobalt/pci.c
>>> @@ -14,6 +14,8 @@
>>> #include <asm/gt64120.h>
>>> +#include <cobalt.h>
>>> +
>>
>> Hmm, why do you need it here now, a leftover from testing?
>
> Yes indeed it was a leftover from moving code around until I settled on
> the current approach.
Actually I take it back, it is to provide a declaration for
cobalt_pci_init() otherwise we get a warning with -Wmissing-prototypes
since the function used to be static and now it is not.
--
Florian
next prev parent reply other threads:[~2026-10-25 19:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 16:31 Florian Fainelli
2026-10-25 2:55 ` Maciej W. Rozycki
2026-10-25 19:16 ` Florian Fainelli
2026-10-25 19:19 ` Florian Fainelli [this message]
2026-10-26 4:38 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96828518-81e3-4c58-b9c8-65f46beb7111@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®