* [PATCH] hwmon: (dell-smm) Add Dell Pro Precision 7 16 PW716260 to fan control whitelist
@ 2026-11-11 15:04 shadyabh
2026-11-11 15:44 ` Pali Rohár
2026-11-11 17:27 ` [PATCH v2] " Shady Abu-Hussein
0 siblings, 2 replies; 6+ messages in thread
From: shadyabh @ 2026-11-11 15:04 UTC (permalink / raw)
To: Pali Rohár, Guenter Roeck; +Cc: linux-hwmon, linux-kernel, shadyabh
On the Dell Pro Precision 7 16 PW716260 the firmware fan control
cannot be overridden using the default SMM method, writes to pwmX
are ignored and pwmX_enable returns -EINVAL. The firmware AC fan
policy also requests speeds below the minimum sustainable speed of
the fans, so one fan repeatedly stops and restarts every few
seconds at low load.
Add the machine to the fan control whitelist using the
I8K_FAN_30A3_31A3 SMM codes. With this, writing 1 to pwm1_enable
disables automatic fan control, the fans follow the requested
state (0: off, 1: ~2500 RPM, 2: ~3950 RPM), and writing 2 to
pwm1_enable restores automatic fan control.
Tested on BIOS 1.5.0 with kernel 7.2.15.
Signed-off-by: shadyabh <shady.abh@gmail.com>
---
drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index 5ec487843..250d8c1e6 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1687,6 +1687,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
},
.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_30A3_31A3],
},
+ {
+ .ident = "Dell Pro Precision 7 16 PW716260",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell Pro Precision 7 16 PW716260"),
+ },
+ .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_30A3_31A3],
+ },
{ }
};
--
2.56.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] hwmon: (dell-smm) Add Dell Pro Precision 7 16 PW716260 to fan control whitelist
2026-11-11 15:04 [PATCH] hwmon: (dell-smm) Add Dell Pro Precision 7 16 PW716260 to fan control whitelist shadyabh
@ 2026-11-11 15:44 ` Pali Rohár
2026-11-11 17:27 ` [PATCH v2] " Shady Abu-Hussein
1 sibling, 0 replies; 6+ messages in thread
From: Pali Rohár @ 2026-11-11 15:44 UTC (permalink / raw)
To: shadyabh; +Cc: Armin Wolf, Guenter Roeck, linux-hwmon, linux-kernel
+Armin
On Wednesday 11 November 2026 15:04:35 shadyabh wrote:
> On the Dell Pro Precision 7 16 PW716260 the firmware fan control
> cannot be overridden using the default SMM method, writes to pwmX
> are ignored and pwmX_enable returns -EINVAL. The firmware AC fan
> policy also requests speeds below the minimum sustainable speed of
> the fans, so one fan repeatedly stops and restarts every few
> seconds at low load.
>
> Add the machine to the fan control whitelist using the
> I8K_FAN_30A3_31A3 SMM codes. With this, writing 1 to pwm1_enable
> disables automatic fan control, the fans follow the requested
> state (0: off, 1: ~2500 RPM, 2: ~3950 RPM), and writing 2 to
> pwm1_enable restores automatic fan control.
>
> Tested on BIOS 1.5.0 with kernel 7.2.15.
>
> Signed-off-by: shadyabh <shady.abh@gmail.com>
Acked-by: Pali Rohár <pali@kernel.org>
> ---
> drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 5ec487843..250d8c1e6 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1687,6 +1687,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
> },
> .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_30A3_31A3],
> },
> + {
> + .ident = "Dell Pro Precision 7 16 PW716260",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell Pro Precision 7 16 PW716260"),
> + },
> + .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_30A3_31A3],
> + },
> { }
> };
>
> --
> 2.56.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] hwmon: (dell-smm) Add Dell Pro Precision 7 16 PW716260 to fan control whitelist
2026-11-11 15:04 [PATCH] hwmon: (dell-smm) Add Dell Pro Precision 7 16 PW716260 to fan control whitelist shadyabh
2026-11-11 15:44 ` Pali Rohár
@ 2026-11-11 17:27 ` Shady Abu-Hussein
2026-11-12 15:18 ` Guenter Roeck
1 sibling, 1 reply; 6+ messages in thread
From: Shady Abu-Hussein @ 2026-11-11 17:27 UTC (permalink / raw)
To: Pali Rohár, Guenter Roeck
Cc: linux-hwmon, linux-kernel, Shady Abu-Hussein
On the Dell Pro Precision 7 16 PW716260 the firmware fan control
cannot be overridden using the default SMM method, writes to pwmX
are ignored and pwmX_enable returns -EINVAL. The firmware AC fan
policy also requests speeds below the minimum sustainable speed of
the fans, so one fan repeatedly stops and restarts every few
seconds at low load.
Add the machine to the fan control whitelist using the
I8K_FAN_30A3_31A3 SMM codes. With this, writing 1 to pwm1_enable
disables automatic fan control, the fans follow the requested
state (0: off, 1: ~2500 RPM, 2: ~3950 RPM), and writing 2 to
pwm1_enable restores automatic fan control.
Tested on BIOS 1.5.0 with kernel 7.2.15.
Signed-off-by: Shady Abu-Hussein <shady.abh@gmail.com>
---
drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index 5ec487843..250d8c1e6 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1687,6 +1687,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
},
.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_30A3_31A3],
},
+ {
+ .ident = "Dell Pro Precision 7 16 PW716260",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell Pro Precision 7 16 PW716260"),
+ },
+ .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_30A3_31A3],
+ },
{ }
};
--
2.56.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] hwmon: (dell-smm) Add Dell Pro Precision 7 16 PW716260 to fan control whitelist
2026-11-11 17:27 ` [PATCH v2] " Shady Abu-Hussein
@ 2026-11-12 15:18 ` Guenter Roeck
2026-11-12 15:23 ` Shady Abu-Hussein
0 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2026-11-12 15:18 UTC (permalink / raw)
To: Shady Abu-Hussein, Pali Rohár; +Cc: linux-hwmon, linux-kernel
On 11/11/26 09:27, Shady Abu-Hussein wrote:
> On the Dell Pro Precision 7 16 PW716260 the firmware fan control
> cannot be overridden using the default SMM method, writes to pwmX
> are ignored and pwmX_enable returns -EINVAL. The firmware AC fan
> policy also requests speeds below the minimum sustainable speed of
> the fans, so one fan repeatedly stops and restarts every few
> seconds at low load.
>
> Add the machine to the fan control whitelist using the
> I8K_FAN_30A3_31A3 SMM codes. With this, writing 1 to pwm1_enable
> disables automatic fan control, the fans follow the requested
> state (0: off, 1: ~2500 RPM, 2: ~3950 RPM), and writing 2 to
> pwm1_enable restores automatic fan control.
>
> Tested on BIOS 1.5.0 with kernel 7.2.15.
>
> Signed-off-by: Shady Abu-Hussein <shady.abh@gmail.com>
There is no change log. What changed in v2 ? Do you really expect me to
track that down myself ?
Guenter
> ---
> drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 5ec487843..250d8c1e6 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1687,6 +1687,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
> },
> .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_30A3_31A3],
> },
> + {
> + .ident = "Dell Pro Precision 7 16 PW716260",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell Pro Precision 7 16 PW716260"),
> + },
> + .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_30A3_31A3],
> + },
> { }
> };
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] hwmon: (dell-smm) Add Dell Pro Precision 7 16 PW716260 to fan control whitelist
2026-11-12 15:18 ` Guenter Roeck
@ 2026-11-12 15:23 ` Shady Abu-Hussein
2026-11-12 15:43 ` Guenter Roeck
0 siblings, 1 reply; 6+ messages in thread
From: Shady Abu-Hussein @ 2026-11-12 15:23 UTC (permalink / raw)
To: Guenter Roeck, Pali Rohár; +Cc: linux-hwmon, linux-kernel
v2 only changes the Signed-off-by/Author to use my real name instead of
a handle, per the automated DCO review on v1 — no code or commit message
changes otherwise.
On 12/11/2026 15:18, Guenter Roeck wrote:
> There is no change log. What changed in v2 ? Do you really expect me to
> track that down myself ?
>
> Guenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] hwmon: (dell-smm) Add Dell Pro Precision 7 16 PW716260 to fan control whitelist
2026-11-12 15:23 ` Shady Abu-Hussein
@ 2026-11-12 15:43 ` Guenter Roeck
0 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2026-11-12 15:43 UTC (permalink / raw)
To: Shady Abu-Hussein, Pali Rohár; +Cc: linux-hwmon, linux-kernel
On 11/12/26 07:23, Shady Abu-Hussein wrote:
> v2 only changes the Signed-off-by/Author to use my real name instead of a handle, per the automated DCO review on v1 — no code or commit message changes otherwise.
>
And that is a reason to not provide a change log ?
Guenter
>
> On 12/11/2026 15:18, Guenter Roeck wrote:
>> There is no change log. What changed in v2 ? Do you really expect me to
>> track that down myself ?
>>
>> Guenter
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-11-12 15:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-11 15:04 [PATCH] hwmon: (dell-smm) Add Dell Pro Precision 7 16 PW716260 to fan control whitelist shadyabh
2026-11-11 15:44 ` Pali Rohár
2026-11-11 17:27 ` [PATCH v2] " Shady Abu-Hussein
2026-11-12 15:18 ` Guenter Roeck
2026-11-12 15:23 ` Shady Abu-Hussein
2026-11-12 15:43 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®