From: "Sean Nyekjær" <sean@geanix.com>
To: Lee Jones <lee@kernel.org>
Cc: p.paillet@st.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mfd: stpmic1: fixup main control register and bits naming
Date: Tue, 16 May 2023 08:52:52 +0200 [thread overview]
Message-ID: <96FCF718-4FD8-4679-98DD-DCF0BE9918B7@geanix.com> (raw)
In-Reply-To: <20230515124359.GE10825@google.com>
Hi Lee,
> On 15 May 2023, at 14.43, Lee Jones <lee@kernel.org> wrote:
>
> On Fri, 28 Apr 2023, Sean Nyekjaer wrote:
>
>> Fixup main control register and bits naming so the match the naming from
>> the datasheet.
>
> I'm in two minds about this.
>
> On one hand using the names from the datasheet in the right thing to
> do, however, on the other hand, the current nomenclature appears clearer.
If you like me, tries to understand what’s happening inside the PMIC. It’s really nice to have the same naming in the software as in the datasheet.
It looks like the naming was updated in the datasheet version 9.
>
>> https://www.st.com/resource/en/datasheet/stpmic1.pdf
>>
>>
[ … ]
>>
>
> --
> Lee Jones [李琼斯]
/Sean
prev parent reply other threads:[~2023-05-16 6:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 11:28 Sean Nyekjaer
2023-04-28 11:28 ` [PATCH 2/2] mfd: stpmic1: add pmic poweroff via sys-off handler Sean Nyekjaer
2023-05-02 6:17 ` Sean Nyekjær
2023-05-15 12:46 ` Lee Jones
2023-05-15 12:43 ` [PATCH 1/2] mfd: stpmic1: fixup main control register and bits naming Lee Jones
2023-05-16 6:52 ` Sean Nyekjær [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96FCF718-4FD8-4679-98DD-DCF0BE9918B7@geanix.com \
--to=sean@geanix.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.paillet@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®