From: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
To: Stephen Boyd <swboyd@chromium.org>, <agross@kernel.org>,
<andersson@kernel.org>, <broonie@kernel.org>,
<konrad.dybcio@somainline.org>,
<krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <mturquette@baylibre.com>,
<quic_plai@quicinc.com>, <quic_rohkumar@quicinc.com>,
<robh+dt@kernel.org>
Subject: Re: [RESEND v3 4/4] clk: qcom: lpasscc-sc7280: Add resets for audioreach
Date: Thu, 19 Jan 2023 11:32:39 +0530 [thread overview]
Message-ID: <96a20619-6253-3380-9a25-5f8d8b6a47cf@quicinc.com> (raw)
In-Reply-To: <CAE-0n52ahKMzk0ho5jG1wxebm3ZE+Wfu_BunCaTR1WhN+J5jpw@mail.gmail.com>
On 1/13/2023 1:05 AM, Stephen Boyd wrote:
> Quoting Srinivasa Rao Mandadapu (2023-01-11 23:53:23)
>> On 1/12/2023 2:54 AM, Stephen Boyd wrote:
>> Thanks for your time Stephen!!!
>>> Quoting Srinivasa Rao Mandadapu (2023-01-04 08:21:37)
>>>> diff --git a/drivers/clk/qcom/lpasscc-sc7280.c b/drivers/clk/qcom/lpasscc-sc7280.c
>>>> index 85dd5b9..1efb72d 100644
>>>> --- a/drivers/clk/qcom/lpasscc-sc7280.c
>>>> +++ b/drivers/clk/qcom/lpasscc-sc7280.c
>>>> @@ -102,6 +104,18 @@ static const struct qcom_cc_desc lpass_qdsp6ss_sc7280_desc = {
>>>> .num_clks = ARRAY_SIZE(lpass_qdsp6ss_sc7280_clocks),
>>>> };
>>>>
>>>> +static const struct qcom_reset_map lpass_cc_sc7280_resets[] = {
>>>> + [LPASS_AUDIO_SWR_RX_CGCR] = { 0xa0, 1 },
>>>> + [LPASS_AUDIO_SWR_TX_CGCR] = { 0xa8, 1 },
>>>> + [LPASS_AUDIO_SWR_WSA_CGCR] = { 0xb0, 1 },
>>> Why are we adding these resets again? These are already exposed in
>>> lpassaudiocc-sc7280.c
>> As explained in previous versions, legacy path nodes are not being used
>> in ADSP based platforms, due to conflicts.
> What is legacy path nodes?
Legacy path nodes are for ADSP bypass use case such as nodes
lpass_audiocc, lpass_core, etc.
>
>> Hence lpasscc node alone being used exclusively in ADSP based solution,
>> resets are added.
> I think I understand..
>
>> In probe also, these reset controls are enabled based on
>> "qcom,adsp-pil-mode" property.
>>
> but now I'm super confused! Please help me! We shouldn't have two
> different device nodes for the same physical hardware registers.
> Instead, we should have one node. The "qcom,adsp-pil-mode" property was
> supposed to indicate the different mode of operation.
>
> Maybe the audio clk and reset drivers on sc7280 are duplicating each
> other and one of them can be removed?
Yes agreed, that for controlling same registers from two different
drivers is not good solution.
But, when we are validating ADSP solution, we have seen issues like ADSP
is not coming out of reset with the existing bypass mode
clock drivers(lpassaudiocc_sc7280.c and lpasscoreecc_sc7280.c) enabled.
As per your suggestion, will try to address that issues with
"qcom,adsp-pil-mode" property and avoid duplicating reset control code
in lpasscc driver(lpasscc_sc7280.c).
next prev parent reply other threads:[~2023-01-19 6:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 16:21 [RESEND v3 0/4] Add resets for ADSP based audio clock controller driver Srinivasa Rao Mandadapu
2023-01-04 16:21 ` [RESEND v3 1/4] dt-bindings: clock: qcom,sc7280-lpasscc: Add qcom,adsp-pil-mode property Srinivasa Rao Mandadapu
2023-01-10 10:55 ` Krzysztof Kozlowski
2023-01-11 21:19 ` Stephen Boyd
2023-01-04 16:21 ` [RESEND v3 2/4] dt-bindings: clock: qcom,sc7280-lpasscc: Add resets for audioreach Srinivasa Rao Mandadapu
2023-01-10 10:55 ` Krzysztof Kozlowski
2023-01-04 16:21 ` [RESEND v3 3/4] clk: qcom: lpasscc-sc7280: Skip qdsp6ss clock registration Srinivasa Rao Mandadapu
2023-01-11 21:22 ` Stephen Boyd
2023-01-04 16:21 ` [RESEND v3 4/4] clk: qcom: lpasscc-sc7280: Add resets for audioreach Srinivasa Rao Mandadapu
2023-01-11 21:24 ` Stephen Boyd
2023-01-12 7:53 ` Srinivasa Rao Mandadapu
2023-01-12 19:35 ` Stephen Boyd
2023-01-19 6:02 ` Srinivasa Rao Mandadapu [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-01-04 15:58 [RESEND v3 0/4] Add resets for ADSP based audio clock controller driver Srinivasa Rao Mandadapu
2023-01-04 15:58 ` [RESEND v3 4/4] clk: qcom: lpasscc-sc7280: Add resets for audioreach Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96a20619-6253-3380-9a25-5f8d8b6a47cf@quicinc.com \
--to=quic_srivasam@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_plai@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®