[PATCH] arm64: dts: rockchip: add &gmac2phy in rk3328-rock64

[PATCH] arm64: dts: rockchip: add &gmac2phy in rk3328-rock64

[Himanshu Bhavani]

Add '&gmac2phy' node to enable ethernet1 on rk3328-rock64

Signed-off-by: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
index 229fe9da9c2d..cb919367db54 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
@@ -12,6 +12,7 @@ / {
 
 	aliases {
 		ethernet0 = &gmac2io;
+		ethernet1 = &gmac2phy;
 		mmc0 = &sdmmc;
 		mmc1 = &emmc;
 	};
@@ -392,3 +393,7 @@ &vop {
 &vop_mmu {
 	status = "okay";
 };
+
+&gmac2phy {
+	staus = "okay";
+};
-- 
2.25.1

Re: [PATCH] arm64: dts: rockchip: add &gmac2phy in rk3328-rock64

[Dragan Simic]

Hello Himanshu,

On 2024-03-15 09:40, Himanshu Bhavani wrote:
> Add '&gmac2phy' node to enable ethernet1 on rk3328-rock64
> 
> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> index 229fe9da9c2d..cb919367db54 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> @@ -12,6 +12,7 @@ / {
> 
>  	aliases {
>  		ethernet0 = &gmac2io;
> +		ethernet1 = &gmac2phy;
>  		mmc0 = &sdmmc;
>  		mmc1 = &emmc;
>  	};
> @@ -392,3 +393,7 @@ &vop {
>  &vop_mmu {
>  	status = "okay";
>  };
> +
> +&gmac2phy {
> +	staus = "okay";
> +};

Unfortunately, this isn't an acceptable change to the Rock64 dts file.
Yes, there's the second built-in Ethernet interface in the RK3328 SoC,
but the Rock64 layout doesn't expose it as a separate physical network
interface, i.e. it isn't available as a port.

Such a change would be fine to be applied to the dts by hand, by someone
who actually adds a second physical network port to their Rock64.

Re: [PATCH] arm64: dts: rockchip: add &gmac2phy in rk3328-rock64

[Himanshu Bhavani]

Hello Simic,

>Unfortunately, this isn't an acceptable change to the Rock64 dts file.
>Yes, there's the second built-in Ethernet interface in the RK3328 SoC,
>but the Rock64 layout doesn't expose it as a separate physical network
>interface, i.e. it isn't available as a port.
  
I was wondering if the Rock64 lacks a port. 
According to this link: https://pine64.org/devices/rock64/, 
it seems that there is a physical network interface available on the sbc.

>Such a change would be fine to be applied to the dts by hand, by someone
>who actually adds a second physical network port to their Rock64.

Re: [PATCH] arm64: dts: rockchip: add &gmac2phy in rk3328-rock64

[Dragan Simic]

On 2024-03-15 16:02, Himanshu Bhavani wrote:
>> Unfortunately, this isn't an acceptable change to the Rock64 dts file.
>> Yes, there's the second built-in Ethernet interface in the RK3328 SoC,
>> but the Rock64 layout doesn't expose it as a separate physical network
>> interface, i.e. it isn't available as a port.
> 
> I was wondering if the Rock64 lacks a port.
> According to this link: https://pine64.org/devices/rock64/,
> it seems that there is a physical network interface available on the 
> sbc.

As I already described in my previous response, there's another Ethernet
interface in the RK3328 SoC, which the Rock64 is based on, but there's 
no
second Ethernet port on the actual printed circuit board.  That's simply
how the Rock64 was designed and manufactured.

>> Such a change would be fine to be applied to the dts by hand, by 
>> someone
>> who actually adds a second physical network port to their Rock64.