Re: [PATCH 2/3] scsi: ufs: core: Tolerate RX_FOM read failures in TX EQTR

[Can Guo <can.guo@oss.qualcomm.com>]

On 6/23/2026 5:05 PM, Peter Wang (王信友) wrote:
>
> On Sat, 2026-06-20 at 01:03 -0700, Can Guo wrote:
> > @@ -494,22 +496,30 @@ static int ufshcd_get_rx_fom(struct ufs_hba
> > *hba,
> > 
> >         /* Get FOM of host's TX lanes from device's RX_FOM. */
> >         for (lane = 0; lane < pwr_mode->lane_tx; lane++) {
> > +               h_iter->fom[lane] = 0;
> >                 ret = ufshcd_dme_peer_get(hba,
> > UIC_ARG_MIB_SEL(RX_FOM,
> >                                          
> > UIC_ARG_MPHY_RX_GEN_SEL_INDEX(lane)),
> >                                           &fom);
> > -               if (ret)
> > -                       return ret;
> > +               if (ret) {
> > +                       dev_dbg(hba->dev, "Failed to get FOM for Host
> > TX Lane %d: %d\n",
> > +                               lane, ret);
> > +                       continue;
> > +               }
> > 
>
> Hi Can,
>
> I suggest setting h_iter->fom[lane] = 0 when an error occurs,
> as this approach is clearer and improves code efficiency,
> for example:
> if (ret) {
>      h_iter->fom[lane] = 0;
>      ...
>      continue;
> }
Thanks for suggestion, and I like it, let me adopt in next version.

Thanks,
Can Guo.
>
>
> >                 h_iter->fom[lane] = (u8)fom;
> >         }
> > 
> >         /* Get FOM of device's TX lanes from host's RX_FOM. */
> >         for (lane = 0; lane < pwr_mode->lane_rx; lane++) {
> > +               d_iter->fom[lane] = 0;
> >                 ret = ufshcd_dme_get(hba, UIC_ARG_MIB_SEL(RX_FOM,
> >                                     
> > UIC_ARG_MPHY_RX_GEN_SEL_INDEX(lane)),
> >                                      &fom);
> > -               if (ret)
> > -                       return ret;
> > +               if (ret) {
> > +                       dev_dbg(hba->dev, "Failed to get FOM for
> > Device TX Lane %d: %d\n",
> > +                               lane, ret);
> > +                       continue;
> > +               }
> > 
>
> The same applies as above.
>
> Thanks
> Peter
>
> ************* MEDIATEK Confidentiality Notice
>   ********************
> The information contained in this e-mail message (including any
> attachments) may be confidential, proprietary, privileged, or otherwise
> exempt from disclosure under applicable laws. It is intended to be
> conveyed only to the designated recipient(s). Any use, dissemination,
> distribution, printing, retaining or copying of this e-mail (including its
> attachments) by unintended recipient(s) is strictly prohibited and may
> be unlawful. If you are not an intended recipient of this e-mail, or believe
>   
> that you have received this e-mail in error, please notify the sender
> immediately (by replying to this e-mail), delete any and all copies of
> this e-mail (including any attachments) from your system, and do not
> disclose the content of this e-mail to any other person. Thank you!