From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>,
patrick@stwcx.xyz, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v12 28/28] ARM: dts: aspeed: yosemite4: fix GPIO linename typo
Date: Mon, 19 Aug 2024 10:26:13 +0930 [thread overview]
Message-ID: <96c1ab665e28f49b5f52b0bc3397280a47edbbb5.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20240816092417.3651434-29-Delphine_CC_Chiu@wiwynn.com>
On Fri, 2024-08-16 at 17:24 +0800, Delphine CC Chiu wrote:
> Fix GPIO linename typo and add missing GPIO pin initial state.
>
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
> ---
> .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 554 ++++++++++++++----
> 1 file changed, 455 insertions(+), 99 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> index abd4a9173de4..4090725160f9 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> @@ -285,6 +285,8 @@ &mac2 {
> pinctrl-0 = <&pinctrl_rmii3_default>;
> use-ncsi;
> mellanox,multi-host;
> + ncsi-ctrl,start-redo-probe;
> + ncsi-ctrl,no-channel-monitor;
> };
>
> &mac3 {
> @@ -293,6 +295,8 @@ &mac3 {
> pinctrl-0 = <&pinctrl_rmii4_default>;
> use-ncsi;
> mellanox,multi-host;
> + ncsi-ctrl,start-redo-probe;
> + ncsi-ctrl,no-channel-monitor;
> };
>
> &fmc {
> @@ -327,6 +331,13 @@ mctp@10 {
> reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> };
>
> + gpio@24 {
> + compatible = "nxp,pca9506";
> + reg = <0x24>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> +
> gpio@21 {
> compatible = "nxp,pca9506";
> reg = <0x21>;
> @@ -348,13 +359,6 @@ gpio@23 {
> #gpio-cells = <2>;
> };
>
> - gpio@24 {
> - compatible = "nxp,pca9506";
> - reg = <0x24>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - };
> -
> power-sensor@40 {
> compatible = "adi,adm1281", "mps,mp5990";
> reg = <0x40>;
> @@ -373,6 +377,13 @@ mctp@10 {
> reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> };
>
> + gpio@24 {
> + compatible = "nxp,pca9506";
> + reg = <0x24>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> +
> gpio@21 {
> compatible = "nxp,pca9506";
> reg = <0x21>;
> @@ -394,13 +405,6 @@ gpio@23 {
> #gpio-cells = <2>;
> };
>
> - gpio@24 {
> - compatible = "nxp,pca9506";
> - reg = <0x24>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - };
> -
> power-sensor@40 {
> compatible = "adi,adm1281", "mps,mp5990";
> reg = <0x40>;
> @@ -419,6 +423,13 @@ mctp@10 {
> reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> };
>
> + gpio@24 {
> + compatible = "nxp,pca9506";
> + reg = <0x24>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> +
> gpio@21 {
> compatible = "nxp,pca9506";
> reg = <0x21>;
> @@ -440,13 +451,6 @@ gpio@23 {
> #gpio-cells = <2>;
> };
>
> - gpio@24 {
> - compatible = "nxp,pca9506";
> - reg = <0x24>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - };
> -
> power-sensor@40 {
> compatible = "adi,adm1281", "mps,mp5990";
> reg = <0x40>;
> @@ -465,6 +469,13 @@ mctp@10 {
> reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> };
>
> + gpio@24 {
> + compatible = "nxp,pca9506";
> + reg = <0x24>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> +
> gpio@21 {
> compatible = "nxp,pca9506";
> reg = <0x21>;
> @@ -486,13 +497,6 @@ gpio@23 {
> #gpio-cells = <2>;
> };
>
> - gpio@24 {
> - compatible = "nxp,pca9506";
> - reg = <0x24>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - };
> -
> power-sensor@40 {
> compatible = "adi,adm1281", "mps,mp5990";
> reg = <0x40>;
> @@ -511,6 +515,13 @@ mctp@10 {
> reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> };
>
> + gpio@24 {
> + compatible = "nxp,pca9506";
> + reg = <0x24>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> +
> gpio@21 {
> compatible = "nxp,pca9506";
> reg = <0x21>;
> @@ -532,13 +543,6 @@ gpio@23 {
> #gpio-cells = <2>;
> };
>
> - gpio@24 {
> - compatible = "nxp,pca9506";
> - reg = <0x24>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - };
> -
> power-sensor@40 {
> compatible = "adi,adm1281", "mps,mp5990";
> reg = <0x40>;
> @@ -557,6 +561,13 @@ mctp@10 {
> reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> };
>
> + gpio@24 {
> + compatible = "nxp,pca9506";
> + reg = <0x24>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> +
> gpio@21 {
> compatible = "nxp,pca9506";
> reg = <0x21>;
> @@ -578,13 +589,6 @@ gpio@23 {
> #gpio-cells = <2>;
> };
>
> - gpio@24 {
> - compatible = "nxp,pca9506";
> - reg = <0x24>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - };
> -
> power-sensor@40 {
> compatible = "adi,adm1281", "mps,mp5990";
> reg = <0x40>;
> @@ -603,6 +607,13 @@ mctp@10 {
> reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> };
>
> + gpio@24 {
> + compatible = "nxp,pca9506";
> + reg = <0x24>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> +
> gpio@21 {
> compatible = "nxp,pca9506";
> reg = <0x21>;
> @@ -624,13 +635,6 @@ gpio@23 {
> #gpio-cells = <2>;
> };
>
> - gpio@24 {
> - compatible = "nxp,pca9506";
> - reg = <0x24>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - };
> -
> power-sensor@40 {
> compatible = "adi,adm1281", "mps,mp5990";
> reg = <0x40>;
> @@ -649,6 +653,13 @@ mctp@10 {
> reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> };
>
> + gpio@24 {
> + compatible = "nxp,pca9506";
> + reg = <0x24>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> +
> gpio@21 {
> compatible = "nxp,pca9506";
> reg = <0x21>;
> @@ -670,13 +681,6 @@ gpio@23 {
> #gpio-cells = <2>;
> };
>
> - gpio@24 {
> - compatible = "nxp,pca9506";
> - reg = <0x24>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - };
> -
> power-sensor@40 {
> compatible = "adi,adm1281", "mps,mp5990";
> reg = <0x40>;
> @@ -687,6 +691,7 @@ power-sensor@40 {
> &i2c8 {
> status = "okay";
> bus-frequency = <400000>;
> + i2c-clk-high-min-percent = <40>;
> i2c-mux@70 {
> compatible = "nxp,pca9544";
> i2c-mux-idle-disconnect;
> @@ -798,6 +803,7 @@ eeprom@54 {
> &i2c9 {
> status = "okay";
> bus-frequency = <400000>;
> + i2c-clk-high-min-percent = <40>;
> i2c-mux@71 {
> compatible = "nxp,pca9544";
> i2c-mux-idle-disconnect;
> @@ -993,7 +999,7 @@ power-sensor@13 {
> reg = <0x13>;
> };
>
> - gpio@20 {
> + gpio_ext1: pca9555@20 {
> compatible = "nxp,pca9555";
> pinctrl-names = "default";
> gpio-controller;
> @@ -1012,7 +1018,7 @@ gpio@20 {
> "","";
> };
>
> - gpio@21 {
> + gpio_ext2: pca9555@21 {
> compatible = "nxp,pca9555";
> pinctrl-names = "default";
> gpio-controller;
> @@ -1031,7 +1037,7 @@ gpio@21 {
> "","";
> };
>
> - gpio@22 {
> + gpio_ext3: pca9555@22 {
> compatible = "nxp,pca9555";
> pinctrl-names = "default";
> gpio-controller;
> @@ -1050,7 +1056,7 @@ gpio@22 {
> "PWRGD_P12V_AUX_0","PWRGD_P12V_AUX_1";
> };
>
> - gpio@23 {
> + gpio_ext4: pca9555@23 {
> compatible = "nxp,pca9555";
> pinctrl-names = "default";
> gpio-controller;
> @@ -1070,21 +1076,21 @@ gpio@23 {
> };
>
> power-sensor@40 {
> - compatible = "mps,mp5023";
> - reg = <0x40>;
> + compatible = "mps,mp5023";
> + reg = <0x40>;
> };
>
> power-sensor@41 {
> - compatible = "ti,ina233";
> - resistor-calibration = /bits/ 16 <0x0a00>;
> - current-lsb= /bits/ 16 <0x0001>;
> - reg = <0x41>;
> + compatible = "ti,ina233";
> + resistor-calibration = /bits/ 16 <0x0a00>;
> + current-lsb= /bits/ 16 <0x0001>;
> + reg = <0x41>;
> };
>
> power-sensor@44 {
> - compatible = "ti,ina238";
> - shunt-resistor = <1000>;
> - reg = <0x44>;
> + compatible = "ti,ina238";
> + shunt-resistor = <1000>;
> + reg = <0x44>;
> };
>
> temperature-sensor@48 {
> @@ -1156,33 +1162,32 @@ rtc@6f {
> compatible = "nuvoton,nct3018y";
> reg = <0x6f>;
> };
> -
> gpio@20 {
> - compatible = "nxp,pca9506";
> - reg = <0x20>;
> - gpio-controller;
> - #gpio-cells = <2>;
> + compatible = "nxp,pca9506";
> + reg = <0x20>;
> + gpio-controller;
> + #gpio-cells = <2>;
> };
>
> gpio@21 {
> - compatible = "nxp,pca9506";
> - reg = <0x21>;
> - gpio-controller;
> - #gpio-cells = <2>;
> + compatible = "nxp,pca9506";
> + reg = <0x21>;
> + gpio-controller;
> + #gpio-cells = <2>;
> };
>
> gpio@22 {
> - compatible = "nxp,pca9506";
> - reg = <0x22>;
> - gpio-controller;
> - #gpio-cells = <2>;
> + compatible = "nxp,pca9506";
> + reg = <0x22>;
> + gpio-controller;
> + #gpio-cells = <2>;
> };
>
> gpio@23 {
> - compatible = "nxp,pca9506";
> - reg = <0x23>;
> - gpio-controller;
> - #gpio-cells = <2>;
> + compatible = "nxp,pca9506";
> + reg = <0x23>;
> + gpio-controller;
> + #gpio-cells = <2>;
> };
> };
>
> @@ -1242,35 +1247,35 @@ adc@37 {
> power-sensor@40 {
> compatible = "ti,ina233", "richtek,rtq6056";
> reg = <0x40>;
> - resistor-calibration = /bits/ 16 <0x0a00>;
> + resistor-calibration = /bits/ 16 <0x0400>;
> current-lsb= /bits/ 16 <0x0001>;
> };
>
> power-sensor@41 {
> compatible = "ti,ina233", "richtek,rtq6056";
> reg = <0x41>;
> - resistor-calibration = /bits/ 16 <0x0a00>;
> + resistor-calibration = /bits/ 16 <0x0400>;
> current-lsb= /bits/ 16 <0x0001>;
> };
>
> power-sensor@42 {
> compatible = "ti,ina233", "richtek,rtq6056";
> reg = <0x42>;
> - resistor-calibration = /bits/ 16 <0x0a00>;
> + resistor-calibration = /bits/ 16 <0x0400>;
> current-lsb= /bits/ 16 <0x0001>;
> };
>
> power-sensor@43 {
> compatible = "ti,ina233", "richtek,rtq6056";
> reg = <0x43>;
> - resistor-calibration = /bits/ 16 <0x0a00>;
> + resistor-calibration = /bits/ 16 <0x0400>;
> current-lsb= /bits/ 16 <0x0001>;
> };
>
> power-sensor@44 {
> compatible = "ti,ina233", "richtek,rtq6056";
> reg = <0x44>;
> - resistor-calibration = /bits/ 16 <0x0a00>;
> + resistor-calibration = /bits/ 16 <0x0400>;
> current-lsb= /bits/ 16 <0x0001>;
> };
>
> @@ -1323,6 +1328,42 @@ channel@5 {
> };
> };
>
> + hwmon0: hwmon@21 {
> + compatible = "nuvoton,nct7363";
It looks like this series didn't progress any further?
https://lore.kernel.org/all/20240322081158.4106326-2-kcfeng0@nuvoton.com/
Please drop these nodes for now and send a follow-up patch once the
driver and binding have been reworked and merged.
Andrew
next prev parent reply other threads:[~2024-08-19 0:56 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 9:23 [PATCH v12 00/28] Add i2c-mux and eeprom devices for Meta Yosemite 4 Delphine CC Chiu
2024-08-16 9:23 ` [PATCH v12 01/28] ARM: dts: aspeed: yosemite4: Revise i2c-mux devices Delphine CC Chiu
2024-08-19 0:25 ` Andrew Jeffery
2024-08-16 9:23 ` [PATCH v12 02/28] ARM: dts: aspeed: yosemite4: Enable adc15 Delphine CC Chiu
2024-08-16 9:23 ` [PATCH v12 03/28] ARM: dts: aspeed: yosemite4: Enable spi-gpio setting Delphine CC Chiu
2024-08-16 9:23 ` [PATCH v12 04/28] ARM: dts: aspeed: yosemite4: Enable watchdog2 Delphine CC Chiu
2024-08-16 9:23 ` [PATCH v12 05/28] ARM: dts: aspeed: yosemite4: Revise quad mode to dual mode Delphine CC Chiu
2024-08-16 9:23 ` [PATCH v12 06/28] ARM: dts: aspeed: yosemite4: Revise power sensor adm1281 for schematic change Delphine CC Chiu
2024-08-16 9:23 ` [PATCH v12 07/28] ARM: dts: aspeed: yosemite4: Add gpio pca9506 Delphine CC Chiu
2024-08-16 9:23 ` [PATCH v12 08/28] ARM: dts: aspeed: yosemite4: Remove space for adm1272 compatible Delphine CC Chiu
2024-08-16 9:23 ` [PATCH v12 09/28] ARM: dts: aspeed: yosemite4: Enable interrupt setting for pca9555 Delphine CC Chiu
2024-08-16 9:23 ` [PATCH v12 10/28] ARM: dts: aspeed: yosemite4: Add power sensor for power module reading Delphine CC Chiu
2024-08-19 0:30 ` Andrew Jeffery
2024-08-16 9:23 ` [PATCH v12 11/28] ARM: dts: aspeed: yosemite4: Add eeprom for yosemite4 use Delphine CC Chiu
2024-08-16 9:23 ` [PATCH v12 12/28] ARM: dts: aspeed: yosemite4: Remove temperature sensor for yosemite4 schematic change Delphine CC Chiu
2024-08-16 9:24 ` [PATCH v12 13/28] ARM: dts: aspeed: yosemite4: Revise adc128d818 adc mode " Delphine CC Chiu
2024-08-16 9:24 ` [PATCH v12 14/28] ARM: dts: aspeed: yosemite4: Revise ina233 config " Delphine CC Chiu
2024-08-19 0:32 ` Andrew Jeffery
2024-08-16 9:24 ` [PATCH v12 15/28] ARM: dts: aspeed: yosemite4: Remove idle state setting for yosemite4 NIC connection Delphine CC Chiu
2024-08-16 9:24 ` [PATCH v12 16/28] ARM: dts: aspeed: yosemite4: Initialize bmc gpio state Delphine CC Chiu
2024-08-16 9:24 ` [PATCH v12 17/28] ARM: dts: aspeed: yosemite4: Revise mx31790 fan tach config Delphine CC Chiu
2024-08-16 9:24 ` [PATCH v12 18/28] ARM: dts: aspeed: yosemite4: add mctp config for NIC Delphine CC Chiu
2024-08-19 0:46 ` Andrew Jeffery
2024-08-16 9:24 ` [PATCH v12 19/28] ARM: dts: aspeed: yosemite4: support mux to cpld Delphine CC Chiu
2024-08-16 9:24 ` [PATCH v12 20/28] ARM: dts: aspeed: yosemite4: support medusa board adc sensors Delphine CC Chiu
2024-08-16 9:24 ` [PATCH v12 21/28] ARM: dts: aspeed: yosemite4: support NIC eeprom Delphine CC Chiu
2024-08-16 9:24 ` [PATCH v12 22/28] ARM: dts: aspeed: yosemite4: Revise i2c duty-cycle Delphine CC Chiu
2024-08-16 9:24 ` [PATCH v12 23/28] ARM: dts: aspeed: yosemite4: add fan led config Delphine CC Chiu
2024-08-16 9:24 ` [PATCH v12 24/28] ARM: dts: aspeed: yosemite4: add XDP710 Delphine CC Chiu
2024-08-16 9:24 ` [PATCH v12 25/28] ARM: dts: aspeed: yosemite4: add RTQ6056 support Delphine CC Chiu
2024-08-16 9:24 ` [PATCH v12 26/28] ARM: dts: aspeed: yosemite4: add MP5990 support Delphine CC Chiu
2024-08-16 9:24 ` [PATCH v12 27/28] ARM: dts: aspeed: yosemite4: Adjust ioexp bus and remove mctp driver Delphine CC Chiu
2024-08-16 9:24 ` [PATCH v12 28/28] ARM: dts: aspeed: yosemite4: fix GPIO linename typo Delphine CC Chiu
2024-08-17 5:40 ` kernel test robot
2024-08-19 0:56 ` Andrew Jeffery [this message]
2024-08-19 12:48 ` Rob Herring
2024-08-19 1:09 ` [PATCH v12 00/28] Add i2c-mux and eeprom devices for Meta Yosemite 4 Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96c1ab665e28f49b5f52b0bc3397280a47edbbb5.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=Delphine_CC_Chiu@wiwynn.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@stwcx.xyz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®