From: Jie Zhan <zhanjie9@hisilicon.com>
To: Bowen Yu <yubowen8@huawei.com>, <linuxarm@huawei.com>,
<liudingyuan@h-partners.com>, <andi.shyti@kernel.org>,
<linux-i2c@vger.kernel.org>, <acpi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <rafael@kernel.org>,
<lenb@kernel.org>
Cc: <prime.zeng@hisilicon.com>, <wanghuiqiang@huawei.com>,
<xuwei5@huawei.com>, <ouyiyong1@huawei.com>
Subject: Re: [PATCH v5 2/2] i2c: hisi: Add I2C bus recovery support
Date: Tue, 13 Oct 2026 21:44:36 +0800 [thread overview]
Message-ID: <96db6147-f9f2-4f27-b43c-e3c3f9e9f94f@hisilicon.com> (raw)
In-Reply-To: <20260929121348.109556-3-yubowen8@huawei.com>
On 9/29/2026 8:13 PM, Bowen Yu wrote:
> When the I2C bus is stuck due to a slave device holding SDA low
> (e.g. during an incomplete transfer), the master has no way to recover
> the bus through normal operation. Add bus recovery support using the
> subctrl register to manually toggle SCL and generate clock pulses to
> release the bus.
>
> The recovery is performed via a second register resource (sctrl_base)
> that provides direct control over SCL/SDA lines through mux and
> output-enable bits. After recovery, the I2C controller is reset through
> the ACPI _RST method and reconfigured.
>
> Recovery is only registered when the subctrl resource is provided in
> the firmware description, keeping backward compatibility with existing
> platforms.
>
> Signed-off-by: Bowen Yu <yubowen8@huawei.com>
> ---
> drivers/i2c/busses/i2c-hisi.c | 142 ++++++++++++++++++++++++++++++++++
> 1 file changed, 142 insertions(+)
This version looks good to me now. Thanks!
Reviewed-by: Jie Zhan <zhanjie9@hisilicon.com>
next prev parent reply other threads:[~2026-10-13 13:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 12:13 [PATCH v5 0/2] HiSilicon " Bowen Yu
2026-09-29 12:13 ` [PATCH v5 1/2] ACPI: Add stub for acpi_has_method() for !CONFIG_ACPI Bowen Yu
2026-09-29 12:28 ` Rafael J. Wysocki (Intel)
2026-09-29 12:13 ` [PATCH v5 2/2] i2c: hisi: Add I2C bus recovery support Bowen Yu
2026-10-13 13:44 ` Jie Zhan [this message]
2026-10-27 10:51 ` Andi Shyti
2026-10-30 2:39 ` yubowen (H)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96db6147-f9f2-4f27-b43c-e3c3f9e9f94f@hisilicon.com \
--to=zhanjie9@hisilicon.com \
--cc=acpi@vger.kernel.org \
--cc=andi.shyti@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liudingyuan@h-partners.com \
--cc=ouyiyong1@huawei.com \
--cc=prime.zeng@hisilicon.com \
--cc=rafael@kernel.org \
--cc=wanghuiqiang@huawei.com \
--cc=xuwei5@huawei.com \
--cc=yubowen8@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®