mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chao Yu <yuchao0@huawei.com>
To: Yue Hu <zbestahu@gmail.com>, <gaoxiang25@huawei.com>,
	<gregkh@linuxfoundation.org>
Cc: <linux-erofs@lists.ozlabs.org>, <devel@driverdev.osuosl.org>,
	<linux-kernel@vger.kernel.org>, <huyue2@yulong.com>
Subject: Re: [PATCH RESEND] staging: erofs: return the error value if fill_inline_data() fails
Date: Wed, 26 Jun 2019 15:13:52 +0800	[thread overview]
Message-ID: <96f12ad4-e9dc-a688-2c26-2dd285b7b795@huawei.com> (raw)
In-Reply-To: <20190626033038.9456-1-zbestahu@gmail.com>

On 2019/6/26 11:30, Yue Hu wrote:
> From: Yue Hu <huyue2@yulong.com>
> 
> We should consider the error returned by fill_inline_data() when filling
> last page in fill_inode(). If not getting inode will be successful even
> though last page is bad. That is illogical. Also change -EAGAIN to 0 in
> fill_inline_data() to stand for successful filling.
> 
> Signed-off-by: Yue Hu <huyue2@yulong.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,

  reply	other threads:[~2019-06-26  7:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-26  3:30 Yue Hu
2019-06-26  7:13 ` Chao Yu [this message]
2019-06-26  9:02 ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96f12ad4-e9dc-a688-2c26-2dd285b7b795@huawei.com \
    --to=yuchao0@huawei.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gaoxiang25@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=huyue2@yulong.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zbestahu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®