* [PATCH RESEND] staging: erofs: return the error value if fill_inline_data() fails
@ 2019-06-26 3:30 Yue Hu
2019-06-26 7:13 ` Chao Yu
2019-06-26 9:02 ` Gao Xiang
0 siblings, 2 replies; 3+ messages in thread
From: Yue Hu @ 2019-06-26 3:30 UTC (permalink / raw)
To: gaoxiang25, yuchao0, gregkh; +Cc: linux-erofs, devel, linux-kernel, huyue2
From: Yue Hu <huyue2@yulong.com>
We should consider the error returned by fill_inline_data() when filling
last page in fill_inode(). If not getting inode will be successful even
though last page is bad. That is illogical. Also change -EAGAIN to 0 in
fill_inline_data() to stand for successful filling.
Signed-off-by: Yue Hu <huyue2@yulong.com>
---
drivers/staging/erofs/inode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
index d6e1e16..1433f25 100644
--- a/drivers/staging/erofs/inode.c
+++ b/drivers/staging/erofs/inode.c
@@ -156,7 +156,7 @@ static int fill_inline_data(struct inode *inode, void *data,
inode->i_link = lnk;
set_inode_fast_symlink(inode);
}
- return -EAGAIN;
+ return 0;
}
static int fill_inode(struct inode *inode, int isdir)
@@ -223,7 +223,7 @@ static int fill_inode(struct inode *inode, int isdir)
inode->i_mapping->a_ops = &erofs_raw_access_aops;
/* fill last page if inline data is available */
- fill_inline_data(inode, data, ofs);
+ err = fill_inline_data(inode, data, ofs);
}
out_unlock:
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] staging: erofs: return the error value if fill_inline_data() fails
2019-06-26 3:30 [PATCH RESEND] staging: erofs: return the error value if fill_inline_data() fails Yue Hu
@ 2019-06-26 7:13 ` Chao Yu
2019-06-26 9:02 ` Gao Xiang
1 sibling, 0 replies; 3+ messages in thread
From: Chao Yu @ 2019-06-26 7:13 UTC (permalink / raw)
To: Yue Hu, gaoxiang25, gregkh; +Cc: linux-erofs, devel, linux-kernel, huyue2
On 2019/6/26 11:30, Yue Hu wrote:
> From: Yue Hu <huyue2@yulong.com>
>
> We should consider the error returned by fill_inline_data() when filling
> last page in fill_inode(). If not getting inode will be successful even
> though last page is bad. That is illogical. Also change -EAGAIN to 0 in
> fill_inline_data() to stand for successful filling.
>
> Signed-off-by: Yue Hu <huyue2@yulong.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] staging: erofs: return the error value if fill_inline_data() fails
2019-06-26 3:30 [PATCH RESEND] staging: erofs: return the error value if fill_inline_data() fails Yue Hu
2019-06-26 7:13 ` Chao Yu
@ 2019-06-26 9:02 ` Gao Xiang
1 sibling, 0 replies; 3+ messages in thread
From: Gao Xiang @ 2019-06-26 9:02 UTC (permalink / raw)
To: Yue Hu, yuchao0, gregkh
Cc: linux-erofs, devel, linux-kernel, huyue2, Miao Xie
Hi Yue,
On 2019/6/26 11:30, Yue Hu wrote:
> From: Yue Hu <huyue2@yulong.com>
>
> We should consider the error returned by fill_inline_data() when filling
> last page in fill_inode(). If not getting inode will be successful even
> though last page is bad. That is illogical. Also change -EAGAIN to 0 in
> fill_inline_data() to stand for successful filling.
>
> Signed-off-by: Yue Hu <huyue2@yulong.com>
ditto, add the tags from other guyes.
Thanks,
Gao Xiang
> ---
> drivers/staging/erofs/inode.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
> index d6e1e16..1433f25 100644
> --- a/drivers/staging/erofs/inode.c
> +++ b/drivers/staging/erofs/inode.c
> @@ -156,7 +156,7 @@ static int fill_inline_data(struct inode *inode, void *data,
> inode->i_link = lnk;
> set_inode_fast_symlink(inode);
> }
> - return -EAGAIN;
> + return 0;
> }
>
> static int fill_inode(struct inode *inode, int isdir)
> @@ -223,7 +223,7 @@ static int fill_inode(struct inode *inode, int isdir)
> inode->i_mapping->a_ops = &erofs_raw_access_aops;
>
> /* fill last page if inline data is available */
> - fill_inline_data(inode, data, ofs);
> + err = fill_inline_data(inode, data, ofs);
> }
>
> out_unlock:
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-26 9:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-26 3:30 [PATCH RESEND] staging: erofs: return the error value if fill_inline_data() fails Yue Hu
2019-06-26 7:13 ` Chao Yu
2019-06-26 9:02 ` Gao Xiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®