* [PATCH] media: iris: fix ltr count rc_type validity check in gen2
@ 2026-10-29 3:12 Wangao Wang
2026-11-02 14:13 ` Vikash Garodia
0 siblings, 1 reply; 2+ messages in thread
From: Wangao Wang @ 2026-10-29 3:12 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel, stable, Wangao Wang
The condition was inverted: CBR_VFR, CBR_CFR and RC_OFF are the valid
rc_types for LTR, so reject anything that does NOT match these types.
Fixes: 6870381285b8 ("media: qcom: iris: Add Long-Term Reference support for encoder")
Signed-off-by: Wangao Wang <wangao.wang@oss.qualcomm.com>
---
drivers/media/platform/qcom/iris/iris_ctrls.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/platform/qcom/iris/iris_ctrls.c
index 4f2633bbb49f81f080ffbe91569d38e954ad15a1..2fd5cec16faebeabe69b836679db8cdbf89b4fac 100644
--- a/drivers/media/platform/qcom/iris/iris_ctrls.c
+++ b/drivers/media/platform/qcom/iris/iris_ctrls.c
@@ -1279,9 +1279,9 @@ int iris_set_ltr_count_gen2(struct iris_inst *inst, enum platform_inst_fw_cap_ty
if (!ltr_count)
return -EINVAL;
- if (inst->hfi_rc_type == HFI_RC_CBR_VFR ||
- inst->hfi_rc_type == HFI_RC_CBR_CFR ||
- inst->hfi_rc_type == HFI_RC_OFF) {
+ if (inst->hfi_rc_type != HFI_RC_CBR_VFR &&
+ inst->hfi_rc_type != HFI_RC_CBR_CFR &&
+ inst->hfi_rc_type != HFI_RC_OFF) {
inst->fw_caps[LTR_COUNT].value = 0;
return -EINVAL;
}
---
base-commit: 6d0933ae9d46674a6ea63a87e9e9ab4e662670c9
change-id: 20261029-gen2_ltr_fix-0a9b18cbe94c
Best regards,
--
Wangao Wang <wangao.wang@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] media: iris: fix ltr count rc_type validity check in gen2
2026-10-29 3:12 [PATCH] media: iris: fix ltr count rc_type validity check in gen2 Wangao Wang
@ 2026-11-02 14:13 ` Vikash Garodia
0 siblings, 0 replies; 2+ messages in thread
From: Vikash Garodia @ 2026-11-02 14:13 UTC (permalink / raw)
To: Wangao Wang, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel, stable
On 10/29/2026 8:42 AM, Wangao Wang wrote:
> The condition was inverted: CBR_VFR, CBR_CFR and RC_OFF are the valid
> rc_types for LTR, so reject anything that does NOT match these types.
>
> Fixes: 6870381285b8 ("media: qcom: iris: Add Long-Term Reference support for encoder")
> Signed-off-by: Wangao Wang<wangao.wang@oss.qualcomm.com>
> ---
> drivers/media/platform/qcom/iris/iris_ctrls.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-02 14:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-29 3:12 [PATCH] media: iris: fix ltr count rc_type validity check in gen2 Wangao Wang
2026-11-02 14:13 ` Vikash Garodia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®